All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jani Nikula <jani.nikula@linux.intel.com>
To: John Watts <contact@jookia.org>, dri-devel@lists.freedesktop.org
Subject: Re: How to specify panel bit order in driver?
Date: Fri, 28 Jun 2024 10:45:48 +0300	[thread overview]
Message-ID: <87le2pbjdf.fsf@intel.com> (raw)
In-Reply-To: <Zn4z_OJJ07xg_xmh@titan>

On Fri, 28 Jun 2024, John Watts <contact@jookia.org> wrote:
> Hello there,
>
> A while ago I added support for the FS035VG158 panel to the kernel, with its
> use case being on a Allwinner T113 board.

Might be helpful to actually point at the source code or commits or
something.

> While troubleshooting some other issue (I will be posting about that this
> weekend) I found that I need to tell the panel controller to use a bit depth of
> 18-bit in order for the panel to work correctly.
>
> I plan to add another panel to the kernel that also requires setting the bit
> depth, but has more configurations than just 24, 18, 16, it also supports
> packing 18 of the bits together.
>
> How all of this is configured depends on how the board and panel are wired
> together, it can't be determined at runtime based on pixel formats or anything
> like that. It seems to me that this needs to be specified in the device tree.
>
> My question is: How would I represent this? A property like 'bit-depth'?
> 'color-mapping'? Or is there already some subsystem or convention designed for
> this?

Maybe look at include/uapi/drm/drm_fourcc.h, and how the DRM_FORMAT_*
macros are used.

Can't help you with device tree, but maybe this gives you pointers to
other places for examples.


HTH,
Jani.


-- 
Jani Nikula, Intel

  reply	other threads:[~2024-06-28  7:45 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-28  3:54 How to specify panel bit order in driver? John Watts
2024-06-28  7:45 ` Jani Nikula [this message]
2024-06-28 16:39   ` John Watts
2024-07-02 11:30     ` Dmitry Baryshkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87le2pbjdf.fsf@intel.com \
    --to=jani.nikula@linux.intel.com \
    --cc=contact@jookia.org \
    --cc=dri-devel@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.