All of lore.kernel.org
 help / color / mirror / Atom feed
From: John Watts <contact@jookia.org>
To: Jani Nikula <jani.nikula@linux.intel.com>
Cc: dri-devel@lists.freedesktop.org
Subject: Re: How to specify panel bit order in driver?
Date: Sat, 29 Jun 2024 02:39:16 +1000	[thread overview]
Message-ID: <Zn7nNMti5pdX67DH@titan> (raw)
In-Reply-To: <87le2pbjdf.fsf@intel.com>

Hi Jani,

On Fri, Jun 28, 2024 at 10:45:48AM +0300, Jani Nikula wrote:
> Might be helpful to actually point at the source code or commits or
> something.

The source code is here: drivers/gpu/drm/panel/panel-newvision-nv3052c.c
It's just a standard MIPI DBI panel. It reports using an RGB888 bus format.

> Maybe look at include/uapi/drm/drm_fourcc.h, and how the DRM_FORMAT_*
> macros are used.
> 
> Can't help you with device tree, but maybe this gives you pointers to
> other places for examples.

Currently it works like this:

- DRM uses 24-bit depth
- CRTC puts out a 24-bit signal
- This gets output over LCD pins
- The PCB drops 2 bits per channel by wiring 6 pins to GND
- The panel is told to only use 18 bits

Getting DRM to use MEDIA_BUS_FMT_RGB666_1X18 would be nice and allow the panel
to auto-detect which bits to use. But the bus format is set in the panel :(

Where is the bus format usually set for cases where a board only supports a
physical format?

> HTH,
> Jani.
> 
> 
> -- 
> Jani Nikula, Intel

John.

  reply	other threads:[~2024-06-28 16:41 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-28  3:54 How to specify panel bit order in driver? John Watts
2024-06-28  7:45 ` Jani Nikula
2024-06-28 16:39   ` John Watts [this message]
2024-07-02 11:30     ` Dmitry Baryshkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Zn7nNMti5pdX67DH@titan \
    --to=contact@jookia.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jani.nikula@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.