From: Peter Korsgaard <peter@korsgaard.com>
To: "Yann E. MORIN" <yann.morin.1998@free.fr>
Cc: "Gaël PORTAY" <gael.portay@rtone.fr>,
"Martin Bark" <martin@barkynet.com>,
"Julien Grossholtz" <julien.grossholtz@openest.io>,
buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] board/raspberrypi: fix autoprobing of bluetooth driver
Date: Thu, 30 Nov 2023 09:30:59 +0100 [thread overview]
Message-ID: <87leaf8wxo.fsf@48ers.dk> (raw)
In-Reply-To: <20231127184040.GB3177259@scaer> (Yann E. MORIN's message of "Mon, 27 Nov 2023 19:40:40 +0100")
>>>>> "Yann" == Yann E MORIN <yann.morin.1998@free.fr> writes:
> Gaël, All,
> On 2023-11-20 22:41 +0100, Gaël PORTAY spake thusly:
>> The commit 689b9ac439 (package/rpi-firmware: rework boot/config file
>> handling) has split in two the property:
>>
>> dtoverlay=miniuart-bt,krnbt=on
>>
>> Into:
>>
>> dtoverlay=miniuart-bt
>> dtoverlay=krnbt=on
>>
>> The initial property contained the dtbo file miniuart-bt[1] and its
>> parameter krnbt=on[2][3].
>>
>> The first syntax is correct while the second is not. The krnbt=on is not
>> a dtoverlay[4] but a dtparam[5]. Therefore the property dtparam must be
>> used instead.
>>
>> This fixes:
>>
>> # cat /sys/firmware/devicetree/base/chosen/user-warnings
>> Failed to load overlay 'krnbt=on'
>>
>> [1]: https://github.com/raspberrypi/linux/blob/rpi-5.10.y/arch/arm/boot/dts/overlays/miniuart-bt-overlay.dts
>> [2]: https://github.com/raspberrypi/linux/blob/rpi-5.10.y/arch/arm/boot/dts/overlays/miniuart-bt-overlay.dts#L91
>> [3]: https://github.com/raspberrypi/linux/blob/rpi-5.10.y/arch/arm/boot/dts/overlays/README#L213-L215
>> [4]: https://www.raspberrypi.com/documentation/computers/config_txt.html#dtoverlay
>> [5]: https://www.raspberrypi.com/documentation/computers/config_txt.html#dtparam
>>
>> Signed-off-by: Gaël PORTAY <gael.portay@rtone.fr>
> Applied to master, thanks.
Committed to 2023.02.x and 2023.08.x, thanks.
--
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
prev parent reply other threads:[~2023-11-30 8:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-20 21:41 [Buildroot] [PATCH 1/1] board/raspberrypi: fix autoprobing of bluetooth driver Gaël PORTAY
2023-11-20 22:11 ` Peter Seiderer
2023-11-27 18:45 ` Yann E. MORIN
2023-11-27 19:44 ` Gaël PORTAY
2023-11-27 18:40 ` Yann E. MORIN
2023-11-30 8:30 ` Peter Korsgaard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87leaf8wxo.fsf@48ers.dk \
--to=peter@korsgaard.com \
--cc=buildroot@buildroot.org \
--cc=gael.portay@rtone.fr \
--cc=julien.grossholtz@openest.io \
--cc=martin@barkynet.com \
--cc=yann.morin.1998@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.