* [PATCH] drm/amd: Clean up errors in processpptables.c
@ 2023-08-01 9:14 ` Ran Sun
0 siblings, 0 replies; 4+ messages in thread
From: Ran Sun @ 2023-08-01 9:14 UTC (permalink / raw)
To: alexander.deucher, airlied, daniel
Cc: Ran Sun, dri-devel, amd-gfx, linux-kernel
Fix the following errors reported by checkpatch:
ERROR: open brace '{' following function definitions go on the next line
ERROR: code indent should use tabs where possible
ERROR: space required before the open parenthesis '('
Signed-off-by: Ran Sun <sunran001@208suo.com>
---
drivers/gpu/drm/amd/pm/powerplay/hwmgr/processpptables.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/pm/powerplay/hwmgr/processpptables.c b/drivers/gpu/drm/amd/pm/powerplay/hwmgr/processpptables.c
index 1866fe20f9e2..f05f011c78be 100644
--- a/drivers/gpu/drm/amd/pm/powerplay/hwmgr/processpptables.c
+++ b/drivers/gpu/drm/amd/pm/powerplay/hwmgr/processpptables.c
@@ -676,7 +676,7 @@ static PP_StateClassificationFlags make_classification_flags(
static int init_non_clock_fields(struct pp_hwmgr *hwmgr,
struct pp_power_state *ps,
uint8_t version,
- const ATOM_PPLIB_NONCLOCK_INFO *pnon_clock_info)
+ const ATOM_PPLIB_NONCLOCK_INFO *pnon_clock_info)
{
unsigned long rrr_index;
unsigned long tmp;
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH] drm/amd: Clean up errors in processpptables.c
@ 2023-08-01 9:14 ` Ran Sun
0 siblings, 0 replies; 4+ messages in thread
From: Ran Sun @ 2023-08-01 9:14 UTC (permalink / raw)
To: alexander.deucher, airlied, daniel
Cc: amd-gfx, dri-devel, linux-kernel, Ran Sun
Fix the following errors reported by checkpatch:
ERROR: open brace '{' following function definitions go on the next line
ERROR: code indent should use tabs where possible
ERROR: space required before the open parenthesis '('
Signed-off-by: Ran Sun <sunran001@208suo.com>
---
drivers/gpu/drm/amd/pm/powerplay/hwmgr/processpptables.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/pm/powerplay/hwmgr/processpptables.c b/drivers/gpu/drm/amd/pm/powerplay/hwmgr/processpptables.c
index 1866fe20f9e2..f05f011c78be 100644
--- a/drivers/gpu/drm/amd/pm/powerplay/hwmgr/processpptables.c
+++ b/drivers/gpu/drm/amd/pm/powerplay/hwmgr/processpptables.c
@@ -676,7 +676,7 @@ static PP_StateClassificationFlags make_classification_flags(
static int init_non_clock_fields(struct pp_hwmgr *hwmgr,
struct pp_power_state *ps,
uint8_t version,
- const ATOM_PPLIB_NONCLOCK_INFO *pnon_clock_info)
+ const ATOM_PPLIB_NONCLOCK_INFO *pnon_clock_info)
{
unsigned long rrr_index;
unsigned long tmp;
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] drm/amd: Clean up errors in processpptables.c
2023-08-01 9:14 ` Ran Sun
@ 2023-08-01 9:36 ` Jani Nikula
-1 siblings, 0 replies; 4+ messages in thread
From: Jani Nikula @ 2023-08-01 9:36 UTC (permalink / raw)
To: Ran Sun, alexander.deucher, airlied, daniel
Cc: amd-gfx, dri-devel, Ran Sun, linux-kernel
On Tue, 01 Aug 2023, Ran Sun <sunran001@208suo.com> wrote:
> Fix the following errors reported by checkpatch:
>
> ERROR: open brace '{' following function definitions go on the next line
> ERROR: code indent should use tabs where possible
> ERROR: space required before the open parenthesis '('
The commit message does not match the patch.
>
> Signed-off-by: Ran Sun <sunran001@208suo.com>
> ---
> drivers/gpu/drm/amd/pm/powerplay/hwmgr/processpptables.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/pm/powerplay/hwmgr/processpptables.c b/drivers/gpu/drm/amd/pm/powerplay/hwmgr/processpptables.c
> index 1866fe20f9e2..f05f011c78be 100644
> --- a/drivers/gpu/drm/amd/pm/powerplay/hwmgr/processpptables.c
> +++ b/drivers/gpu/drm/amd/pm/powerplay/hwmgr/processpptables.c
> @@ -676,7 +676,7 @@ static PP_StateClassificationFlags make_classification_flags(
> static int init_non_clock_fields(struct pp_hwmgr *hwmgr,
> struct pp_power_state *ps,
> uint8_t version,
> - const ATOM_PPLIB_NONCLOCK_INFO *pnon_clock_info)
> + const ATOM_PPLIB_NONCLOCK_INFO *pnon_clock_info)
How about fixing *all* the style problems in the above in one go?
How about sending these fixes in a threaded series instead of filling
everyone's inboxes with individual patches? It's 30+ patches just today
already.
BR,
Jani.
> {
> unsigned long rrr_index;
> unsigned long tmp;
--
Jani Nikula, Intel Open Source Graphics Center
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] drm/amd: Clean up errors in processpptables.c
@ 2023-08-01 9:36 ` Jani Nikula
0 siblings, 0 replies; 4+ messages in thread
From: Jani Nikula @ 2023-08-01 9:36 UTC (permalink / raw)
To: Ran Sun, alexander.deucher, airlied, daniel
Cc: Ran Sun, dri-devel, amd-gfx, linux-kernel
On Tue, 01 Aug 2023, Ran Sun <sunran001@208suo.com> wrote:
> Fix the following errors reported by checkpatch:
>
> ERROR: open brace '{' following function definitions go on the next line
> ERROR: code indent should use tabs where possible
> ERROR: space required before the open parenthesis '('
The commit message does not match the patch.
>
> Signed-off-by: Ran Sun <sunran001@208suo.com>
> ---
> drivers/gpu/drm/amd/pm/powerplay/hwmgr/processpptables.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/pm/powerplay/hwmgr/processpptables.c b/drivers/gpu/drm/amd/pm/powerplay/hwmgr/processpptables.c
> index 1866fe20f9e2..f05f011c78be 100644
> --- a/drivers/gpu/drm/amd/pm/powerplay/hwmgr/processpptables.c
> +++ b/drivers/gpu/drm/amd/pm/powerplay/hwmgr/processpptables.c
> @@ -676,7 +676,7 @@ static PP_StateClassificationFlags make_classification_flags(
> static int init_non_clock_fields(struct pp_hwmgr *hwmgr,
> struct pp_power_state *ps,
> uint8_t version,
> - const ATOM_PPLIB_NONCLOCK_INFO *pnon_clock_info)
> + const ATOM_PPLIB_NONCLOCK_INFO *pnon_clock_info)
How about fixing *all* the style problems in the above in one go?
How about sending these fixes in a threaded series instead of filling
everyone's inboxes with individual patches? It's 30+ patches just today
already.
BR,
Jani.
> {
> unsigned long rrr_index;
> unsigned long tmp;
--
Jani Nikula, Intel Open Source Graphics Center
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-08-02 7:20 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-08-01 9:14 [PATCH] drm/amd: Clean up errors in processpptables.c Ran Sun
2023-08-01 9:14 ` Ran Sun
2023-08-01 9:36 ` Jani Nikula
2023-08-01 9:36 ` Jani Nikula
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.