From: Takashi Iwai <tiwai@suse.de>
To: Jaroslav Kysela <perex@perex.cz>
Cc: Oswald Buddenhagen <oswald.buddenhagen@gmx.de>,
alsa-devel@alsa-project.org
Subject: Re: [PATCH] ALSA: pcm: fix snd_pcm_playback_silence() with free-running mode
Date: Thu, 04 May 2023 19:38:21 +0200 [thread overview]
Message-ID: <87lei4j8tu.wl-tiwai@suse.de> (raw)
In-Reply-To: <574a7e28-1b1c-e2c5-ff2e-f206c8956db7@perex.cz>
On Thu, 04 May 2023 19:06:12 +0200,
Jaroslav Kysela wrote:
>
> On 04. 05. 23 18:34, Takashi Iwai wrote:
>
> > The acceptance of your patch was my failure, yeah. I should have
> > rejected it. So this failure doesn't happen again. You're seeing the
> > result now.
>
> We can keep the header comments and just revert the code for now.
Yes, this sounds like a good approach.
> If
> Oswald is not willing to work on this further, I'll look into this
> tomorrow. I see the points to be fixed. But I don't think that we are
> in hurry - the code was there for years so it's time to fix it
> properly.
That'll be highly appreciated!
Takashi
next prev parent reply other threads:[~2023-05-04 17:39 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-04 13:00 [PATCH] ALSA: pcm: fix snd_pcm_playback_silence() with free-running mode Oswald Buddenhagen
2023-05-04 13:08 ` Jaroslav Kysela
2023-05-04 13:25 ` Jeff Chua
2023-05-04 13:30 ` Oswald Buddenhagen
2023-05-04 13:28 ` Takashi Iwai
2023-05-04 13:33 ` Jaroslav Kysela
2023-05-04 13:54 ` Oswald Buddenhagen
2023-05-04 14:49 ` Takashi Iwai
2023-05-04 15:36 ` Oswald Buddenhagen
2023-05-04 16:34 ` Takashi Iwai
2023-05-04 17:06 ` Jaroslav Kysela
2023-05-04 17:38 ` Takashi Iwai [this message]
2023-05-04 17:53 ` Oswald Buddenhagen
2023-05-05 7:17 ` Oswald Buddenhagen
2023-05-05 7:29 ` Jaroslav Kysela
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lei4j8tu.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=oswald.buddenhagen@gmx.de \
--cc=perex@perex.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.