From: Oswald Buddenhagen <oswald.buddenhagen@gmx.de>
To: Jaroslav Kysela <perex@perex.cz>
Cc: alsa-devel@alsa-project.org, Takashi Iwai <tiwai@suse.de>
Subject: Re: [PATCH] ALSA: pcm: fix snd_pcm_playback_silence() with free-running mode
Date: Thu, 4 May 2023 15:30:57 +0200 [thread overview]
Message-ID: <ZFOzkYDs7w+0P36E@ugly> (raw)
In-Reply-To: <266661e5-ac86-1590-55d9-5f14e6486557@perex.cz>
On Thu, May 04, 2023 at 03:08:14PM +0200, Jaroslav Kysela wrote:
>On 04. 05. 23 15:00, Oswald Buddenhagen wrote:
>> So we logically revert some bits from commit 9f656705c5faa ("ALSA:
>> pcm:
>> rewrite snd_pcm_playback_silence()"), but we retain the bug fixes and
>> try to make the code paths congruent.
>
>It would be better to revert the broken patch and make changes on top of the
>original code. This is really difficult to review.
>
the diff to the old code is just as big, which is a somewhat inevitable
effect of it being the middle way between both.
the best way to review it is with `git show -b`.
regards
next prev parent reply other threads:[~2023-05-04 13:32 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-04 13:00 [PATCH] ALSA: pcm: fix snd_pcm_playback_silence() with free-running mode Oswald Buddenhagen
2023-05-04 13:08 ` Jaroslav Kysela
2023-05-04 13:25 ` Jeff Chua
2023-05-04 13:30 ` Oswald Buddenhagen [this message]
2023-05-04 13:28 ` Takashi Iwai
2023-05-04 13:33 ` Jaroslav Kysela
2023-05-04 13:54 ` Oswald Buddenhagen
2023-05-04 14:49 ` Takashi Iwai
2023-05-04 15:36 ` Oswald Buddenhagen
2023-05-04 16:34 ` Takashi Iwai
2023-05-04 17:06 ` Jaroslav Kysela
2023-05-04 17:38 ` Takashi Iwai
2023-05-04 17:53 ` Oswald Buddenhagen
2023-05-05 7:17 ` Oswald Buddenhagen
2023-05-05 7:29 ` Jaroslav Kysela
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZFOzkYDs7w+0P36E@ugly \
--to=oswald.buddenhagen@gmx.de \
--cc=alsa-devel@alsa-project.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.