All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <peter@korsgaard.com>
To: Yang Li <yang.lee@linux.alibaba.com>
Cc: vkoul@kernel.org, michal.simek@xilinx.com, lizhi.hou@amd.com,
	brian.xu@amd.com, raj.kumar.rampelli@amd.com,
	dmaengine@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org,
	Abaci Robot <abaci@linux.alibaba.com>
Subject: Re: [PATCH -next] dmaengine: xilinx: xdma: Fix some kernel-doc comments
Date: Tue, 14 Feb 2023 10:19:09 +0100	[thread overview]
Message-ID: <87lel0a9ki.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <20230214010344.5354-1-yang.lee@linux.alibaba.com> (Yang Li's message of "Tue, 14 Feb 2023 09:03:44 +0800")

>>>>> "Yang" == Yang Li <yang.lee@linux.alibaba.com> writes:

 > Make the description of @xdma_chan to @xchan to silence the warnings:
 > drivers/dma/xilinx/xdma.c:283: warning: Function parameter or member 'xchan' not described in 'xdma_xfer_start'
 > drivers/dma/xilinx/xdma.c:283: warning: Excess function parameter 'xdma_chan' description in 'xdma_xfer_start'

 > Reported-by: Abaci Robot <abaci@linux.alibaba.com>
 > Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=4051
 > Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>

Acked-by: Peter Korsgaard <peter@korsgaard.com>

> ---
 >  drivers/dma/xilinx/xdma.c | 2 +-
 >  1 file changed, 1 insertion(+), 1 deletion(-)

 > diff --git a/drivers/dma/xilinx/xdma.c b/drivers/dma/xilinx/xdma.c
 > index 462109c61653..93ee298d52b8 100644
 > --- a/drivers/dma/xilinx/xdma.c
 > +++ b/drivers/dma/xilinx/xdma.c
 > @@ -277,7 +277,7 @@ xdma_alloc_desc(struct xdma_chan *chan, u32 desc_num)
 
 >  /**
 >   * xdma_xfer_start - Start DMA transfer
 > - * @xdma_chan: DMA channel pointer
 > + * @xchan: DMA channel pointer
 >   */
 >  static int xdma_xfer_start(struct xdma_chan *xchan)
 >  {
 > -- 

 > 2.20.1.7.g153144c


-- 
Bye, Peter Korsgaard

WARNING: multiple messages have this Message-ID (diff)
From: Peter Korsgaard <peter@korsgaard.com>
To: Yang Li <yang.lee@linux.alibaba.com>
Cc: vkoul@kernel.org,  michal.simek@xilinx.com,  lizhi.hou@amd.com,
	brian.xu@amd.com,  raj.kumar.rampelli@amd.com,
	dmaengine@vger.kernel.org,  linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org,
	 Abaci Robot <abaci@linux.alibaba.com>
Subject: Re: [PATCH -next] dmaengine: xilinx: xdma: Fix some kernel-doc comments
Date: Tue, 14 Feb 2023 10:19:09 +0100	[thread overview]
Message-ID: <87lel0a9ki.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <20230214010344.5354-1-yang.lee@linux.alibaba.com> (Yang Li's message of "Tue, 14 Feb 2023 09:03:44 +0800")

>>>>> "Yang" == Yang Li <yang.lee@linux.alibaba.com> writes:

 > Make the description of @xdma_chan to @xchan to silence the warnings:
 > drivers/dma/xilinx/xdma.c:283: warning: Function parameter or member 'xchan' not described in 'xdma_xfer_start'
 > drivers/dma/xilinx/xdma.c:283: warning: Excess function parameter 'xdma_chan' description in 'xdma_xfer_start'

 > Reported-by: Abaci Robot <abaci@linux.alibaba.com>
 > Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=4051
 > Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>

Acked-by: Peter Korsgaard <peter@korsgaard.com>

> ---
 >  drivers/dma/xilinx/xdma.c | 2 +-
 >  1 file changed, 1 insertion(+), 1 deletion(-)

 > diff --git a/drivers/dma/xilinx/xdma.c b/drivers/dma/xilinx/xdma.c
 > index 462109c61653..93ee298d52b8 100644
 > --- a/drivers/dma/xilinx/xdma.c
 > +++ b/drivers/dma/xilinx/xdma.c
 > @@ -277,7 +277,7 @@ xdma_alloc_desc(struct xdma_chan *chan, u32 desc_num)
 
 >  /**
 >   * xdma_xfer_start - Start DMA transfer
 > - * @xdma_chan: DMA channel pointer
 > + * @xchan: DMA channel pointer
 >   */
 >  static int xdma_xfer_start(struct xdma_chan *xchan)
 >  {
 > -- 

 > 2.20.1.7.g153144c


-- 
Bye, Peter Korsgaard

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2023-02-14  9:19 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-14  1:03 [PATCH -next] dmaengine: xilinx: xdma: Fix some kernel-doc comments Yang Li
2023-02-14  1:03 ` Yang Li
2023-02-14  9:19 ` Peter Korsgaard [this message]
2023-02-14  9:19   ` Peter Korsgaard
2023-03-17 17:53 ` Vinod Koul
2023-03-17 17:53   ` Vinod Koul

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87lel0a9ki.fsf@dell.be.48ers.dk \
    --to=peter@korsgaard.com \
    --cc=abaci@linux.alibaba.com \
    --cc=brian.xu@amd.com \
    --cc=dmaengine@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lizhi.hou@amd.com \
    --cc=michal.simek@xilinx.com \
    --cc=raj.kumar.rampelli@amd.com \
    --cc=vkoul@kernel.org \
    --cc=yang.lee@linux.alibaba.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.