All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kalle Valo <kvalo@kernel.org>
To: Richard Weinberger <richard@nod.at>
Cc: linux-wireless <linux-wireless@vger.kernel.org>,
	 ath11k <ath11k@lists.infradead.org>
Subject: Re: Resume from hibernation fails due to ath11k_pci
Date: Mon, 13 Feb 2023 20:19:53 +0200	[thread overview]
Message-ID: <87lel1v35i.fsf@kernel.org> (raw)
In-Reply-To: <1617726247.124241.1676294102295.JavaMail.zimbra@nod.at> (Richard Weinberger's message of "Mon, 13 Feb 2023 14:15:02 +0100 (CET)")

Richard Weinberger <richard@nod.at> writes:

> ----- Ursprüngliche Mail -----
>> Von: "kvalo" <kvalo@kernel.org>
>> IIRC the issue is that ath11k expects the firmware to be running during
>> suspend. And this was because shutting down the firmware for suspend
>> caused problems in the MHI subsystem during resume. To fix this I
>> suspect we need changes both in ath11k and in the MHI subsystem, so not
>> easy.
>
> Hm. So, currently the device is put into WoW mode instead of powering
> it off because of issues in the MHI subsystem. At least this patch
> series indicates so:
> https://lore.kernel.org/all/1607708150-21066-1-git-send-email-kvalo@codeaurora.org/
>  
> On the other hand, my device seems to have trouble with that workaround.
> Maybe powering it off completely helps.
>
> Do you have a pointer to said MHI issues?

No pointers but IIRC it was something related to MHI creating a struct
device in an invalid context and MHI fails because of that. Maybe it was
so that when mac80211 calls ath11k_mac_op_start() during resume, ath11k
called MHI to enable power on the device and MHI tries to create a
struct device at the same time, or something like that. This was a long
time ago so not sure.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

-- 
ath11k mailing list
ath11k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath11k

WARNING: multiple messages have this Message-ID (diff)
From: Kalle Valo <kvalo@kernel.org>
To: Richard Weinberger <richard@nod.at>
Cc: linux-wireless <linux-wireless@vger.kernel.org>,
	ath11k <ath11k@lists.infradead.org>
Subject: Re: Resume from hibernation fails due to ath11k_pci
Date: Mon, 13 Feb 2023 20:19:53 +0200	[thread overview]
Message-ID: <87lel1v35i.fsf@kernel.org> (raw)
In-Reply-To: <1617726247.124241.1676294102295.JavaMail.zimbra@nod.at> (Richard Weinberger's message of "Mon, 13 Feb 2023 14:15:02 +0100 (CET)")

Richard Weinberger <richard@nod.at> writes:

> ----- Ursprüngliche Mail -----
>> Von: "kvalo" <kvalo@kernel.org>
>> IIRC the issue is that ath11k expects the firmware to be running during
>> suspend. And this was because shutting down the firmware for suspend
>> caused problems in the MHI subsystem during resume. To fix this I
>> suspect we need changes both in ath11k and in the MHI subsystem, so not
>> easy.
>
> Hm. So, currently the device is put into WoW mode instead of powering
> it off because of issues in the MHI subsystem. At least this patch
> series indicates so:
> https://lore.kernel.org/all/1607708150-21066-1-git-send-email-kvalo@codeaurora.org/
>  
> On the other hand, my device seems to have trouble with that workaround.
> Maybe powering it off completely helps.
>
> Do you have a pointer to said MHI issues?

No pointers but IIRC it was something related to MHI creating a struct
device in an invalid context and MHI fails because of that. Maybe it was
so that when mac80211 calls ath11k_mac_op_start() during resume, ath11k
called MHI to enable power on the device and MHI tries to create a
struct device at the same time, or something like that. This was a long
time ago so not sure.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

  reply	other threads:[~2023-02-13 18:20 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-22 22:12 Resume from hibernation fails due to ath11k_pci Richard Weinberger
2023-01-22 22:12 ` Richard Weinberger
2023-02-13 11:58 ` Kalle Valo
2023-02-13 11:58   ` Kalle Valo
2023-02-13 12:24   ` Richard Weinberger
2023-02-13 12:24     ` Richard Weinberger
2023-02-13 12:33     ` Kalle Valo
2023-02-13 12:33       ` Kalle Valo
2023-02-13 13:15       ` Richard Weinberger
2023-02-13 13:15         ` Richard Weinberger
2023-02-13 18:19         ` Kalle Valo [this message]
2023-02-13 18:19           ` Kalle Valo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87lel1v35i.fsf@kernel.org \
    --to=kvalo@kernel.org \
    --cc=ath11k@lists.infradead.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=richard@nod.at \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.