* [LTP] [PATCH] syscalls/setresuid04: Use SETRESUID instead of SAFE_SETRESUID to check 16bit syscall
@ 2022-12-15 4:47 Yang Xu
2022-12-15 11:08 ` Richard Palethorpe
0 siblings, 1 reply; 3+ messages in thread
From: Yang Xu @ 2022-12-15 4:47 UTC (permalink / raw)
To: ltp
Signed-off-by: Yang Xu <xuyang2018.jy@fujitsu.com>
---
testcases/kernel/syscalls/setresuid/setresuid04.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/testcases/kernel/syscalls/setresuid/setresuid04.c b/testcases/kernel/syscalls/setresuid/setresuid04.c
index 833aee91d..57b290f37 100644
--- a/testcases/kernel/syscalls/setresuid/setresuid04.c
+++ b/testcases/kernel/syscalls/setresuid/setresuid04.c
@@ -40,7 +40,7 @@ static void run(void)
pid_t pid;
int status;
- SAFE_SETRESUID(-1, ltpuser->pw_uid, -1);
+ TST_EXP_PASS_SILENT(SETRESUID(-1, ltpuser->pw_uid, -1));
TST_EXP_FAIL2(open(TEMP_FILE, O_RDWR), EACCES);
pid = SAFE_FORK();
@@ -52,7 +52,7 @@ static void run(void)
if (WIFEXITED(status) && WEXITSTATUS(status) != 0)
tst_res(TFAIL, "child process exited with status: %d", status);
- SAFE_SETRESUID(-1, 0, -1);
+ TST_EXP_PASS_SILENT(SETRESUID(-1, 0, -1));
TST_EXP_FD(open(TEMP_FILE, O_RDWR));
SAFE_CLOSE(TST_RET);
}
--
2.27.0
--
Mailing list info: https://lists.linux.it/listinfo/ltp
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [LTP] [PATCH] syscalls/setresuid04: Use SETRESUID instead of SAFE_SETRESUID to check 16bit syscall
2022-12-15 4:47 [LTP] [PATCH] syscalls/setresuid04: Use SETRESUID instead of SAFE_SETRESUID to check 16bit syscall Yang Xu
@ 2022-12-15 11:08 ` Richard Palethorpe
2022-12-16 2:06 ` xuyang2018.jy
0 siblings, 1 reply; 3+ messages in thread
From: Richard Palethorpe @ 2022-12-15 11:08 UTC (permalink / raw)
To: Yang Xu; +Cc: ltp
Hello,
Yang Xu <xuyang2018.jy@fujitsu.com> writes:
> Signed-off-by: Yang Xu <xuyang2018.jy@fujitsu.com>
Reviewed-by: Richard Palethorpe <rpalethorpe@suse.com>
> ---
> testcases/kernel/syscalls/setresuid/setresuid04.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/testcases/kernel/syscalls/setresuid/setresuid04.c b/testcases/kernel/syscalls/setresuid/setresuid04.c
> index 833aee91d..57b290f37 100644
> --- a/testcases/kernel/syscalls/setresuid/setresuid04.c
> +++ b/testcases/kernel/syscalls/setresuid/setresuid04.c
> @@ -40,7 +40,7 @@ static void run(void)
> pid_t pid;
> int status;
>
> - SAFE_SETRESUID(-1, ltpuser->pw_uid, -1);
> + TST_EXP_PASS_SILENT(SETRESUID(-1, ltpuser->pw_uid, -1));
> TST_EXP_FAIL2(open(TEMP_FILE, O_RDWR), EACCES);
>
> pid = SAFE_FORK();
> @@ -52,7 +52,7 @@ static void run(void)
> if (WIFEXITED(status) && WEXITSTATUS(status) != 0)
> tst_res(TFAIL, "child process exited with status: %d", status);
>
> - SAFE_SETRESUID(-1, 0, -1);
> + TST_EXP_PASS_SILENT(SETRESUID(-1, 0, -1));
> TST_EXP_FD(open(TEMP_FILE, O_RDWR));
> SAFE_CLOSE(TST_RET);
> }
> --
> 2.27.0
--
Thank you,
Richard.
--
Mailing list info: https://lists.linux.it/listinfo/ltp
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [LTP] [PATCH] syscalls/setresuid04: Use SETRESUID instead of SAFE_SETRESUID to check 16bit syscall
2022-12-15 11:08 ` Richard Palethorpe
@ 2022-12-16 2:06 ` xuyang2018.jy
0 siblings, 0 replies; 3+ messages in thread
From: xuyang2018.jy @ 2022-12-16 2:06 UTC (permalink / raw)
To: rpalethorpe@suse.de; +Cc: ltp@lists.linux.it
Hi Richard
> Hello,
>
> Yang Xu <xuyang2018.jy@fujitsu.com> writes:
>
>> Signed-off-by: Yang Xu <xuyang2018.jy@fujitsu.com>
>
> Reviewed-by: Richard Palethorpe <rpalethorpe@suse.com>
Thanks, merged.
Best Regards
Yang Xu
>
>> ---
>> testcases/kernel/syscalls/setresuid/setresuid04.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/testcases/kernel/syscalls/setresuid/setresuid04.c b/testcases/kernel/syscalls/setresuid/setresuid04.c
>> index 833aee91d..57b290f37 100644
>> --- a/testcases/kernel/syscalls/setresuid/setresuid04.c
>> +++ b/testcases/kernel/syscalls/setresuid/setresuid04.c
>> @@ -40,7 +40,7 @@ static void run(void)
>> pid_t pid;
>> int status;
>>
>> - SAFE_SETRESUID(-1, ltpuser->pw_uid, -1);
>> + TST_EXP_PASS_SILENT(SETRESUID(-1, ltpuser->pw_uid, -1));
>> TST_EXP_FAIL2(open(TEMP_FILE, O_RDWR), EACCES);
>>
>> pid = SAFE_FORK();
>> @@ -52,7 +52,7 @@ static void run(void)
>> if (WIFEXITED(status) && WEXITSTATUS(status) != 0)
>> tst_res(TFAIL, "child process exited with status: %d", status);
>>
>> - SAFE_SETRESUID(-1, 0, -1);
>> + TST_EXP_PASS_SILENT(SETRESUID(-1, 0, -1));
>> TST_EXP_FD(open(TEMP_FILE, O_RDWR));
>> SAFE_CLOSE(TST_RET);
>> }
>> --
>> 2.27.0
>
>
--
Mailing list info: https://lists.linux.it/listinfo/ltp
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-12-16 2:06 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-12-15 4:47 [LTP] [PATCH] syscalls/setresuid04: Use SETRESUID instead of SAFE_SETRESUID to check 16bit syscall Yang Xu
2022-12-15 11:08 ` Richard Palethorpe
2022-12-16 2:06 ` xuyang2018.jy
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.