All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marc Zyngier <maz@kernel.org>
To: Claudiu Beznea <claudiu.beznea@microchip.com>
Cc: linux-arm-kernel@lists.infradead.org, tglx@linutronix.de,
	alexandre.belloni@bootlin.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] irqchip/atmel-aic: remove #ifdef CONFIG_PM
Date: Mon, 11 Jul 2022 09:49:31 +0100	[thread overview]
Message-ID: <87let0kp9g.wl-maz@kernel.org> (raw)
In-Reply-To: <20220706074630.829607-1-claudiu.beznea@microchip.com>

Claudiu,

If you send more than a single patch, please add a cover letter.

On Wed, 06 Jul 2022 08:46:29 +0100,
Claudiu Beznea <claudiu.beznea@microchip.com> wrote:
> 
> Remove #ifdef CONFIG_PM around aic_suspend() function. Coding style
> recommends (at chapter Conditional Compilation) to avoid using
> preprocessor conditional in .c files.
> gc->chip_types->chip.irq_suspend()/gc->chip_types->chip.irq_resume() is
> called in irq_gc_suspend()/irq_gc_resume() which is NULL in case CONFIG_PM
> is not defined. With this gc->chip_types->chip.irq_pm_shutdown is
> populated all the time as it should be as irq_gc_shutdown() is not
> conditioned by CONFIG_PM.

By your very own investigations, aic_suspend() and co are utterly
useless when !PM. And yet you want to *preserve* them, despite being
dead code? What purpose does it serve (other than some blind
compliance to a rule)?

	M.

-- 
Without deviation from the norm, progress is not possible.

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Marc Zyngier <maz@kernel.org>
To: Claudiu Beznea <claudiu.beznea@microchip.com>
Cc: <tglx@linutronix.de>, <nicolas.ferre@microchip.com>,
	<alexandre.belloni@bootlin.com>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] irqchip/atmel-aic: remove #ifdef CONFIG_PM
Date: Mon, 11 Jul 2022 09:49:31 +0100	[thread overview]
Message-ID: <87let0kp9g.wl-maz@kernel.org> (raw)
In-Reply-To: <20220706074630.829607-1-claudiu.beznea@microchip.com>

Claudiu,

If you send more than a single patch, please add a cover letter.

On Wed, 06 Jul 2022 08:46:29 +0100,
Claudiu Beznea <claudiu.beznea@microchip.com> wrote:
> 
> Remove #ifdef CONFIG_PM around aic_suspend() function. Coding style
> recommends (at chapter Conditional Compilation) to avoid using
> preprocessor conditional in .c files.
> gc->chip_types->chip.irq_suspend()/gc->chip_types->chip.irq_resume() is
> called in irq_gc_suspend()/irq_gc_resume() which is NULL in case CONFIG_PM
> is not defined. With this gc->chip_types->chip.irq_pm_shutdown is
> populated all the time as it should be as irq_gc_shutdown() is not
> conditioned by CONFIG_PM.

By your very own investigations, aic_suspend() and co are utterly
useless when !PM. And yet you want to *preserve* them, despite being
dead code? What purpose does it serve (other than some blind
compliance to a rule)?

	M.

-- 
Without deviation from the norm, progress is not possible.

  parent reply	other threads:[~2022-07-11  8:50 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-06  7:46 [PATCH 1/2] irqchip/atmel-aic: remove #ifdef CONFIG_PM Claudiu Beznea
2022-07-06  7:46 ` Claudiu Beznea
2022-07-06  7:46 ` [PATCH 2/2] irqchip/atmel-aic5: " Claudiu Beznea
2022-07-06  7:46   ` Claudiu Beznea
2022-07-11  8:49 ` Marc Zyngier [this message]
2022-07-11  8:49   ` [PATCH 1/2] irqchip/atmel-aic: " Marc Zyngier
2022-07-11 10:56   ` Claudiu.Beznea
2022-07-11 10:56     ` Claudiu.Beznea

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87let0kp9g.wl-maz@kernel.org \
    --to=maz@kernel.org \
    --cc=alexandre.belloni@bootlin.com \
    --cc=claudiu.beznea@microchip.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.