From: "Alex Bennée" <alex.bennee@linaro.org>
To: Taylor Simpson <tsimpson@quicinc.com>
Cc: "richard.henderson@linaro.org" <richard.henderson@linaro.org>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
"qemu-arm@nongnu.org" <qemu-arm@nongnu.org>,
"fam@euphon.net" <fam@euphon.net>,
"berrange@redhat.com" <berrange@redhat.com>,
"f4bug@amsat.org" <f4bug@amsat.org>,
"aurelien@aurel32.net" <aurelien@aurel32.net>,
"pbonzini@redhat.com" <pbonzini@redhat.com>,
"stefanha@redhat.com" <stefanha@redhat.com>,
"crosa@redhat.com" <crosa@redhat.com>
Subject: Re: [RFC PATCH 0/4] improve coverage of vector backend
Date: Thu, 03 Feb 2022 18:26:08 +0000 [thread overview]
Message-ID: <87leyrst2m.fsf@linaro.org> (raw)
In-Reply-To: <SN4PR0201MB8808A6436C987408C04CED6BDE289@SN4PR0201MB8808.namprd02.prod.outlook.com>
Taylor Simpson <tsimpson@quicinc.com> writes:
>> -----Original Message-----
>> From: Alex Bennée <alex.bennee@linaro.org>
>> Sent: Thursday, February 3, 2022 11:50 AM
>> To: Taylor Simpson <tsimpson@quicinc.com>
>> Cc: richard.henderson@linaro.org; qemu-devel@nongnu.org; qemu-
>> arm@nongnu.org; fam@euphon.net; berrange@redhat.com;
>> f4bug@amsat.org; aurelien@aurel32.net; pbonzini@redhat.com;
>> stefanha@redhat.com; crosa@redhat.com
>> Subject: Re: [RFC PATCH 0/4] improve coverage of vector backend
>>
>> Taylor Simpson <tsimpson@quicinc.com> writes:
>>
>> > Quick update - I ran the test on the hardware and have the same error
>> messages.
>> >
>> > So, it doesn't look like a QEMU problem. I'll investigate if the
>> > problem is due to something in the toolchain.
>>
>> That reminds me what is the status of the binary toolchain. The last attempt
>> had some issues so we are still using the hand-built one upstream.
>
> No progress on that. The team hasn't had the bandwidth to work on it.
>
> However, I'm less suspicious of the toolchain now. I built with a
> couple of different compiler options and a couple of different
> versions of the toolchain, including the C library that runs in
> production. In all cases, I see the same result.
>
> Any chance the problem is in the test itself (e.g., some sort of
> undefined behavior or a 64-bit vs 32-bit difference)?
It does have a 64 bit byteswap in - it's possible I broke it copying
from the upstream:
https://ccodearchive.net/info/crypto/sha512.html
but it does pass on *all* the other architectures which is a mix of 32
and 64 bit code. I did have to hack the endian detection code though.
Does:
#if BYTE_ORDER == BIG_ENDIAN
work for your compiler?
>
> Thanks,
> Taylor
--
Alex Bennée
WARNING: multiple messages have this Message-ID (diff)
From: "Alex Bennée" <alex.bennee@linaro.org>
To: Taylor Simpson <tsimpson@quicinc.com>
Cc: "fam@euphon.net" <fam@euphon.net>,
"berrange@redhat.com" <berrange@redhat.com>,
"richard.henderson@linaro.org" <richard.henderson@linaro.org>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
"f4bug@amsat.org" <f4bug@amsat.org>,
"qemu-arm@nongnu.org" <qemu-arm@nongnu.org>,
"stefanha@redhat.com" <stefanha@redhat.com>,
"crosa@redhat.com" <crosa@redhat.com>,
"pbonzini@redhat.com" <pbonzini@redhat.com>,
"aurelien@aurel32.net" <aurelien@aurel32.net>
Subject: Re: [RFC PATCH 0/4] improve coverage of vector backend
Date: Thu, 03 Feb 2022 18:26:08 +0000 [thread overview]
Message-ID: <87leyrst2m.fsf@linaro.org> (raw)
In-Reply-To: <SN4PR0201MB8808A6436C987408C04CED6BDE289@SN4PR0201MB8808.namprd02.prod.outlook.com>
Taylor Simpson <tsimpson@quicinc.com> writes:
>> -----Original Message-----
>> From: Alex Bennée <alex.bennee@linaro.org>
>> Sent: Thursday, February 3, 2022 11:50 AM
>> To: Taylor Simpson <tsimpson@quicinc.com>
>> Cc: richard.henderson@linaro.org; qemu-devel@nongnu.org; qemu-
>> arm@nongnu.org; fam@euphon.net; berrange@redhat.com;
>> f4bug@amsat.org; aurelien@aurel32.net; pbonzini@redhat.com;
>> stefanha@redhat.com; crosa@redhat.com
>> Subject: Re: [RFC PATCH 0/4] improve coverage of vector backend
>>
>> Taylor Simpson <tsimpson@quicinc.com> writes:
>>
>> > Quick update - I ran the test on the hardware and have the same error
>> messages.
>> >
>> > So, it doesn't look like a QEMU problem. I'll investigate if the
>> > problem is due to something in the toolchain.
>>
>> That reminds me what is the status of the binary toolchain. The last attempt
>> had some issues so we are still using the hand-built one upstream.
>
> No progress on that. The team hasn't had the bandwidth to work on it.
>
> However, I'm less suspicious of the toolchain now. I built with a
> couple of different compiler options and a couple of different
> versions of the toolchain, including the C library that runs in
> production. In all cases, I see the same result.
>
> Any chance the problem is in the test itself (e.g., some sort of
> undefined behavior or a 64-bit vs 32-bit difference)?
It does have a 64 bit byteswap in - it's possible I broke it copying
from the upstream:
https://ccodearchive.net/info/crypto/sha512.html
but it does pass on *all* the other architectures which is a mix of 32
and 64 bit code. I did have to hack the endian detection code though.
Does:
#if BYTE_ORDER == BIG_ENDIAN
work for your compiler?
>
> Thanks,
> Taylor
--
Alex Bennée
next prev parent reply other threads:[~2022-02-03 18:28 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-02 19:12 [RFC PATCH 0/4] improve coverage of vector backend Alex Bennée
2022-02-02 19:12 ` Alex Bennée
2022-02-02 19:12 ` [RFC PATCH 1/4] tests/tcg: cleanup sha1 source code Alex Bennée
2022-02-02 19:12 ` Alex Bennée
2022-02-02 21:05 ` Richard Henderson
2022-02-02 21:05 ` Richard Henderson
2022-02-02 19:12 ` [RFC PATCH 2/4] tests/tcg: build sha1-vector for SVE and compare Alex Bennée
2022-02-02 19:12 ` Alex Bennée
2022-02-02 21:09 ` Richard Henderson
2022-02-02 21:09 ` Richard Henderson
2022-02-02 19:12 ` [RFC PATCH 3/4] tests/tcg: add sha512 test Alex Bennée
2022-02-02 19:12 ` Alex Bennée
2022-02-02 21:19 ` Richard Henderson
2022-02-02 21:19 ` Richard Henderson
2022-02-02 19:12 ` [RFC PATCH 4/4] tests/tcg: add vectorised sha512 versions Alex Bennée
2022-02-02 19:12 ` Alex Bennée
2022-02-02 21:18 ` Richard Henderson
2022-02-02 21:18 ` Richard Henderson
2022-02-02 23:16 ` [RFC PATCH 0/4] improve coverage of vector backend Alex Bennée
2022-02-02 23:16 ` Alex Bennée
2022-02-03 1:45 ` Taylor Simpson
2022-02-03 1:45 ` Taylor Simpson
2022-02-03 16:33 ` Taylor Simpson
2022-02-03 16:33 ` Taylor Simpson
2022-02-03 17:50 ` Alex Bennée
2022-02-03 17:50 ` Alex Bennée
2022-02-03 17:57 ` Taylor Simpson
2022-02-03 17:57 ` Taylor Simpson
2022-02-03 18:26 ` Alex Bennée [this message]
2022-02-03 18:26 ` Alex Bennée
2022-02-03 19:01 ` Taylor Simpson
2022-02-03 19:01 ` Taylor Simpson
2022-02-03 20:00 ` Alex Bennée
2022-02-03 20:00 ` Alex Bennée
2022-02-03 21:05 ` Taylor Simpson
2022-02-03 21:05 ` Taylor Simpson
2022-02-03 21:31 ` Richard Henderson
2022-02-03 21:31 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87leyrst2m.fsf@linaro.org \
--to=alex.bennee@linaro.org \
--cc=aurelien@aurel32.net \
--cc=berrange@redhat.com \
--cc=crosa@redhat.com \
--cc=f4bug@amsat.org \
--cc=fam@euphon.net \
--cc=pbonzini@redhat.com \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=stefanha@redhat.com \
--cc=tsimpson@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.