From: Markus Armbruster <armbru@redhat.com>
To: "Philippe Mathieu-Daudé" <philmd@redhat.com>
Cc: thuth@redhat.com,
"Daniel Henrique Barboza" <danielhb413@gmail.com>,
qemu-devel@nongnu.org, clg@kaod.org, qemu-ppc@nongnu.org,
"Claudio Fontana" <cfontana@suse.de>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>,
david@gibson.dropbear.id.au
Subject: Re: [PATCH for-7.0 v2 1/2] ivshmem.c: change endianness to LITTLE_ENDIAN
Date: Wed, 24 Nov 2021 13:55:09 +0100 [thread overview]
Message-ID: <87lf1dyaqa.fsf@dusky.pond.sub.org> (raw)
In-Reply-To: <7d312ca5-82d1-ba63-535d-8024f2033215@redhat.com> ("Philippe Mathieu-Daudé"'s message of "Wed, 24 Nov 2021 12:28:49 +0100")
Philippe Mathieu-Daudé <philmd@redhat.com> writes:
> On 11/24/21 10:29, Daniel Henrique Barboza wrote:
>> The ivshmem device, as with most PCI devices, uses little endian byte
>> order. However, the endianness of its mmio_ops is marked as
>> DEVICE_NATIVE_ENDIAN. This presents not only the usual problems with big
>> endian hosts but also with PowerPC little endian hosts as well, since
>> the Power architecture in QEMU uses big endian hardware (XIVE controller,
>> PCI Host Bridges, etc) even if the host is in little endian byte order.
>
> Maybe mention commit f7a199b2b44 ("ivshmem: use little-endian
> int64_t for the protocol")?
"The protocol" is the interface between ivshmem-doorbell device (client)
and ivshmem server. This commit is about the interface between
ivshmem-* device and the guest. The two interfaces are about as related
as SSH and DNS: software exists that uses both.
Mentioning f7a199b2b44 feels superfluous to me.
[...]
next prev parent reply other threads:[~2021-11-24 12:56 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-24 9:29 [PATCH for-7.0 v2 0/2] change ivshmem endianness to LITTLE_ENDIAN Daniel Henrique Barboza
2021-11-24 9:29 ` [PATCH for-7.0 v2 1/2] ivshmem.c: change " Daniel Henrique Barboza
2021-11-24 11:28 ` Philippe Mathieu-Daudé
2021-11-24 11:33 ` Daniel Henrique Barboza
2021-11-24 12:55 ` Markus Armbruster [this message]
2021-11-24 13:09 ` Daniel Henrique Barboza
2021-11-24 9:29 ` [PATCH for-7.0 v2 2/2] ivshmem-test.c: enable test_ivshmem_server for ppc64 arch Daniel Henrique Barboza
2021-11-24 11:29 ` Philippe Mathieu-Daudé
2021-12-15 16:35 ` [PATCH for-7.0 v2 0/2] change ivshmem endianness to LITTLE_ENDIAN Cédric Le Goater
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lf1dyaqa.fsf@dusky.pond.sub.org \
--to=armbru@redhat.com \
--cc=cfontana@suse.de \
--cc=clg@kaod.org \
--cc=danielhb413@gmail.com \
--cc=david@gibson.dropbear.id.au \
--cc=marcandre.lureau@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.