From: Kalle Valo <kvalo@codeaurora.org>
To: John Crispin <john@phrozen.org>
Cc: Miles Hu <milehu@codeaurora.org>,
linux-wireless@vger.kernel.org, ath11k@lists.infradead.org
Subject: Re: [PATCH V6 2/2] ath11k: add more HE fields into radiotap header
Date: Wed, 19 Aug 2020 19:14:58 +0300 [thread overview]
Message-ID: <87lfiaipdp.fsf@codeaurora.org> (raw)
In-Reply-To: <20200803145444.473810-2-john@phrozen.org> (John Crispin's message of "Mon, 3 Aug 2020 16:54:44 +0200")
John Crispin <john@phrozen.org> writes:
> From: Miles Hu <milehu@codeaurora.org>
>
> This patch adds code to parse HE fields inside ppdu TLVs. Then it adds the
> populates the additional info into the ratiotap header. Also fix missing
> QoS tag in native wifi mode. Finally rssi and tsf are also added.
>
> Signed-off-by: Miles Hu <milehu@codeaurora.org>
> Signed-off-by: John Crispin <john@phrozen.org>
[...]
> @@ -4522,11 +4522,14 @@ ath11k_dp_rx_mon_merg_msdus(struct ath11k *ar,
> struct ieee80211_rx_status *rxs)
> {
> struct sk_buff *msdu, *mpdu_buf, *prev_buf;
> - u32 decap_format, wifi_hdr_len;
> + u32 decap_format;
> struct hal_rx_desc *rx_desc;
> char *hdr_desc;
> u8 *dest;
> struct ieee80211_hdr_3addr *wh;
> + static u32 pkt_type;
> +
> + pkt_type++;
We cannot use static non-const variables in ath11k, that would be racy.
As this seems to be an unused variable I have just removed it in the
pending branch.
--
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
--
ath11k mailing list
ath11k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath11k
WARNING: multiple messages have this Message-ID (diff)
From: Kalle Valo <kvalo@codeaurora.org>
To: John Crispin <john@phrozen.org>
Cc: Miles Hu <milehu@codeaurora.org>,
linux-wireless@vger.kernel.org, ath11k@lists.infradead.org
Subject: Re: [PATCH V6 2/2] ath11k: add more HE fields into radiotap header
Date: Wed, 19 Aug 2020 19:14:58 +0300 [thread overview]
Message-ID: <87lfiaipdp.fsf@codeaurora.org> (raw)
In-Reply-To: <20200803145444.473810-2-john@phrozen.org> (John Crispin's message of "Mon, 3 Aug 2020 16:54:44 +0200")
John Crispin <john@phrozen.org> writes:
> From: Miles Hu <milehu@codeaurora.org>
>
> This patch adds code to parse HE fields inside ppdu TLVs. Then it adds the
> populates the additional info into the ratiotap header. Also fix missing
> QoS tag in native wifi mode. Finally rssi and tsf are also added.
>
> Signed-off-by: Miles Hu <milehu@codeaurora.org>
> Signed-off-by: John Crispin <john@phrozen.org>
[...]
> @@ -4522,11 +4522,14 @@ ath11k_dp_rx_mon_merg_msdus(struct ath11k *ar,
> struct ieee80211_rx_status *rxs)
> {
> struct sk_buff *msdu, *mpdu_buf, *prev_buf;
> - u32 decap_format, wifi_hdr_len;
> + u32 decap_format;
> struct hal_rx_desc *rx_desc;
> char *hdr_desc;
> u8 *dest;
> struct ieee80211_hdr_3addr *wh;
> + static u32 pkt_type;
> +
> + pkt_type++;
We cannot use static non-const variables in ath11k, that would be racy.
As this seems to be an unused variable I have just removed it in the
pending branch.
--
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2020-08-19 16:15 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-03 14:54 [PATCH V6 1/2] ath11k: switch to using ieee80211_tx_status_ext() John Crispin
2020-08-03 14:54 ` John Crispin
2020-08-03 14:54 ` [PATCH V6 2/2] ath11k: add more HE fields into radiotap header John Crispin
2020-08-03 14:54 ` John Crispin
2020-08-19 16:14 ` Kalle Valo [this message]
2020-08-19 16:14 ` Kalle Valo
2020-08-19 17:33 ` Kalle Valo
2020-08-19 17:33 ` Kalle Valo
2020-08-19 17:34 ` [PATCH V6 1/2] ath11k: switch to using ieee80211_tx_status_ext() Kalle Valo
2020-08-19 17:34 ` Kalle Valo
2020-08-20 5:16 ` John Crispin
2020-08-20 5:16 ` John Crispin
2020-08-26 14:58 ` Kalle Valo
2020-08-26 14:58 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lfiaipdp.fsf@codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=ath11k@lists.infradead.org \
--cc=john@phrozen.org \
--cc=linux-wireless@vger.kernel.org \
--cc=milehu@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.