All of lore.kernel.org
 help / color / mirror / Atom feed
From: Robert Jarzmik <robert.jarzmik@free.fr>
To: Miquel Raynal <miquel.raynal@bootlin.com>
Cc: Vignesh Raghavendra <vigneshr@ti.com>,
	Arnd Bergmann <arnd@arndb.de>,
	Tudor Ambarus <tudor.ambarus@microchip.com>,
	Richard Weinberger <richard@nod.at>,
	Haojian Zhuang <haojian.zhuang@gmail.com>,
	Boris Brezillon <boris.brezillon@collabora.com>,
	linux-mtd@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org,
	Mike Rapoport <mike@compulab.co.il>,
	Daniel Mack <daniel@zonque.org>
Subject: Re: [PATCH 0/3] mtd: rawnand: Get rid of the cmx270 driver
Date: Wed, 13 May 2020 14:55:01 +0200	[thread overview]
Message-ID: <87lflwngey.fsf@belgarion.home> (raw)
In-Reply-To: <20200508121041.64f91276@xps13> (Miquel Raynal's message of "Fri,  8 May 2020 12:10:41 +0200")

Miquel Raynal <miquel.raynal@bootlin.com> writes:

> Hi Robert,

Mi Miquel,

>> I hope someone still has a board to test that.
No, unfortunately I don't have this board, nor do I know of anyone having
one. It's the second time I see patches on cmx270, and the question to whether
we shoud keep this board in kernel is still in my mind ... given that cm-x300 is
fully supported and testable, and no one I know has a cm-x2700 ...

Now for your series, I have 2 comments :
 - dsb() : can you explain the rationale of each of the 3 instances I saw
 please.
 - the +2 IOMEM offset
   I don't like it at all. I don't mind the offset, I disklike the use of
   readb() or readw() where before there was a readl().. Same thing for writeb()
   against writel().

   The bus semantics are not the same, the alignment is not the same as well
   (and PXA is very old and doesn't cope well with alignment), and without a
   proper board to test, I would be very wary to have that change.

Cheers.

-- 
Robert

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

WARNING: multiple messages have this Message-ID (diff)
From: Robert Jarzmik <robert.jarzmik@free.fr>
To: Miquel Raynal <miquel.raynal@bootlin.com>
Cc: Vignesh Raghavendra <vigneshr@ti.com>,
	Arnd Bergmann <arnd@arndb.de>,
	Tudor Ambarus <tudor.ambarus@microchip.com>,
	Richard Weinberger <richard@nod.at>,
	Haojian Zhuang <haojian.zhuang@gmail.com>,
	Boris Brezillon <boris.brezillon@collabora.com>,
	linux-mtd@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org,
	Mike Rapoport <mike@compulab.co.il>,
	Daniel Mack <daniel@zonque.org>
Subject: Re: [PATCH 0/3] mtd: rawnand: Get rid of the cmx270 driver
Date: Wed, 13 May 2020 14:55:01 +0200	[thread overview]
Message-ID: <87lflwngey.fsf@belgarion.home> (raw)
In-Reply-To: <20200508121041.64f91276@xps13> (Miquel Raynal's message of "Fri,  8 May 2020 12:10:41 +0200")

Miquel Raynal <miquel.raynal@bootlin.com> writes:

> Hi Robert,

Mi Miquel,

>> I hope someone still has a board to test that.
No, unfortunately I don't have this board, nor do I know of anyone having
one. It's the second time I see patches on cmx270, and the question to whether
we shoud keep this board in kernel is still in my mind ... given that cm-x300 is
fully supported and testable, and no one I know has a cm-x2700 ...

Now for your series, I have 2 comments :
 - dsb() : can you explain the rationale of each of the 3 instances I saw
 please.
 - the +2 IOMEM offset
   I don't like it at all. I don't mind the offset, I disklike the use of
   readb() or readw() where before there was a readl().. Same thing for writeb()
   against writel().

   The bus semantics are not the same, the alignment is not the same as well
   (and PXA is very old and doesn't cope well with alignment), and without a
   proper board to test, I would be very wary to have that change.

Cheers.

-- 
Robert

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2020-05-13 12:55 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-29 22:31 [PATCH 0/3] mtd: rawnand: Get rid of the cmx270 driver Boris Brezillon
2020-04-29 22:31 ` Boris Brezillon
2020-04-29 22:31 ` [PATCH 1/3] ARM: pxa: cm-x270: Use gen_nand to expose the NAND device Boris Brezillon
2020-04-29 22:31   ` Boris Brezillon
2020-04-29 22:31 ` [PATCH 2/3] ARM: pxa: Stop selecting CONFIG_MTD_NAND_CM_X270 Boris Brezillon
2020-04-29 22:31   ` Boris Brezillon
2020-04-29 22:31 ` [PATCH 3/3] mtd: rawnand: Remove the cmx270 NAND controller driver Boris Brezillon
2020-04-29 22:31   ` Boris Brezillon
2020-05-08 10:10 ` [PATCH 0/3] mtd: rawnand: Get rid of the cmx270 driver Miquel Raynal
2020-05-08 10:10   ` Miquel Raynal
2020-05-13 12:55   ` Robert Jarzmik [this message]
2020-05-13 12:55     ` Robert Jarzmik
2020-05-13 13:17     ` Boris Brezillon
2020-05-13 13:17       ` Boris Brezillon
2020-05-13 13:23       ` Miquel Raynal
2020-05-13 13:23         ` Miquel Raynal
2020-05-13 13:58         ` Arnd Bergmann
2020-05-13 13:58           ` Arnd Bergmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87lflwngey.fsf@belgarion.home \
    --to=robert.jarzmik@free.fr \
    --cc=arnd@arndb.de \
    --cc=boris.brezillon@collabora.com \
    --cc=daniel@zonque.org \
    --cc=haojian.zhuang@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=mike@compulab.co.il \
    --cc=miquel.raynal@bootlin.com \
    --cc=richard@nod.at \
    --cc=tudor.ambarus@microchip.com \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.