All of lore.kernel.org
 help / color / mirror / Atom feed
From: Julian Sax <jsbc@gmx.de>
To: Joe Perches <joe@perches.com>
Cc: "David (ChunMing) Zhou" <David1.Zhou@amd.com>,
	"David Airlie" <airlied@linux.ie>,
	"Felix Kuehling" <Felix.Kuehling@amd.com>,
	linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org,
	dri-devel@lists.freedesktop.org,
	"Daniel Vetter" <daniel@ffwll.ch>,
	"Alex Deucher" <alexander.deucher@amd.com>,
	"Christian König" <christian.koenig@amd.com>
Subject: Re: [PATCH] drm/amdkfd: Make process queues logs less verbose
Date: Sun, 02 Feb 2020 01:14:46 +0100	[thread overview]
Message-ID: <87lfpl4zgp.fsf@chef> (raw)
In-Reply-To: <b9b671508d478469c1ad43206dd29d770bfb7818.camel@perches.com> (Joe Perches's message of "Sat, 01 Feb 2020 15:37:43 -0800")

Joe Perches <joe@perches.com> writes:

> On Sun, 2020-02-02 at 00:11 +0100, Julian Sax wrote:
>> During normal usage, especially if jobs are started and stopped in rapid
>> succession, the kernel log is filled with messages like this:
>>
>> [38732.522910] Restoring PASID 0x8003 queues
>> [38732.666767] Evicting PASID 0x8003 queues
>> [38732.714074] Restoring PASID 0x8003 queues
>> [38732.815633] Evicting PASID 0x8003 queues
>> [38732.834961] Restoring PASID 0x8003 queues
>> [38732.840536] Evicting PASID 0x8003 queues
>> [38732.869846] Restoring PASID 0x8003 queues
>> [38732.893655] Evicting PASID 0x8003 queues
>> [38732.927975] Restoring PASID 0x8003 queues
>>
>> According to [1], these messages are expected, but they carry little
>> value for the end user, so turn them into debug messages.
>>
>> [1] https://github.com/RadeonOpenCompute/ROCm/issues/343
>
> trivia:
>
>> diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c b/drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c
> []
>> @@ -604,7 +604,7 @@ static int evict_process_queues_nocpsch(struct device_queue_manager *dqm,
>>  		goto out;
>>
>>  	pdd = qpd_to_pdd(qpd);
>> -	pr_info_ratelimited("Evicting PASID 0x%x queues\n",
>> +	pr_debug_ratelimited("Evicting PASID 0x%x queues\n",
>>  			    pdd->process->pasid);
>
> It would be nicer to realign all the subsequent lines in a
> single statement to the now moved open parenthesis.
>
>>
>>  	/* Mark all queues as evicted. Deactivate all active queues on
>> @@ -650,7 +650,7 @@ static int evict_process_queues_cpsch(struct device_queue_manager *dqm,
>>  		goto out;
>>
>>  	pdd = qpd_to_pdd(qpd);
>> -	pr_info_ratelimited("Evicting PASID 0x%x queues\n",
>> +	pr_debug_ratelimited("Evicting PASID 0x%x queues\n",
>>  			    pdd->process->pasid);
>
> etc...

Yeah, absolutely, thanks for pointing that out. v2 coming shortly.

Julian
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

WARNING: multiple messages have this Message-ID (diff)
From: Julian Sax <jsbc@gmx.de>
To: Joe Perches <joe@perches.com>
Cc: "David Airlie" <airlied@linux.ie>,
	"Felix Kuehling" <Felix.Kuehling@amd.com>,
	linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org,
	dri-devel@lists.freedesktop.org,
	"Alex Deucher" <alexander.deucher@amd.com>,
	"Christian König" <christian.koenig@amd.com>
Subject: Re: [PATCH] drm/amdkfd: Make process queues logs less verbose
Date: Sun, 02 Feb 2020 01:14:46 +0100	[thread overview]
Message-ID: <87lfpl4zgp.fsf@chef> (raw)
In-Reply-To: <b9b671508d478469c1ad43206dd29d770bfb7818.camel@perches.com> (Joe Perches's message of "Sat, 01 Feb 2020 15:37:43 -0800")

Joe Perches <joe@perches.com> writes:

> On Sun, 2020-02-02 at 00:11 +0100, Julian Sax wrote:
>> During normal usage, especially if jobs are started and stopped in rapid
>> succession, the kernel log is filled with messages like this:
>>
>> [38732.522910] Restoring PASID 0x8003 queues
>> [38732.666767] Evicting PASID 0x8003 queues
>> [38732.714074] Restoring PASID 0x8003 queues
>> [38732.815633] Evicting PASID 0x8003 queues
>> [38732.834961] Restoring PASID 0x8003 queues
>> [38732.840536] Evicting PASID 0x8003 queues
>> [38732.869846] Restoring PASID 0x8003 queues
>> [38732.893655] Evicting PASID 0x8003 queues
>> [38732.927975] Restoring PASID 0x8003 queues
>>
>> According to [1], these messages are expected, but they carry little
>> value for the end user, so turn them into debug messages.
>>
>> [1] https://github.com/RadeonOpenCompute/ROCm/issues/343
>
> trivia:
>
>> diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c b/drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c
> []
>> @@ -604,7 +604,7 @@ static int evict_process_queues_nocpsch(struct device_queue_manager *dqm,
>>  		goto out;
>>
>>  	pdd = qpd_to_pdd(qpd);
>> -	pr_info_ratelimited("Evicting PASID 0x%x queues\n",
>> +	pr_debug_ratelimited("Evicting PASID 0x%x queues\n",
>>  			    pdd->process->pasid);
>
> It would be nicer to realign all the subsequent lines in a
> single statement to the now moved open parenthesis.
>
>>
>>  	/* Mark all queues as evicted. Deactivate all active queues on
>> @@ -650,7 +650,7 @@ static int evict_process_queues_cpsch(struct device_queue_manager *dqm,
>>  		goto out;
>>
>>  	pdd = qpd_to_pdd(qpd);
>> -	pr_info_ratelimited("Evicting PASID 0x%x queues\n",
>> +	pr_debug_ratelimited("Evicting PASID 0x%x queues\n",
>>  			    pdd->process->pasid);
>
> etc...

Yeah, absolutely, thanks for pointing that out. v2 coming shortly.

Julian
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

WARNING: multiple messages have this Message-ID (diff)
From: Julian Sax <jsbc@gmx.de>
To: Joe Perches <joe@perches.com>
Cc: amd-gfx@lists.freedesktop.org,
	"Felix Kuehling" <Felix.Kuehling@amd.com>,
	"Alex Deucher" <alexander.deucher@amd.com>,
	"Christian König" <christian.koenig@amd.com>,
	"David (ChunMing) Zhou" <David1.Zhou@amd.com>,
	"David Airlie" <airlied@linux.ie>,
	"Daniel Vetter" <daniel@ffwll.ch>,
	dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drm/amdkfd: Make process queues logs less verbose
Date: Sun, 02 Feb 2020 01:14:46 +0100	[thread overview]
Message-ID: <87lfpl4zgp.fsf@chef> (raw)
In-Reply-To: <b9b671508d478469c1ad43206dd29d770bfb7818.camel@perches.com> (Joe Perches's message of "Sat, 01 Feb 2020 15:37:43 -0800")

Joe Perches <joe@perches.com> writes:

> On Sun, 2020-02-02 at 00:11 +0100, Julian Sax wrote:
>> During normal usage, especially if jobs are started and stopped in rapid
>> succession, the kernel log is filled with messages like this:
>>
>> [38732.522910] Restoring PASID 0x8003 queues
>> [38732.666767] Evicting PASID 0x8003 queues
>> [38732.714074] Restoring PASID 0x8003 queues
>> [38732.815633] Evicting PASID 0x8003 queues
>> [38732.834961] Restoring PASID 0x8003 queues
>> [38732.840536] Evicting PASID 0x8003 queues
>> [38732.869846] Restoring PASID 0x8003 queues
>> [38732.893655] Evicting PASID 0x8003 queues
>> [38732.927975] Restoring PASID 0x8003 queues
>>
>> According to [1], these messages are expected, but they carry little
>> value for the end user, so turn them into debug messages.
>>
>> [1] https://github.com/RadeonOpenCompute/ROCm/issues/343
>
> trivia:
>
>> diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c b/drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c
> []
>> @@ -604,7 +604,7 @@ static int evict_process_queues_nocpsch(struct device_queue_manager *dqm,
>>  		goto out;
>>
>>  	pdd = qpd_to_pdd(qpd);
>> -	pr_info_ratelimited("Evicting PASID 0x%x queues\n",
>> +	pr_debug_ratelimited("Evicting PASID 0x%x queues\n",
>>  			    pdd->process->pasid);
>
> It would be nicer to realign all the subsequent lines in a
> single statement to the now moved open parenthesis.
>
>>
>>  	/* Mark all queues as evicted. Deactivate all active queues on
>> @@ -650,7 +650,7 @@ static int evict_process_queues_cpsch(struct device_queue_manager *dqm,
>>  		goto out;
>>
>>  	pdd = qpd_to_pdd(qpd);
>> -	pr_info_ratelimited("Evicting PASID 0x%x queues\n",
>> +	pr_debug_ratelimited("Evicting PASID 0x%x queues\n",
>>  			    pdd->process->pasid);
>
> etc...

Yeah, absolutely, thanks for pointing that out. v2 coming shortly.

Julian

  reply	other threads:[~2020-02-03  8:27 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-01 23:11 [PATCH] drm/amdkfd: Make process queues logs less verbose Julian Sax
2020-02-01 23:11 ` Julian Sax
2020-02-01 23:11 ` Julian Sax
2020-02-01 23:37 ` Joe Perches
2020-02-01 23:37   ` Joe Perches
2020-02-01 23:37   ` Joe Perches
2020-02-02  0:14   ` Julian Sax [this message]
2020-02-02  0:14     ` Julian Sax
2020-02-02  0:14     ` Julian Sax
2020-02-02  0:18   ` [PATCH v2] " Julian Sax
2020-02-02  0:18     ` Julian Sax
2020-02-02  0:18     ` Julian Sax

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87lfpl4zgp.fsf@chef \
    --to=jsbc@gmx.de \
    --cc=David1.Zhou@amd.com \
    --cc=Felix.Kuehling@amd.com \
    --cc=airlied@linux.ie \
    --cc=alexander.deucher@amd.com \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=christian.koenig@amd.com \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=joe@perches.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.