From: Kalle Valo <kvalo@codeaurora.org>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Maya Erez <merez@codeaurora.org>,
Dedy Lansky <dlansky@codeaurora.org>,
linux-wireless@vger.kernel.org, wil6210@qti.qualcomm.com,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] wil6210: use after free in wil_netif_rx_any()
Date: Sat, 21 Sep 2019 06:31:30 +0000 [thread overview]
Message-ID: <87lfuib1od.fsf@codeaurora.org> (raw)
In-Reply-To: <20190921060145.GD18726@mwanda> (Dan Carpenter's message of "Sat, 21 Sep 2019 09:01:45 +0300")
Dan Carpenter <dan.carpenter@oracle.com> writes:
> The debug code dereferences "skb" to print "skb->len" so we have to
> print the message before we free "skb".
>
> Fixes: f99fe49ff372 ("wil6210: add wil_netif_rx() helper function")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
As this is a regression starting from v5.4-rc1, I'll queue this to v5.4.
--
Kalle Valo
WARNING: multiple messages have this Message-ID (diff)
From: Kalle Valo <kvalo@codeaurora.org>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Maya Erez <merez@codeaurora.org>,
Dedy Lansky <dlansky@codeaurora.org>,
linux-wireless@vger.kernel.org, wil6210@qti.qualcomm.com,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] wil6210: use after free in wil_netif_rx_any()
Date: Sat, 21 Sep 2019 09:31:30 +0300 [thread overview]
Message-ID: <87lfuib1od.fsf@codeaurora.org> (raw)
In-Reply-To: <20190921060145.GD18726@mwanda> (Dan Carpenter's message of "Sat, 21 Sep 2019 09:01:45 +0300")
Dan Carpenter <dan.carpenter@oracle.com> writes:
> The debug code dereferences "skb" to print "skb->len" so we have to
> print the message before we free "skb".
>
> Fixes: f99fe49ff372 ("wil6210: add wil_netif_rx() helper function")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
As this is a regression starting from v5.4-rc1, I'll queue this to v5.4.
--
Kalle Valo
next prev parent reply other threads:[~2019-09-21 6:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-21 6:01 [PATCH] wil6210: use after free in wil_netif_rx_any() Dan Carpenter
2019-09-21 6:01 ` Dan Carpenter
2019-09-21 6:31 ` Kalle Valo [this message]
2019-09-21 6:31 ` Kalle Valo
2019-09-25 6:12 ` Kalle Valo
2019-09-25 6:12 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lfuib1od.fsf@codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=dan.carpenter@oracle.com \
--cc=dlansky@codeaurora.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=merez@codeaurora.org \
--cc=wil6210@qti.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.