From: Markus Armbruster <armbru@redhat.com>
To: Eric Blake <eblake@redhat.com>
Cc: berrange@redhat.com, alex.bennee@linaro.org,
qemu-devel@nongnu.org, kraxel@redhat.com, philmd@redhat.com,
Wei Yang <richardw.yang@linux.intel.com>
Subject: Re: [Qemu-devel] [PATCH] Makefile: simplify qapi-py definition with wildcard
Date: Tue, 21 May 2019 17:28:27 +0200 [thread overview]
Message-ID: <87lfyzrfms.fsf@dusky.pond.sub.org> (raw)
In-Reply-To: <c184d4f7-686b-d54a-f969-a05ab965028a@redhat.com> (Eric Blake's message of "Tue, 21 May 2019 07:00:12 -0500")
Eric Blake <eblake@redhat.com> writes:
> On 5/21/19 3:12 AM, Wei Yang wrote:
>> All the python script in scripts/qapi is used to generate qapi code. Use
>> wildcard to simplify it.
>>
>> Signed-off-by: Wei Yang <richardw.yang@linux.intel.com>
>> ---
>> Makefile | 8 +-------
>> 1 file changed, 1 insertion(+), 7 deletions(-)
>
> I'm not a fan of $(wildcard). It makes your tarball creation
> non-deterministic - if there is a leftover file from development that is
> no longer part of the build, wildcard will still pick it up. Explicit
Actually, in this case can "only" adds spurious prerequisites.
> lists are better. I'm inclined to NACK this, but Markus has final say
> since he maintains the qapi generator.
I consider use of $(wildcard) for the purpose of collecting sources a
lazy mistake.
next prev parent reply other threads:[~2019-05-21 15:33 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-21 8:12 [Qemu-devel] [PATCH] Makefile: simplify qapi-py definition with wildcard Wei Yang
2019-05-21 12:00 ` Eric Blake
2019-05-21 15:28 ` Markus Armbruster [this message]
2019-05-22 0:53 ` Wei Yang
2019-05-22 1:36 ` Eric Blake
2019-05-22 2:36 ` Wei Yang
2019-05-22 0:52 ` Wei Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lfyzrfms.fsf@dusky.pond.sub.org \
--to=armbru@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=berrange@redhat.com \
--cc=eblake@redhat.com \
--cc=kraxel@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=richardw.yang@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.