From: Kalle Valo <kvalo@codeaurora.org>
To: Ryder Lee <ryder.lee@mediatek.com>
Cc: Lorenzo Bianconi <lorenzo.bianconi83@gmail.com>,
Felix Fietkau <nbd@nbd.name>, Roy Luo <roychl666@gmail.com>,
linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org, linux-mediatek@lists.infradead.org
Subject: Re: [Resend PATCH] mt76: change the return type of mt76_dma_attach()
Date: Mon, 11 Feb 2019 11:19:28 +0200 [thread overview]
Message-ID: <87lg2m3cnz.fsf@codeaurora.org> (raw)
In-Reply-To: <228fdddb9ca96e8ce861e324eb9039722cf18f49.1549850911.git.ryder.lee@mediatek.com> (Ryder Lee's message of "Mon, 11 Feb 2019 16:48:29 +0800")
Ryder Lee <ryder.lee@mediatek.com> writes:
> There is no need to return 0 in mt76_dma_attach(), so switch it to void.
>
> Signed-off-by: Ryder Lee <ryder.lee@mediatek.com>
When you send a new version mark it as v2:
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches#patch_version_missing
And add a changelog:
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches#changelog_missing
No need to resend because of this, but please do remember this in the
future.
--
Kalle Valo
WARNING: multiple messages have this Message-ID (diff)
From: Kalle Valo <kvalo@codeaurora.org>
To: Ryder Lee <ryder.lee@mediatek.com>
Cc: Lorenzo Bianconi <lorenzo.bianconi83@gmail.com>,
Felix Fietkau <nbd@nbd.name>, Roy Luo <roychl666@gmail.com>,
<linux-wireless@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<netdev@vger.kernel.org>, <linux-mediatek@lists.infradead.org>
Subject: Re: [Resend PATCH] mt76: change the return type of mt76_dma_attach()
Date: Mon, 11 Feb 2019 11:19:28 +0200 [thread overview]
Message-ID: <87lg2m3cnz.fsf@codeaurora.org> (raw)
In-Reply-To: <228fdddb9ca96e8ce861e324eb9039722cf18f49.1549850911.git.ryder.lee@mediatek.com> (Ryder Lee's message of "Mon, 11 Feb 2019 16:48:29 +0800")
Ryder Lee <ryder.lee@mediatek.com> writes:
> There is no need to return 0 in mt76_dma_attach(), so switch it to void.
>
> Signed-off-by: Ryder Lee <ryder.lee@mediatek.com>
When you send a new version mark it as v2:
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches#patch_version_missing
And add a changelog:
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches#changelog_missing
No need to resend because of this, but please do remember this in the
future.
--
Kalle Valo
next prev parent reply other threads:[~2019-02-11 9:19 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-11 2:13 [PATCH] mt76: change the retun type of mt76_dma_attach() Ryder Lee
2019-02-11 8:48 ` [Resend PATCH] mt76: change the return " Ryder Lee
2019-02-11 2:13 ` [PATCH] mt76: change the retun " Ryder Lee
2019-02-11 8:38 ` Sergei Shtylyov
2019-02-11 8:48 ` Ryder Lee
2019-02-11 8:48 ` Ryder Lee
2019-02-11 9:19 ` Kalle Valo [this message]
2019-02-11 9:19 ` [Resend PATCH] mt76: change the return " Kalle Valo
2019-02-11 19:00 ` [PATCH] mt76: change the retun " Felix Fietkau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lg2m3cnz.fsf@codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=lorenzo.bianconi83@gmail.com \
--cc=nbd@nbd.name \
--cc=netdev@vger.kernel.org \
--cc=roychl666@gmail.com \
--cc=ryder.lee@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.