From: Felipe Balbi <felipe.balbi@linux.intel.com>
To: Minas Harutyunyan <minas.harutyunyan@synopsys.com>,
Marek Szyprowski <m.szyprowski@samsung.com>Minas Harutyunyan
<minas.harutyunyan@synopsys.com>,
Dan Carpenter <dan.carpenter@oracle.com>,
Maynard CABIENTE <maynard.cabiente@raritan.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Geert Uytterhoeven <geert@linux-m68k.org>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Subject: usb: dwc2: Revert "usb: dwc2: Disable all EP's on disconnect"
Date: Fri, 07 Dec 2018 11:50:21 +0200 [thread overview]
Message-ID: <87lg517jj6.fsf@linux.intel.com> (raw)
Hi,
Minas Harutyunyan <minas.harutyunyan@synopsys.com> writes:
> Hi Marek,
>
> On 12/6/2018 7:04 PM, Marek Szyprowski wrote:
>> Dear Minas,
>>
>> On 2018-12-04 13:34, Minas Harutyunyan wrote:
>>> On 11/23/2018 6:43 PM, Dan Carpenter wrote:
>>>> Ugh... We also had a long thread about the v2 patch but it turns out
>>>> the list was not CC'd. I should have checked for that.
>>>>
>>>> You have to pass a flag to say if the caller holds the lock or not...
>>>>
>>>> regards,
>>>> dan carpenter
>>>>
>>> Hi Dan, Marek, Maynard,
>>>
>>> Could you please apply bellow patch over follow patches:
>>>
>>> dccf1bad4be7 usb: dwc2: Disable all EP's on disconnect
>>> 6f774b501928 usb: dwc2: Fix ep disable spinlock flow.
>>>
>>> Please review and test. Feedback is appreciated :-)
>>
>> Okay, I finally managed to find some time to check this. Your diff is
>> mangled, so I had to manually apply it. Frankly, it is very similar to
>> the revert I proposed. I've checked it on my test machines and it fixes
>> the issues. I'm not very happy about the unlock/lock design, but it
>> should be safe in this case and doesn't make the code even more complex.
>> Feel free to add a following tag to the final patch:
>>
>> Tested-by: Marek Szyprowski <m.szyprowski@samsung.com>
> Thanks for testing.
should $Subject be applied? Can you resend rebased on testing/next with
Tested-by tags collected if you're happy with it?
thanks
WARNING: multiple messages have this Message-ID (diff)
From: Felipe Balbi <felipe.balbi@linux.intel.com>
To: Minas Harutyunyan <minas.harutyunyan@synopsys.com>,
Marek Szyprowski <m.szyprowski@samsung.com>,
Minas Harutyunyan <minas.harutyunyan@synopsys.com>,
Dan Carpenter <dan.carpenter@oracle.com>,
Maynard CABIENTE <maynard.cabiente@raritan.com>
Cc: "linux-kernel\@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-usb\@vger.kernel.org" <linux-usb@vger.kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Geert Uytterhoeven <geert@linux-m68k.org>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Subject: Re: [PATCH] usb: dwc2: Revert "usb: dwc2: Disable all EP's on disconnect"
Date: Fri, 07 Dec 2018 11:50:21 +0200 [thread overview]
Message-ID: <87lg517jj6.fsf@linux.intel.com> (raw)
In-Reply-To: <410670D7E743164D87FA6160E7907A56013A7B47A2@am04wembxa.internal.synopsys.com>
Hi,
Minas Harutyunyan <minas.harutyunyan@synopsys.com> writes:
> Hi Marek,
>
> On 12/6/2018 7:04 PM, Marek Szyprowski wrote:
>> Dear Minas,
>>
>> On 2018-12-04 13:34, Minas Harutyunyan wrote:
>>> On 11/23/2018 6:43 PM, Dan Carpenter wrote:
>>>> Ugh... We also had a long thread about the v2 patch but it turns out
>>>> the list was not CC'd. I should have checked for that.
>>>>
>>>> You have to pass a flag to say if the caller holds the lock or not...
>>>>
>>>> regards,
>>>> dan carpenter
>>>>
>>> Hi Dan, Marek, Maynard,
>>>
>>> Could you please apply bellow patch over follow patches:
>>>
>>> dccf1bad4be7 usb: dwc2: Disable all EP's on disconnect
>>> 6f774b501928 usb: dwc2: Fix ep disable spinlock flow.
>>>
>>> Please review and test. Feedback is appreciated :-)
>>
>> Okay, I finally managed to find some time to check this. Your diff is
>> mangled, so I had to manually apply it. Frankly, it is very similar to
>> the revert I proposed. I've checked it on my test machines and it fixes
>> the issues. I'm not very happy about the unlock/lock design, but it
>> should be safe in this case and doesn't make the code even more complex.
>> Feel free to add a following tag to the final patch:
>>
>> Tested-by: Marek Szyprowski <m.szyprowski@samsung.com>
> Thanks for testing.
should $Subject be applied? Can you resend rebased on testing/next with
Tested-by tags collected if you're happy with it?
thanks
--
balbi
next reply other threads:[~2018-12-07 9:50 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-07 9:50 Felipe Balbi [this message]
2018-12-07 9:50 ` [PATCH] usb: dwc2: Revert "usb: dwc2: Disable all EP's on disconnect" Felipe Balbi
-- strict thread matches above, loose matches on Subject: below --
2018-12-07 14:40 Dan Carpenter
2018-12-07 14:40 ` [PATCH] " Dan Carpenter
2018-12-07 14:13 Minas Harutyunyan
2018-12-07 14:13 ` [PATCH] " Minas Harutyunyan
2018-12-07 11:20 Minas Harutyunyan
2018-12-07 11:20 ` [PATCH] " Minas Harutyunyan
2018-12-07 10:15 Dan Carpenter
2018-12-07 10:15 ` [PATCH] " Dan Carpenter
2018-12-07 10:11 Felipe Balbi
2018-12-07 10:11 ` [PATCH] " Felipe Balbi
2018-12-07 9:58 Minas Harutyunyan
2018-12-07 9:58 ` [PATCH] " Minas Harutyunyan
2018-12-07 9:06 Minas Harutyunyan
2018-12-07 9:06 ` [PATCH] " Minas Harutyunyan
2018-12-07 9:06 Minas Harutyunyan
2018-12-07 9:06 ` [PATCH] " Minas Harutyunyan
2018-12-06 23:09 Maynard CABIENTE
2018-12-06 23:09 ` [PATCH] " Maynard CABIENTE
2018-12-06 15:07 Marek Szyprowski
2018-12-06 15:07 ` [PATCH] " Marek Szyprowski
2018-12-06 15:03 Marek Szyprowski
2018-12-06 15:03 ` [PATCH] " Marek Szyprowski
2018-12-06 14:52 Dan Carpenter
2018-12-06 14:52 ` [PATCH] " Dan Carpenter
2018-12-05 12:52 Minas Harutyunyan
2018-12-05 12:52 ` [PATCH] " Minas Harutyunyan
2018-12-04 13:29 Dan Carpenter
2018-12-04 13:29 ` [PATCH] " Dan Carpenter
2018-12-04 12:34 Minas Harutyunyan
2018-12-04 12:34 ` [PATCH] " Minas Harutyunyan
2018-11-23 14:43 Dan Carpenter
2018-11-23 14:43 ` [PATCH] " Dan Carpenter
2018-11-23 9:49 Marek Szyprowski
2018-11-23 9:49 ` [PATCH] " Marek Szyprowski
2018-11-22 6:53 Minas Harutyunyan
2018-11-22 6:53 ` [PATCH] " Minas Harutyunyan
2018-11-21 15:45 Marek Szyprowski
2018-11-21 15:45 ` [PATCH] " Marek Szyprowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lg517jj6.fsf@linux.intel.com \
--to=felipe.balbi@linux.intel.com \
--cc=b.zolnierkie@samsung.com \
--cc=geert@linux-m68k.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=minas.harutyunyan@synopsys.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.