From: Gregory CLEMENT <gregory.clement@bootlin.com>
To: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Cc: "Andrew Lunn" <andrew@lunn.ch>,
"Jason Cooper" <jason@lakedaemon.net>,
linux-pm@vger.kernel.org,
"Antoine Tenart" <antoine.tenart@bootlin.com>,
"Viresh Kumar" <viresh.kumar@linaro.org>,
"Hanna Hawa" <hannah@marvell.com>,
"Omri Itach" <omrii@marvell.com>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
"Maxime Chevallier" <maxime.chevallier@bootlin.com>,
"Nadav Haklai" <nadavh@marvell.com>,
"Shadi Ammouri" <shadi@marvell.com>,
"Igal Liberman" <igall@marvell.com>,
"Miquèl Raynal" <miquel.raynal@bootlin.com>,
"Marcin Wojtas" <mw@semihalf.com>,
linux-arm-kernel@lists.infradead.org,
"Sebastian Hesselbarth" <sebastian.hesselbarth@gmail.com>
Subject: Re: [PATCH 2/2] cpufreq: ap806: add cpufreq driver for Armada 8K
Date: Mon, 24 Sep 2018 16:45:58 +0200 [thread overview]
Message-ID: <87lg7reyxl.fsf@bootlin.com> (raw)
In-Reply-To: <20180922142838.6bde6b9c@windsurf> (Thomas Petazzoni's message of "Sat, 22 Sep 2018 14:28:38 +0200")
Hi Thomas,
On sam., sept. 22 2018, Thomas Petazzoni <thomas.petazzoni@bootlin.com> wrote:
[...]
>> +{
>> + int cpu;
>> +
>> + for_each_possible_cpu(cpu) {
>> + struct device *cpu_dev = get_cpu_device(cpu);
>> + struct clk *clk = clk_get(cpu_dev, 0);
>> +
>> + if (IS_ERR(clk))
>> + dev_warn(cpu_dev, "Cannot get clock for CPU %d\n", cpu);
>> +
>> + if (clk_is_match(clk, cur_clk))
>
> Is it OK to call clk_is_match() is clk being an error ?
>
yes the function check the validity of the pointers.
[...]
> Once again, this is not a full review, I haven't reviewed the logic of
> the driver itself, just a few obvious things I noticed.
Thanks for this first level review, I took into account all your remarks.
Gregory
>
> Best regards,
>
> Thomas Petazzoni
> --
> Thomas Petazzoni, CTO, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com
--
Gregory Clement, Bootlin
Embedded Linux and Kernel engineering
http://bootlin.com
WARNING: multiple messages have this Message-ID (diff)
From: gregory.clement@bootlin.com (Gregory CLEMENT)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] cpufreq: ap806: add cpufreq driver for Armada 8K
Date: Mon, 24 Sep 2018 16:45:58 +0200 [thread overview]
Message-ID: <87lg7reyxl.fsf@bootlin.com> (raw)
In-Reply-To: <20180922142838.6bde6b9c@windsurf> (Thomas Petazzoni's message of "Sat, 22 Sep 2018 14:28:38 +0200")
Hi Thomas,
On sam., sept. 22 2018, Thomas Petazzoni <thomas.petazzoni@bootlin.com> wrote:
[...]
>> +{
>> + int cpu;
>> +
>> + for_each_possible_cpu(cpu) {
>> + struct device *cpu_dev = get_cpu_device(cpu);
>> + struct clk *clk = clk_get(cpu_dev, 0);
>> +
>> + if (IS_ERR(clk))
>> + dev_warn(cpu_dev, "Cannot get clock for CPU %d\n", cpu);
>> +
>> + if (clk_is_match(clk, cur_clk))
>
> Is it OK to call clk_is_match() is clk being an error ?
>
yes the function check the validity of the pointers.
[...]
> Once again, this is not a full review, I haven't reviewed the logic of
> the driver itself, just a few obvious things I noticed.
Thanks for this first level review, I took into account all your remarks.
Gregory
>
> Best regards,
>
> Thomas Petazzoni
> --
> Thomas Petazzoni, CTO, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com
--
Gregory Clement, Bootlin
Embedded Linux and Kernel engineering
http://bootlin.com
next prev parent reply other threads:[~2018-09-24 14:45 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-21 15:43 [PATCH 1/2] MAINTAINERS: add new entries for Armada 8K cpufreq driver Gregory CLEMENT
2018-09-21 15:43 ` Gregory CLEMENT
2018-09-21 15:43 ` [PATCH 2/2] cpufreq: ap806: add cpufreq driver for Armada 8K Gregory CLEMENT
2018-09-21 15:43 ` Gregory CLEMENT
2018-09-22 12:28 ` Thomas Petazzoni
2018-09-22 12:28 ` Thomas Petazzoni
2018-09-24 14:45 ` Gregory CLEMENT [this message]
2018-09-24 14:45 ` Gregory CLEMENT
2018-09-22 17:48 ` [PATCH 1/2] MAINTAINERS: add new entries for Armada 8K cpufreq driver Baruch Siach
2018-09-22 17:48 ` Baruch Siach
-- strict thread matches above, loose matches on Subject: below --
2018-09-24 15:12 [PATCH 0/2] Add cpufreq support for Armada 8K Gregory CLEMENT
2018-09-24 15:12 ` [PATCH 2/2] cpufreq: ap806: add cpufreq driver " Gregory CLEMENT
2018-09-24 15:12 ` Gregory CLEMENT
2018-10-04 5:06 ` Viresh Kumar
2018-10-04 5:06 ` Viresh Kumar
2018-11-15 10:36 ` Gregory CLEMENT
2018-11-15 10:36 ` Gregory CLEMENT
2018-11-16 4:30 ` Viresh Kumar
2018-11-16 4:30 ` Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lg7reyxl.fsf@bootlin.com \
--to=gregory.clement@bootlin.com \
--cc=andrew@lunn.ch \
--cc=antoine.tenart@bootlin.com \
--cc=hannah@marvell.com \
--cc=igall@marvell.com \
--cc=jason@lakedaemon.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-pm@vger.kernel.org \
--cc=maxime.chevallier@bootlin.com \
--cc=miquel.raynal@bootlin.com \
--cc=mw@semihalf.com \
--cc=nadavh@marvell.com \
--cc=omrii@marvell.com \
--cc=rjw@rjwysocki.net \
--cc=sebastian.hesselbarth@gmail.com \
--cc=shadi@marvell.com \
--cc=thomas.petazzoni@bootlin.com \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.