All of lore.kernel.org
 help / color / mirror / Atom feed
From: gregory.clement@bootlin.com (Gregory CLEMENT)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: dts: marvell: Fix SPI and I2C bus warnings
Date: Fri, 21 Sep 2018 12:52:07 +0200	[thread overview]
Message-ID: <87lg7vi0mg.fsf@bootlin.com> (raw)
In-Reply-To: <20180913181245.25484-7-robh@kernel.org> (Rob Herring's message of "Thu, 13 Sep 2018 13:12:31 -0500")

Hi Rob,
 
 On jeu., sept. 13 2018, Rob Herring <robh@kernel.org> wrote:

> dtc has new checks for I2C and SPI buses. Fix the warnings in node names
> and unit-addresses.
>
> arch/arm/boot/dts/dove-cubox.dtb: Warning (i2c_bus_reg): /i2c-mux/i2c at 0/clock-generator: I2C bus unit address format error, expected "60"
> arch/arm/boot/dts/dove-cubox-es.dtb: Warning (i2c_bus_reg): /i2c-mux/i2c at 0/clock-generator: I2C bus unit address format error, expected "60"
> arch/arm/boot/dts/dove-cubox.dtb: Warning (spi_bus_bridge): /mbus/internal-regs/spi-ctrl at 10600: node name for SPI buses should be 'spi'
> arch/arm/boot/dts/dove-cubox-es.dtb: Warning (spi_bus_bridge): /mbus/internal-regs/spi-ctrl at 10600: node name for SPI buses should be 'spi'
> arch/arm/boot/dts/dove-dove-db.dtb: Warning (spi_bus_bridge): /mbus/internal-regs/spi-ctrl at 10600: node name for SPI buses should be 'spi'
> arch/arm/boot/dts/dove-sbc-a510.dtb: Warning (spi_bus_bridge): /mbus/internal-regs/spi-ctrl at 10600: node name for SPI buses should be 'spi'
> arch/arm/boot/dts/dove-sbc-a510.dtb: Warning (spi_bus_bridge): /mbus/internal-regs/spi-ctrl at 14600: node name for SPI buses should be 'spi'
> arch/arm/boot/dts/orion5x-kuroboxpro.dtb: Warning (i2c_bus_reg): /soc/internal-regs/i2c at 11000/rtc: I2C bus unit address format error, expected "32"
> arch/arm/boot/dts/orion5x-linkstation-lschl.dtb: Warning (i2c_bus_reg): /soc/internal-regs/i2c at 11000/rtc: I2C bus unit address format error, expected "32"
> arch/arm/boot/dts/orion5x-linkstation-lsgl.dtb: Warning (i2c_bus_reg): /soc/internal-regs/i2c at 11000/rtc: I2C bus unit address format error, expected "32"
> arch/arm/boot/dts/orion5x-linkstation-lswtgl.dtb: Warning (i2c_bus_reg): /soc/internal-regs/i2c at 11000/rtc: I2C bus unit address format error, expected "32"
>
> Cc: Jason Cooper <jason@lakedaemon.net>
> Cc: Andrew Lunn <andrew@lunn.ch>
> Cc: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
> Cc: Gregory Clement <gregory.clement@bootlin.com>
> Signed-off-by: Rob Herring <robh@kernel.org>

Applied on mvebu/dt

Thanks,

Gregory

> ---
> Please apply to the sub-arch tree. The dtc changes haven't landed, but 
> will for 4.20.
>
>  arch/arm/boot/dts/dove-cubox.dts           | 2 +-
>  arch/arm/boot/dts/dove.dtsi                | 6 +++---
>  arch/arm/boot/dts/orion5x-linkstation.dtsi | 2 +-
>  3 files changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/arch/arm/boot/dts/dove-cubox.dts b/arch/arm/boot/dts/dove-cubox.dts
> index 580e3cbcfbf7..3e1584e787ae 100644
> --- a/arch/arm/boot/dts/dove-cubox.dts
> +++ b/arch/arm/boot/dts/dove-cubox.dts
> @@ -87,7 +87,7 @@
>  	status = "okay";
>  	clock-frequency = <100000>;
>  
> -	si5351: clock-generator {
> +	si5351: clock-generator at 60 {
>  		compatible = "silabs,si5351a-msop";
>  		reg = <0x60>;
>  		#address-cells = <1>;
> diff --git a/arch/arm/boot/dts/dove.dtsi b/arch/arm/boot/dts/dove.dtsi
> index 4a0a5115b298..250ad0535e8c 100644
> --- a/arch/arm/boot/dts/dove.dtsi
> +++ b/arch/arm/boot/dts/dove.dtsi
> @@ -155,7 +155,7 @@
>  				  0xffffe000 MBUS_ID(0x03, 0x01) 0 0x0000800   /* CESA SRAM  2k */
>  				  0xfffff000 MBUS_ID(0x0d, 0x00) 0 0x0000800>; /* PMU  SRAM  2k */
>  
> -			spi0: spi-ctrl at 10600 {
> +			spi0: spi at 10600 {
>  				compatible = "marvell,orion-spi";
>  				#address-cells = <1>;
>  				#size-cells = <0>;
> @@ -168,7 +168,7 @@
>  				status = "disabled";
>  			};
>  
> -			i2c: i2c-ctrl at 11000 {
> +			i2c: i2c at 11000 {
>  				compatible = "marvell,mv64xxx-i2c";
>  				reg = <0x11000 0x20>;
>  				#address-cells = <1>;
> @@ -218,7 +218,7 @@
>  				status = "disabled";
>  			};
>  
> -			spi1: spi-ctrl at 14600 {
> +			spi1: spi at 14600 {
>  				compatible = "marvell,orion-spi";
>  				#address-cells = <1>;
>  				#size-cells = <0>;
> diff --git a/arch/arm/boot/dts/orion5x-linkstation.dtsi b/arch/arm/boot/dts/orion5x-linkstation.dtsi
> index ebd93df5d07a..b6c9b85951ea 100644
> --- a/arch/arm/boot/dts/orion5x-linkstation.dtsi
> +++ b/arch/arm/boot/dts/orion5x-linkstation.dtsi
> @@ -156,7 +156,7 @@
>  &i2c {
>  	status = "okay";
>  
> -	rtc {
> +	rtc at 32 {
>  		compatible = "ricoh,rs5c372a";
>  		reg = <0x32>;
>  	};
> -- 
> 2.17.1
>

-- 
Gregory Clement, Bootlin
Embedded Linux and Kernel engineering
http://bootlin.com

WARNING: multiple messages have this Message-ID (diff)
From: Gregory CLEMENT <gregory.clement@bootlin.com>
To: Rob Herring <robh@kernel.org>
Cc: devicetree@vger.kernel.org,
	Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
	Jason Cooper <jason@lakedaemon.net>,
	linux-arm-kernel@lists.infradead.org,
	Andrew Lunn <andrew@lunn.ch>
Subject: Re: [PATCH] ARM: dts: marvell: Fix SPI and I2C bus warnings
Date: Fri, 21 Sep 2018 12:52:07 +0200	[thread overview]
Message-ID: <87lg7vi0mg.fsf@bootlin.com> (raw)
In-Reply-To: <20180913181245.25484-7-robh@kernel.org> (Rob Herring's message of "Thu, 13 Sep 2018 13:12:31 -0500")

Hi Rob,
 
 On jeu., sept. 13 2018, Rob Herring <robh@kernel.org> wrote:

> dtc has new checks for I2C and SPI buses. Fix the warnings in node names
> and unit-addresses.
>
> arch/arm/boot/dts/dove-cubox.dtb: Warning (i2c_bus_reg): /i2c-mux/i2c@0/clock-generator: I2C bus unit address format error, expected "60"
> arch/arm/boot/dts/dove-cubox-es.dtb: Warning (i2c_bus_reg): /i2c-mux/i2c@0/clock-generator: I2C bus unit address format error, expected "60"
> arch/arm/boot/dts/dove-cubox.dtb: Warning (spi_bus_bridge): /mbus/internal-regs/spi-ctrl@10600: node name for SPI buses should be 'spi'
> arch/arm/boot/dts/dove-cubox-es.dtb: Warning (spi_bus_bridge): /mbus/internal-regs/spi-ctrl@10600: node name for SPI buses should be 'spi'
> arch/arm/boot/dts/dove-dove-db.dtb: Warning (spi_bus_bridge): /mbus/internal-regs/spi-ctrl@10600: node name for SPI buses should be 'spi'
> arch/arm/boot/dts/dove-sbc-a510.dtb: Warning (spi_bus_bridge): /mbus/internal-regs/spi-ctrl@10600: node name for SPI buses should be 'spi'
> arch/arm/boot/dts/dove-sbc-a510.dtb: Warning (spi_bus_bridge): /mbus/internal-regs/spi-ctrl@14600: node name for SPI buses should be 'spi'
> arch/arm/boot/dts/orion5x-kuroboxpro.dtb: Warning (i2c_bus_reg): /soc/internal-regs/i2c@11000/rtc: I2C bus unit address format error, expected "32"
> arch/arm/boot/dts/orion5x-linkstation-lschl.dtb: Warning (i2c_bus_reg): /soc/internal-regs/i2c@11000/rtc: I2C bus unit address format error, expected "32"
> arch/arm/boot/dts/orion5x-linkstation-lsgl.dtb: Warning (i2c_bus_reg): /soc/internal-regs/i2c@11000/rtc: I2C bus unit address format error, expected "32"
> arch/arm/boot/dts/orion5x-linkstation-lswtgl.dtb: Warning (i2c_bus_reg): /soc/internal-regs/i2c@11000/rtc: I2C bus unit address format error, expected "32"
>
> Cc: Jason Cooper <jason@lakedaemon.net>
> Cc: Andrew Lunn <andrew@lunn.ch>
> Cc: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
> Cc: Gregory Clement <gregory.clement@bootlin.com>
> Signed-off-by: Rob Herring <robh@kernel.org>

Applied on mvebu/dt

Thanks,

Gregory

> ---
> Please apply to the sub-arch tree. The dtc changes haven't landed, but 
> will for 4.20.
>
>  arch/arm/boot/dts/dove-cubox.dts           | 2 +-
>  arch/arm/boot/dts/dove.dtsi                | 6 +++---
>  arch/arm/boot/dts/orion5x-linkstation.dtsi | 2 +-
>  3 files changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/arch/arm/boot/dts/dove-cubox.dts b/arch/arm/boot/dts/dove-cubox.dts
> index 580e3cbcfbf7..3e1584e787ae 100644
> --- a/arch/arm/boot/dts/dove-cubox.dts
> +++ b/arch/arm/boot/dts/dove-cubox.dts
> @@ -87,7 +87,7 @@
>  	status = "okay";
>  	clock-frequency = <100000>;
>  
> -	si5351: clock-generator {
> +	si5351: clock-generator@60 {
>  		compatible = "silabs,si5351a-msop";
>  		reg = <0x60>;
>  		#address-cells = <1>;
> diff --git a/arch/arm/boot/dts/dove.dtsi b/arch/arm/boot/dts/dove.dtsi
> index 4a0a5115b298..250ad0535e8c 100644
> --- a/arch/arm/boot/dts/dove.dtsi
> +++ b/arch/arm/boot/dts/dove.dtsi
> @@ -155,7 +155,7 @@
>  				  0xffffe000 MBUS_ID(0x03, 0x01) 0 0x0000800   /* CESA SRAM  2k */
>  				  0xfffff000 MBUS_ID(0x0d, 0x00) 0 0x0000800>; /* PMU  SRAM  2k */
>  
> -			spi0: spi-ctrl@10600 {
> +			spi0: spi@10600 {
>  				compatible = "marvell,orion-spi";
>  				#address-cells = <1>;
>  				#size-cells = <0>;
> @@ -168,7 +168,7 @@
>  				status = "disabled";
>  			};
>  
> -			i2c: i2c-ctrl@11000 {
> +			i2c: i2c@11000 {
>  				compatible = "marvell,mv64xxx-i2c";
>  				reg = <0x11000 0x20>;
>  				#address-cells = <1>;
> @@ -218,7 +218,7 @@
>  				status = "disabled";
>  			};
>  
> -			spi1: spi-ctrl@14600 {
> +			spi1: spi@14600 {
>  				compatible = "marvell,orion-spi";
>  				#address-cells = <1>;
>  				#size-cells = <0>;
> diff --git a/arch/arm/boot/dts/orion5x-linkstation.dtsi b/arch/arm/boot/dts/orion5x-linkstation.dtsi
> index ebd93df5d07a..b6c9b85951ea 100644
> --- a/arch/arm/boot/dts/orion5x-linkstation.dtsi
> +++ b/arch/arm/boot/dts/orion5x-linkstation.dtsi
> @@ -156,7 +156,7 @@
>  &i2c {
>  	status = "okay";
>  
> -	rtc {
> +	rtc@32 {
>  		compatible = "ricoh,rs5c372a";
>  		reg = <0x32>;
>  	};
> -- 
> 2.17.1
>

-- 
Gregory Clement, Bootlin
Embedded Linux and Kernel engineering
http://bootlin.com

  reply	other threads:[~2018-09-21 10:52 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-13 18:12 [PATCH] ARM: dts: marvell: Fix SPI and I2C bus warnings Rob Herring
2018-09-13 18:12 ` Rob Herring
2018-09-21 10:52 ` Gregory CLEMENT [this message]
2018-09-21 10:52   ` Gregory CLEMENT

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87lg7vi0mg.fsf@bootlin.com \
    --to=gregory.clement@bootlin.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.