Re: [PATCH v2] usb: dwc2: host: Don't retry NAKed transactions right away

[Felipe Balbi <balbi@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 1847 bytes --]

Doug Anderson <dianders@chromium.org> writes:

> Hi,
>
> On Mon, Oct 30, 2017 at 1:32 AM, Felipe Balbi <balbi@kernel.org> wrote:
>>
>> Hi,
>>
>> Doug Anderson <dianders@chromium.org> writes:
>>> Hi,
>>>
>>> On Sat, Oct 28, 2017 at 8:51 AM, Stefan Wahren <stefan.wahren@i2se.com> wrote:
>>>> Hi Doug,
>>>>
>>>> [add Felipe since this should go through his tree]
>>>
>>> Ah.  Sorry Felipe!  I know you've landed some dwc2 stuff in the past
>>
>> No problems :-)
>>
>>> but for some reason get_maintainer didn't ID you so I thought maybe
>>> you weren't doing it anymore.  Please let me know if you'd like me to
>>> send this to you again with collected Reviewed-by and Tested-by tags.
>>
>> Yeah, please resend with all tags collected, however let's wait for a
>> week or so and give other people time to catch up. I already sent my
>> pull request to Greg, this would, anyway, go into the -rc cycle.
>
> Doh!  I just re-read this one more time (after sending v3) and
> realized I had read it incorrectly.  I read it as "please send the

that's okay :-) s**t happens

> patch with the tags and I'll wait a week before landing", but you
> actually said "please wait a week before re-sending".  Sorry for the
> noise.  In the very least, you should be on the "To" line now so if
> anyone else has any extra tags it should be very easy for you to see
> them.
>
> Right that there's no massive urgency.  It's been broken forever.

alright then :-)

>> Please add a Cc stable tag too, if necessary.
>
> Good point.  It's a little weird since it doesn't "fix" any specific
> commit, so I guess it will be up to stable folks to decide how far to
> go back.  The dwc2 devices I work with are actually on 3.14, but we
> have some pretty massive backports related to dwc2 there...

fair enough

-- 
balbi

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]