* [PATCH] drm/i915/dvo: fix debug logging on unknown DID
@ 2017-05-31 10:16 Jani Nikula
2017-05-31 10:51 ` ✗ Fi.CI.BAT: failure for " Patchwork
2017-05-31 17:55 ` [PATCH] " Clint Taylor
0 siblings, 2 replies; 4+ messages in thread
From: Jani Nikula @ 2017-05-31 10:16 UTC (permalink / raw)
To: intel-gfx; +Cc: jani.nikula
Print DID not VID on the DID error path. Looks like a copy-paste error
from the VID error path. Clarify and clean up error logging, making them
distinguishable from each other, while at it.
Reported-by: Petru Mihancea <petrum@gmail.com>
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=101243
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
drivers/gpu/drm/i915/dvo_ch7xxx.c | 10 ++++------
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/drivers/gpu/drm/i915/dvo_ch7xxx.c b/drivers/gpu/drm/i915/dvo_ch7xxx.c
index 44b3159f2fe8..7aeeffd2428b 100644
--- a/drivers/gpu/drm/i915/dvo_ch7xxx.c
+++ b/drivers/gpu/drm/i915/dvo_ch7xxx.c
@@ -217,9 +217,8 @@ static bool ch7xxx_init(struct intel_dvo_device *dvo,
name = ch7xxx_get_id(vendor);
if (!name) {
- DRM_DEBUG_KMS("ch7xxx not detected; got 0x%02x from %s "
- "slave %d.\n",
- vendor, adapter->name, dvo->slave_addr);
+ DRM_DEBUG_KMS("ch7xxx not detected; got VID 0x%02x from %s slave %d.\n",
+ vendor, adapter->name, dvo->slave_addr);
goto out;
}
@@ -229,9 +228,8 @@ static bool ch7xxx_init(struct intel_dvo_device *dvo,
devid = ch7xxx_get_did(device);
if (!devid) {
- DRM_DEBUG_KMS("ch7xxx not detected; got 0x%02x from %s "
- "slave %d.\n",
- vendor, adapter->name, dvo->slave_addr);
+ DRM_DEBUG_KMS("ch7xxx not detected; got DID 0x%02x from %s slave %d.\n",
+ device, adapter->name, dvo->slave_addr);
goto out;
}
--
2.11.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 4+ messages in thread* ✗ Fi.CI.BAT: failure for drm/i915/dvo: fix debug logging on unknown DID
2017-05-31 10:16 [PATCH] drm/i915/dvo: fix debug logging on unknown DID Jani Nikula
@ 2017-05-31 10:51 ` Patchwork
2017-05-31 17:55 ` [PATCH] " Clint Taylor
1 sibling, 0 replies; 4+ messages in thread
From: Patchwork @ 2017-05-31 10:51 UTC (permalink / raw)
To: Jani Nikula; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/dvo: fix debug logging on unknown DID
URL : https://patchwork.freedesktop.org/series/25093/
State : failure
== Summary ==
Series 25093v1 drm/i915/dvo: fix debug logging on unknown DID
https://patchwork.freedesktop.org/api/1.0/series/25093/revisions/1/mbox/
Test gem_exec_flush:
Subgroup basic-batch-kernel-default-uc:
fail -> PASS (fi-snb-2600) fdo#100007
Test gem_sync:
Subgroup basic-store-all:
pass -> FAIL (fi-ivb-3770)
fdo#100007 https://bugs.freedesktop.org/show_bug.cgi?id=100007
fi-bdw-5557u total:278 pass:267 dwarn:0 dfail:0 fail:0 skip:11 time:445s
fi-bdw-gvtdvm total:278 pass:256 dwarn:8 dfail:0 fail:0 skip:14 time:438s
fi-bsw-n3050 total:278 pass:242 dwarn:0 dfail:0 fail:0 skip:36 time:577s
fi-bxt-j4205 total:278 pass:259 dwarn:0 dfail:0 fail:0 skip:19 time:509s
fi-byt-j1900 total:278 pass:254 dwarn:0 dfail:0 fail:0 skip:24 time:488s
fi-byt-n2820 total:278 pass:250 dwarn:0 dfail:0 fail:0 skip:28 time:479s
fi-hsw-4770 total:278 pass:262 dwarn:0 dfail:0 fail:0 skip:16 time:434s
fi-hsw-4770r total:278 pass:262 dwarn:0 dfail:0 fail:0 skip:16 time:420s
fi-ilk-650 total:278 pass:228 dwarn:0 dfail:0 fail:0 skip:50 time:425s
fi-ivb-3520m total:278 pass:260 dwarn:0 dfail:0 fail:0 skip:18 time:493s
fi-ivb-3770 total:278 pass:259 dwarn:0 dfail:0 fail:1 skip:18 time:466s
fi-kbl-7500u total:278 pass:255 dwarn:5 dfail:0 fail:0 skip:18 time:465s
fi-kbl-7560u total:278 pass:263 dwarn:5 dfail:0 fail:0 skip:10 time:565s
fi-skl-6260u total:278 pass:268 dwarn:0 dfail:0 fail:0 skip:10 time:456s
fi-skl-6700hq total:278 pass:239 dwarn:0 dfail:1 fail:17 skip:21 time:426s
fi-skl-6700k total:278 pass:256 dwarn:4 dfail:0 fail:0 skip:18 time:464s
fi-skl-6770hq total:278 pass:268 dwarn:0 dfail:0 fail:0 skip:10 time:498s
fi-skl-gvtdvm total:278 pass:265 dwarn:0 dfail:0 fail:0 skip:13 time:436s
fi-snb-2520m total:278 pass:250 dwarn:0 dfail:0 fail:0 skip:28 time:538s
fi-snb-2600 total:278 pass:249 dwarn:0 dfail:0 fail:0 skip:29 time:403s
4aa1d46d3b24bbe545cdf7cbd407c18f5cd5e43d drm-tip: 2017y-05m-31d-08h-58m-36s UTC integration manifest
1f3deb5 drm/i915/dvo: fix debug logging on unknown DID
== Logs ==
For more details see: https://intel-gfx-ci.01.org/CI/Patchwork_4842/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] drm/i915/dvo: fix debug logging on unknown DID
2017-05-31 10:16 [PATCH] drm/i915/dvo: fix debug logging on unknown DID Jani Nikula
2017-05-31 10:51 ` ✗ Fi.CI.BAT: failure for " Patchwork
@ 2017-05-31 17:55 ` Clint Taylor
2017-06-01 12:57 ` Jani Nikula
1 sibling, 1 reply; 4+ messages in thread
From: Clint Taylor @ 2017-05-31 17:55 UTC (permalink / raw)
To: intel-gfx
On 05/31/2017 03:16 AM, Jani Nikula wrote:
> Print DID not VID on the DID error path. Looks like a copy-paste error
> from the VID error path. Clarify and clean up error logging, making them
> distinguishable from each other, while at it.
Reviewed-by: Clinton Taylor <clinton.a.taylor@intel.com>
-Clint
>
> Reported-by: Petru Mihancea <petrum@gmail.com>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=101243
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
> ---
> drivers/gpu/drm/i915/dvo_ch7xxx.c | 10 ++++------
> 1 file changed, 4 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/dvo_ch7xxx.c b/drivers/gpu/drm/i915/dvo_ch7xxx.c
> index 44b3159f2fe8..7aeeffd2428b 100644
> --- a/drivers/gpu/drm/i915/dvo_ch7xxx.c
> +++ b/drivers/gpu/drm/i915/dvo_ch7xxx.c
> @@ -217,9 +217,8 @@ static bool ch7xxx_init(struct intel_dvo_device *dvo,
>
> name = ch7xxx_get_id(vendor);
> if (!name) {
> - DRM_DEBUG_KMS("ch7xxx not detected; got 0x%02x from %s "
> - "slave %d.\n",
> - vendor, adapter->name, dvo->slave_addr);
> + DRM_DEBUG_KMS("ch7xxx not detected; got VID 0x%02x from %s slave %d.\n",
> + vendor, adapter->name, dvo->slave_addr);
> goto out;
> }
>
> @@ -229,9 +228,8 @@ static bool ch7xxx_init(struct intel_dvo_device *dvo,
>
> devid = ch7xxx_get_did(device);
> if (!devid) {
> - DRM_DEBUG_KMS("ch7xxx not detected; got 0x%02x from %s "
> - "slave %d.\n",
> - vendor, adapter->name, dvo->slave_addr);
> + DRM_DEBUG_KMS("ch7xxx not detected; got DID 0x%02x from %s slave %d.\n",
> + device, adapter->name, dvo->slave_addr);
> goto out;
> }
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] drm/i915/dvo: fix debug logging on unknown DID
2017-05-31 17:55 ` [PATCH] " Clint Taylor
@ 2017-06-01 12:57 ` Jani Nikula
0 siblings, 0 replies; 4+ messages in thread
From: Jani Nikula @ 2017-06-01 12:57 UTC (permalink / raw)
To: Clint Taylor, intel-gfx
On Wed, 31 May 2017, Clint Taylor <clinton.a.taylor@intel.com> wrote:
> On 05/31/2017 03:16 AM, Jani Nikula wrote:
>> Print DID not VID on the DID error path. Looks like a copy-paste error
>> from the VID error path. Clarify and clean up error logging, making them
>> distinguishable from each other, while at it.
>
> Reviewed-by: Clinton Taylor <clinton.a.taylor@intel.com>
Thanks, pushed to drm-intel-next-queued.
BR,
Jani.
>
> -Clint
>
>>
>> Reported-by: Petru Mihancea <petrum@gmail.com>
>> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=101243
>> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>> ---
>> drivers/gpu/drm/i915/dvo_ch7xxx.c | 10 ++++------
>> 1 file changed, 4 insertions(+), 6 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/i915/dvo_ch7xxx.c b/drivers/gpu/drm/i915/dvo_ch7xxx.c
>> index 44b3159f2fe8..7aeeffd2428b 100644
>> --- a/drivers/gpu/drm/i915/dvo_ch7xxx.c
>> +++ b/drivers/gpu/drm/i915/dvo_ch7xxx.c
>> @@ -217,9 +217,8 @@ static bool ch7xxx_init(struct intel_dvo_device *dvo,
>>
>> name = ch7xxx_get_id(vendor);
>> if (!name) {
>> - DRM_DEBUG_KMS("ch7xxx not detected; got 0x%02x from %s "
>> - "slave %d.\n",
>> - vendor, adapter->name, dvo->slave_addr);
>> + DRM_DEBUG_KMS("ch7xxx not detected; got VID 0x%02x from %s slave %d.\n",
>> + vendor, adapter->name, dvo->slave_addr);
>> goto out;
>> }
>>
>> @@ -229,9 +228,8 @@ static bool ch7xxx_init(struct intel_dvo_device *dvo,
>>
>> devid = ch7xxx_get_did(device);
>> if (!devid) {
>> - DRM_DEBUG_KMS("ch7xxx not detected; got 0x%02x from %s "
>> - "slave %d.\n",
>> - vendor, adapter->name, dvo->slave_addr);
>> + DRM_DEBUG_KMS("ch7xxx not detected; got DID 0x%02x from %s slave %d.\n",
>> + device, adapter->name, dvo->slave_addr);
>> goto out;
>> }
>>
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-06-01 12:54 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-05-31 10:16 [PATCH] drm/i915/dvo: fix debug logging on unknown DID Jani Nikula
2017-05-31 10:51 ` ✗ Fi.CI.BAT: failure for " Patchwork
2017-05-31 17:55 ` [PATCH] " Clint Taylor
2017-06-01 12:57 ` Jani Nikula
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.