All of lore.kernel.org
 help / color / mirror / Atom feed
From: gregory.clement@free-electrons.com (Gregory CLEMENT)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v5 2/2] ARM: dts: add support for Turris Omnia
Date: Fri, 25 Nov 2016 17:16:38 +0100	[thread overview]
Message-ID: <87lgw7ilg9.fsf@free-electrons.com> (raw)
In-Reply-To: <20161125142658.21690-3-uwe@kleine-koenig.org> ("Uwe Kleine-König"'s message of "Fri, 25 Nov 2016 15:26:58 +0100")

Hi Uwe,
 
 On ven., nov. 25 2016, Uwe Kleine-K?nig <uwe@kleine-koenig.org> wrote:

> This machine is an open hardware router by cz.nic driven by a
> Marvell Armada 385.
>
> Signed-off-by: Uwe Kleine-K?nig <uwe@kleine-koenig.org>

Applied on mvebu/dt with few changes:

First I added the SoB from Thomas Hlavacek you initially planed to add
as seen on IRC.

The other change I did are mentioned inline.

Thanks,

Gregory


[...]

> +&spi0 {
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&spi0_pins &spi0cs0_pins>;
> +	status = "okay";
> +
> +	spi-nor at 0 {
> +		compatible = "spansion,s25fl164k", "jedec,spi-nor";
> +		#address-cells = <1>;
> +		#size-cells = <1>;
> +		reg = <0>;
> +		spi-max-frequency = <40000000>;
> +

+
+		partitions {
+			compatible = "fixed-partitions";
+			#address-cells = <1>;
+			#size-cells = <1>;
+
it is mandatory since v4.4 to use this pattern for partitions.


> +		partition at 0 {
> +			reg = <0x0 0x00100000>;
> +			label = "U-Boot";
> +		};
> +
> +		partition at 1 {
                         @0x100000
We should use the reg value here ^

> +			reg = <0x00100000 0x00700000>;
> +			label = "Rescue system";
> +		};

+ };


-- 
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

WARNING: multiple messages have this Message-ID (diff)
From: Gregory CLEMENT <gregory.clement-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
To: "Uwe Kleine-König"
	<uwe-rXY34ruvC2xidJT2blvkqNi2O/JbrIOy@public.gmane.org>
Cc: "Jason Cooper" <jason-NLaQJdtUoK4Be96aLqz0jA@public.gmane.org>,
	"Andrew Lunn" <andrew-g2DYL2Zd6BY@public.gmane.org>,
	"Sebastian Hesselbarth"
	<sebastian.hesselbarth-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	"Tomas Hlavacek" <tomas.hlavacek-x+rMaJPWets@public.gmane.org>,
	"Rob Herring" <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	"Mark Rutland" <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
	devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	"Bedřicha Košatu" <bedrich.kosata-x+rMaJPWets@public.gmane.org>
Subject: Re: [PATCH v5 2/2] ARM: dts: add support for Turris Omnia
Date: Fri, 25 Nov 2016 17:16:38 +0100	[thread overview]
Message-ID: <87lgw7ilg9.fsf@free-electrons.com> (raw)
In-Reply-To: <20161125142658.21690-3-uwe-rXY34ruvC2xidJT2blvkqNi2O/JbrIOy@public.gmane.org> ("Uwe Kleine-König"'s message of "Fri, 25 Nov 2016 15:26:58 +0100")

Hi Uwe,
 
 On ven., nov. 25 2016, Uwe Kleine-König <uwe-rXY34ruvC2xidJT2blvkqNi2O/JbrIOy@public.gmane.org> wrote:

> This machine is an open hardware router by cz.nic driven by a
> Marvell Armada 385.
>
> Signed-off-by: Uwe Kleine-König <uwe-rXY34ruvC2xidJT2blvkqNi2O/JbrIOy@public.gmane.org>

Applied on mvebu/dt with few changes:

First I added the SoB from Thomas Hlavacek you initially planed to add
as seen on IRC.

The other change I did are mentioned inline.

Thanks,

Gregory


[...]

> +&spi0 {
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&spi0_pins &spi0cs0_pins>;
> +	status = "okay";
> +
> +	spi-nor@0 {
> +		compatible = "spansion,s25fl164k", "jedec,spi-nor";
> +		#address-cells = <1>;
> +		#size-cells = <1>;
> +		reg = <0>;
> +		spi-max-frequency = <40000000>;
> +

+
+		partitions {
+			compatible = "fixed-partitions";
+			#address-cells = <1>;
+			#size-cells = <1>;
+
it is mandatory since v4.4 to use this pattern for partitions.


> +		partition@0 {
> +			reg = <0x0 0x00100000>;
> +			label = "U-Boot";
> +		};
> +
> +		partition@1 {
                         @0x100000
We should use the reg value here ^

> +			reg = <0x00100000 0x00700000>;
> +			label = "Rescue system";
> +		};

+ };


-- 
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2016-11-25 16:16 UTC|newest]

Thread overview: 63+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-25 14:26 [PATCH v5 0/2] ARM: dts: add support for Turris Omnia Uwe Kleine-König
2016-11-25 14:26 ` Uwe Kleine-König
2016-11-25 14:26 ` [PATCH v5 1/2] devicetree: Add vendor prefix for CZ.NIC Uwe Kleine-König
2016-11-25 14:26   ` Uwe Kleine-König
2016-11-25 16:15   ` Gregory CLEMENT
2016-11-25 16:15     ` Gregory CLEMENT
2016-11-25 14:26 ` [PATCH v5 2/2] ARM: dts: add support for Turris Omnia Uwe Kleine-König
2016-11-25 14:26   ` Uwe Kleine-König
2016-11-25 14:32   ` Andrew Lunn
2016-11-25 14:32     ` Andrew Lunn
2016-11-25 16:16   ` Gregory CLEMENT [this message]
2016-11-25 16:16     ` Gregory CLEMENT
2016-11-27 16:00     ` Andreas Färber
2016-11-27 16:00       ` Andreas Färber
2016-11-27 16:05       ` Uwe Kleine-König
2016-11-27 16:10         ` Andreas Färber
2016-11-27 16:14           ` Andrew Lunn
2016-11-27 18:51         ` [PATCH] ARM: dts: mvebu: Add Armada 38x labels and clean up " Andreas Färber
2016-11-27 18:51           ` Andreas Färber
2016-11-27 18:51           ` Andreas Färber
2016-11-27 18:57           ` Andreas Färber
2016-11-27 18:57             ` Andreas Färber
2016-11-27 18:57             ` Andreas Färber
2016-11-28 10:37           ` Russell King - ARM Linux
2016-11-28 10:37             ` Russell King - ARM Linux
2016-11-28 10:37             ` Russell King - ARM Linux
2016-11-28 10:52             ` Andreas Färber
2016-11-28 10:52               ` Andreas Färber
2016-11-28 10:52               ` Andreas Färber
2016-11-28 10:54               ` Uwe Kleine-König
2016-11-28 10:54                 ` Uwe Kleine-König
2016-11-28 10:54                 ` Uwe Kleine-König
2016-11-28 10:58                 ` Andreas Färber
2016-11-28 10:58                   ` Andreas Färber
2016-11-28 10:58               ` Russell King - ARM Linux
2016-11-28 10:58                 ` Russell King - ARM Linux
2016-11-28 10:58                 ` Russell King - ARM Linux
2016-11-27 19:02         ` [PATCH v5 2/2] ARM: dts: add support for " Andreas Färber
2016-11-27 16:07       ` Andrew Lunn
2016-11-27 16:07         ` Andrew Lunn
2016-11-27 16:20         ` Andreas Färber
2016-11-27 16:20           ` Andreas Färber
2016-11-27 21:22       ` Andreas Färber
2016-11-27 21:22         ` Andreas Färber
2016-11-27 19:22   ` Andreas Färber
2016-11-27 19:22     ` Andreas Färber
2016-11-27 19:37     ` [PATCH] ARM: dts: mvebu: Fix armada-385-turris-omnia stdout-path Andreas Färber
2016-11-27 19:37       ` Andreas Färber
2016-11-27 19:37       ` Andreas Färber
2016-11-27 21:10       ` Andrew Lunn
2016-11-27 21:10         ` Andrew Lunn
2016-11-27 21:10         ` Andrew Lunn
2016-11-27 21:25       ` Uwe Kleine-König
2016-11-27 21:25         ` Uwe Kleine-König
2016-11-27 21:25         ` Uwe Kleine-König
2016-11-27 22:14         ` Andreas Färber
2016-11-27 22:14           ` Andreas Färber
2016-11-27 22:14           ` Andreas Färber
2016-11-27 22:30           ` Uwe Kleine-König
2016-11-27 22:30             ` Uwe Kleine-König
2016-11-27 22:30             ` Uwe Kleine-König
2016-11-27 19:39     ` [PATCH v5 2/2] ARM: dts: add support for Turris Omnia Andreas Färber
2016-11-27 19:39       ` Andreas Färber

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87lgw7ilg9.fsf@free-electrons.com \
    --to=gregory.clement@free-electrons.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.