From: Kalle Valo <kvalo@qca.qualcomm.com>
To: Bartosz Markowski <bartosz.markowski@tieto.com>
Cc: linux-wireless@vger.kernel.org,
Michal Kazior <michal.kazior@tieto.com>,
ath10k@lists.infradead.org
Subject: Re: [PATCH 5/5] ath10k: implement support for ap beacon offloading
Date: Fri, 19 Dec 2014 16:22:18 +0200 [thread overview]
Message-ID: <87lhm3iusl.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <1418829711-19713-6-git-send-email-bartosz.markowski@tieto.com> (Bartosz Markowski's message of "Wed, 17 Dec 2014 16:21:51 +0100")
Bartosz Markowski <bartosz.markowski@tieto.com> writes:
> From: Michal Kazior <michal.kazior@tieto.com>
>
> New firmware revisions support beacon and probe
> response templates instead. This means SWBA events
> are no longer delivered for these firmware
> revisions.
>
> Signed-off-by: Michal Kazior <michal.kazior@tieto.com>
[...]
> + ret = ath10k_mac_setup_bcn_p2p_ie(arvif, bcn);
> + if (ret) {
> + ath10k_warn(ar, "failed to setup p2p go bcn ie: %d\n", ret);
> + kfree_skb(bcn);
> + return ret;
> + }
> +
> + ath10k_mac_remove_vendor_ie(bcn, WLAN_OUI_WFA, WLAN_OUI_TYPE_WFA_P2P,
> + offsetof(struct ieee80211_mgmt,
> + u.beacon.variable));
A comment would be nice why you are removing the P2P IE. I guess because
there's a different command to set that IE?
--
Kalle Valo
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
WARNING: multiple messages have this Message-ID (diff)
From: Kalle Valo <kvalo@qca.qualcomm.com>
To: Bartosz Markowski <bartosz.markowski@tieto.com>
Cc: <ath10k@lists.infradead.org>, <linux-wireless@vger.kernel.org>,
Michal Kazior <michal.kazior@tieto.com>
Subject: Re: [PATCH 5/5] ath10k: implement support for ap beacon offloading
Date: Fri, 19 Dec 2014 16:22:18 +0200 [thread overview]
Message-ID: <87lhm3iusl.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <1418829711-19713-6-git-send-email-bartosz.markowski@tieto.com> (Bartosz Markowski's message of "Wed, 17 Dec 2014 16:21:51 +0100")
Bartosz Markowski <bartosz.markowski@tieto.com> writes:
> From: Michal Kazior <michal.kazior@tieto.com>
>
> New firmware revisions support beacon and probe
> response templates instead. This means SWBA events
> are no longer delivered for these firmware
> revisions.
>
> Signed-off-by: Michal Kazior <michal.kazior@tieto.com>
[...]
> + ret = ath10k_mac_setup_bcn_p2p_ie(arvif, bcn);
> + if (ret) {
> + ath10k_warn(ar, "failed to setup p2p go bcn ie: %d\n", ret);
> + kfree_skb(bcn);
> + return ret;
> + }
> +
> + ath10k_mac_remove_vendor_ie(bcn, WLAN_OUI_WFA, WLAN_OUI_TYPE_WFA_P2P,
> + offsetof(struct ieee80211_mgmt,
> + u.beacon.variable));
A comment would be nice why you are removing the P2P IE. I guess because
there's a different command to set that IE?
--
Kalle Valo
next prev parent reply other threads:[~2014-12-19 14:23 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-17 15:21 [PATCH 0/5] ath10k: new beaconning methods for AP/GO/IBSS Bartosz Markowski
2014-12-17 15:21 ` Bartosz Markowski
2014-12-17 15:21 ` [PATCH 1/5] ath10k: implement new beacon tx status event Bartosz Markowski
2014-12-17 15:21 ` Bartosz Markowski
2014-12-19 13:39 ` Kalle Valo
2014-12-19 13:39 ` Kalle Valo
2014-12-17 15:21 ` [PATCH 2/5] ath10k: implement beacon template command Bartosz Markowski
2014-12-17 15:21 ` Bartosz Markowski
2014-12-17 15:21 ` [PATCH 3/5] ath10k: implement prb tmpl wmi command Bartosz Markowski
2014-12-17 15:21 ` Bartosz Markowski
2014-12-17 15:21 ` [PATCH 4/5] ath10k: implement p2p bcn ie command Bartosz Markowski
2014-12-17 15:21 ` Bartosz Markowski
2014-12-17 15:21 ` [PATCH 5/5] ath10k: implement support for ap beacon offloading Bartosz Markowski
2014-12-17 15:21 ` Bartosz Markowski
2014-12-19 14:22 ` Kalle Valo [this message]
2014-12-19 14:22 ` Kalle Valo
2015-01-07 9:06 ` Michal Kazior
2015-01-07 9:06 ` Michal Kazior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lhm3iusl.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@qca.qualcomm.com \
--cc=ath10k@lists.infradead.org \
--cc=bartosz.markowski@tieto.com \
--cc=linux-wireless@vger.kernel.org \
--cc=michal.kazior@tieto.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.