From: Kevin Hilman <khilman@linaro.org>
To: Andrii Tseglytskyi <andrii.tseglytskyi@ti.com>
Cc: J Keerthy <j-keerthy@ti.com>,
linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org
Subject: Re: [PATCH v1 0/3] PM / AVS: SmartReflex: driver misc fixes
Date: Tue, 28 May 2013 14:03:08 -0700 [thread overview]
Message-ID: <87li6ybywj.fsf@linaro.org> (raw)
In-Reply-To: <1369652846-14412-1-git-send-email-andrii.tseglytskyi@ti.com> (Andrii Tseglytskyi's message of "Mon, 27 May 2013 14:07:23 +0300")
Andrii Tseglytskyi <andrii.tseglytskyi@ti.com> writes:
> The following patch series contain several misc fixes to SmartReflex driver:
>
> 1. disable errgen before vpbound disable. Critical fix, needed for
> proper work of AVS-VP communicaton protocol.
>
> 2. disable runtime PM on driver remove. Trivial - runtime PM cleanup.
>
> 3. fix driver name. Trivial - proper DRIVER_NAME was not defined
> since SmartReflex driver was introduced with initial commit.
>
> Patches are based on:
> git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
> tag: v3.10-rc2
>
> Verified on OMAP4430. Boot - OK. SmartReflex registers debug dump - OK
>
> Available on GitHub:
> https://github.com/andriit/linux-omap-k3.8/commits/avs_sr_driver_misc_fixes_v01
>
> Andrii Tseglytskyi (2):
> PM / AVS: SmartReflex: disable runtime PM on driver remove
> PM / AVS: SmartReflex: fix driver name
>
> Nishanth Menon (1):
> PM / AVS: SmartReflex: disable errgen before vpbound disable
>
> drivers/power/avs/smartreflex.c | 15 +++++++++++----
> 1 file changed, 11 insertions(+), 4 deletions(-)
I had a minor comment on PATCH 1/3, otherwise these look good for v3.11
(since they are not regressions, they don't qualify for v3.10.)
Please repost with the changes and be sure to copy linux-pm@vger.kernel.org
Thanks,
Kevin
WARNING: multiple messages have this Message-ID (diff)
From: Kevin Hilman <khilman@linaro.org>
To: Andrii Tseglytskyi <andrii.tseglytskyi@ti.com>
Cc: J Keerthy <j-keerthy@ti.com>, <linux-kernel@vger.kernel.org>,
<linux-omap@vger.kernel.org>
Subject: Re: [PATCH v1 0/3] PM / AVS: SmartReflex: driver misc fixes
Date: Tue, 28 May 2013 14:03:08 -0700 [thread overview]
Message-ID: <87li6ybywj.fsf@linaro.org> (raw)
In-Reply-To: <1369652846-14412-1-git-send-email-andrii.tseglytskyi@ti.com> (Andrii Tseglytskyi's message of "Mon, 27 May 2013 14:07:23 +0300")
Andrii Tseglytskyi <andrii.tseglytskyi@ti.com> writes:
> The following patch series contain several misc fixes to SmartReflex driver:
>
> 1. disable errgen before vpbound disable. Critical fix, needed for
> proper work of AVS-VP communicaton protocol.
>
> 2. disable runtime PM on driver remove. Trivial - runtime PM cleanup.
>
> 3. fix driver name. Trivial - proper DRIVER_NAME was not defined
> since SmartReflex driver was introduced with initial commit.
>
> Patches are based on:
> git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
> tag: v3.10-rc2
>
> Verified on OMAP4430. Boot - OK. SmartReflex registers debug dump - OK
>
> Available on GitHub:
> https://github.com/andriit/linux-omap-k3.8/commits/avs_sr_driver_misc_fixes_v01
>
> Andrii Tseglytskyi (2):
> PM / AVS: SmartReflex: disable runtime PM on driver remove
> PM / AVS: SmartReflex: fix driver name
>
> Nishanth Menon (1):
> PM / AVS: SmartReflex: disable errgen before vpbound disable
>
> drivers/power/avs/smartreflex.c | 15 +++++++++++----
> 1 file changed, 11 insertions(+), 4 deletions(-)
I had a minor comment on PATCH 1/3, otherwise these look good for v3.11
(since they are not regressions, they don't qualify for v3.10.)
Please repost with the changes and be sure to copy linux-pm@vger.kernel.org
Thanks,
Kevin
next prev parent reply other threads:[~2013-05-28 21:03 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-27 11:07 [PATCH v1 0/3] PM / AVS: SmartReflex: driver misc fixes Andrii Tseglytskyi
2013-05-27 11:07 ` Andrii Tseglytskyi
2013-05-27 11:07 ` [PATCH v1 1/3] PM / AVS: SmartReflex: disable errgen before vpbound disable Andrii Tseglytskyi
2013-05-27 11:07 ` Andrii Tseglytskyi
2013-05-28 18:45 ` Kevin Hilman
2013-05-28 18:45 ` Kevin Hilman
2013-05-29 9:58 ` Andrii Tseglytskyi
2013-05-29 9:58 ` Andrii Tseglytskyi
2013-05-29 14:01 ` Kevin Hilman
2013-05-29 14:01 ` Kevin Hilman
2013-05-29 14:24 ` Andrii Tseglytskyi
2013-05-29 14:24 ` Andrii Tseglytskyi
2013-05-29 16:32 ` Kevin Hilman
2013-05-29 16:32 ` Kevin Hilman
2013-05-27 11:07 ` [PATCH v1 2/3] PM / AVS: SmartReflex: disable runtime PM on driver remove Andrii Tseglytskyi
2013-05-27 11:07 ` Andrii Tseglytskyi
2013-05-27 11:07 ` [PATCH v1 3/3] PM / AVS: SmartReflex: fix driver name Andrii Tseglytskyi
2013-05-27 11:07 ` Andrii Tseglytskyi
2013-05-28 21:03 ` Kevin Hilman [this message]
2013-05-28 21:03 ` [PATCH v1 0/3] PM / AVS: SmartReflex: driver misc fixes Kevin Hilman
2013-05-29 10:00 ` Andrii Tseglytskyi
2013-05-29 10:00 ` Andrii Tseglytskyi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87li6ybywj.fsf@linaro.org \
--to=khilman@linaro.org \
--cc=andrii.tseglytskyi@ti.com \
--cc=j-keerthy@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.