All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] init: Drop initcall level output
@ 2012-06-01 16:56 Borislav Petkov
  2012-06-04  3:28 ` Rusty Russell
  0 siblings, 1 reply; 2+ messages in thread
From: Borislav Petkov @ 2012-06-01 16:56 UTC (permalink / raw)
  To: Greg Kroah-Hartman
  Cc: Andrew Morton, Linus Torvalds, LKML, Borislav Petkov, Jim Cromie,
	Rusty Russell, Jason Baron

From: Borislav Petkov <borislav.petkov@amd.com>

9fb48c744ba6a ("params: add 3rd arg to option handler callback
signature") added similar lines to dmesg:

initlevel:0=early, 4 registered initcalls
initlevel:1=core, 31 registered initcalls
initlevel:2=postcore, 11 registered initcalls
initlevel:3=arch, 7 registered initcalls
initlevel:4=subsys, 40 registered initcalls
initlevel:5=fs, 30 registered initcalls
initlevel:6=device, 250 registered initcalls
initlevel:7=late, 35 registered initcalls

but they don't contain any info for the general user staring at dmesg.
I'm very doubtful the count of initcalls registered per level helps
anyone so drop that output completely.

Cc: Jim Cromie <jim.cromie@gmail.com>
Cc: Rusty Russell <rusty@rustcorp.com.au>
Cc: Jason Baron <jbaron@redhat.com>
Signed-off-by: Borislav Petkov <borislav.petkov@amd.com>
---
 init/main.c |    7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)

diff --git a/init/main.c b/init/main.c
index 1ca6b32c4828..f956829b3add 100644
--- a/init/main.c
+++ b/init/main.c
@@ -755,13 +755,8 @@ static void __init do_initcalls(void)
 {
 	int level;
 
-	for (level = 0; level < ARRAY_SIZE(initcall_levels) - 1; level++) {
-		pr_info("initlevel:%d=%s, %d registered initcalls\n",
-			level, initcall_level_names[level],
-			(int) (initcall_levels[level+1]
-				- initcall_levels[level]));
+	for (level = 0; level < ARRAY_SIZE(initcall_levels) - 1; level++)
 		do_initcall_level(level);
-	}
 }
 
 /*
-- 
1.7.9.3.362.g71319


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] init: Drop initcall level output
  2012-06-01 16:56 [PATCH] init: Drop initcall level output Borislav Petkov
@ 2012-06-04  3:28 ` Rusty Russell
  0 siblings, 0 replies; 2+ messages in thread
From: Rusty Russell @ 2012-06-04  3:28 UTC (permalink / raw)
  To: Borislav Petkov, Greg Kroah-Hartman
  Cc: Andrew Morton, Linus Torvalds, LKML, Borislav Petkov, Jim Cromie,
	Jason Baron

On Fri,  1 Jun 2012 18:56:00 +0200, Borislav Petkov <bp@amd64.org> wrote:
> From: Borislav Petkov <borislav.petkov@amd.com>
> 
> 9fb48c744ba6a ("params: add 3rd arg to option handler callback
> signature") added similar lines to dmesg:
> 
> initlevel:0=early, 4 registered initcalls
> initlevel:1=core, 31 registered initcalls
> initlevel:2=postcore, 11 registered initcalls
> initlevel:3=arch, 7 registered initcalls
> initlevel:4=subsys, 40 registered initcalls
> initlevel:5=fs, 30 registered initcalls
> initlevel:6=device, 250 registered initcalls
> initlevel:7=late, 35 registered initcalls
> 
> but they don't contain any info for the general user staring at dmesg.
> I'm very doubtful the count of initcalls registered per level helps
> anyone so drop that output completely.
> 
> Cc: Jim Cromie <jim.cromie@gmail.com>
> Cc: Rusty Russell <rusty@rustcorp.com.au>
> Cc: Jason Baron <jbaron@redhat.com>
> Signed-off-by: Borislav Petkov <borislav.petkov@amd.com>

Agreed and applied.

Thanks!
Rusty.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2012-06-04  4:48 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-06-01 16:56 [PATCH] init: Drop initcall level output Borislav Petkov
2012-06-04  3:28 ` Rusty Russell

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.