Re: [Nouveau] [PATCH] nouveau/vieux: only advertise supported texture formats

From: Francisco Jerez <currojerez@riseup.net>
To: Lucas Stach <dev@lynxeye.de>
Cc: nouveau@lists.freedesktop.org, mesa-dev@lists.freedesktop.org
Subject: Re: [Nouveau] [PATCH] nouveau/vieux: only advertise supported texture formats
Date: Mon, 30 Apr 2012 20:08:50 +0200	[thread overview]
Message-ID: <87lildxfbh.fsf@riseup.net> (raw)
In-Reply-To: <1335806214-13903-1-git-send-email-dev@lynxeye.de> (Lucas Stach's message of "Mon, 30 Apr 2012 19:16:54 +0200")

[-- Attachment #1.1.1: Type: text/plain, Size: 1516 bytes --]

Lucas Stach <dev@lynxeye.de> writes:

> Fixes an assertion seen by users.
>
> Signed-off-by: Lucas Stach <dev@lynxeye.de>
> Tested-by: JohnDoe_71Rus on irc
> ---
>  src/mesa/drivers/dri/nouveau/nouveau_context.c |    9 +++++++++
>  1 file changed, 9 insertions(+)
>
> diff --git a/src/mesa/drivers/dri/nouveau/nouveau_context.c b/src/mesa/drivers/dri/nouveau/nouveau_context.c
> index 4845767..46c0d70 100644
> --- a/src/mesa/drivers/dri/nouveau/nouveau_context.c
> +++ b/src/mesa/drivers/dri/nouveau/nouveau_context.c
> @@ -117,6 +117,15 @@ nouveau_context_init(struct gl_context *ctx, struct nouveau_screen *screen,
>  	nouveau_span_functions_init(ctx);
>  	_mesa_allow_light_in_model(ctx, GL_FALSE);
>  
> +	/* only advertise supported texture formats */
> +	memset(&ctx->TextureFormatSupported, 0,
> +	       sizeof(ctx->TextureFormatSupported));
> +	ctx->TextureFormatSupported[MESA_FORMAT_XRGB8888] = true;
> +	ctx->TextureFormatSupported[MESA_FORMAT_ARGB8888] = true;
> +	ctx->TextureFormatSupported[MESA_FORMAT_RGB565] = true;
> +	ctx->TextureFormatSupported[MESA_FORMAT_Z16] = true;
> +	ctx->TextureFormatSupported[MESA_FORMAT_Z24_S8] = true;
> +
Hi Lucas,

It's not obvious to me how this works.  AFAIK nouveau doesn't make use
of this array.  And even if it did, the texture formats you're listing
aren't the supported ones.

>  	/* Allocate a hardware channel. */
>  	ret = nouveau_object_new(&context_dev(ctx)->object, 0xbeef0000,
>  				 NOUVEAU_FIFO_CHANNEL_CLASS,

[-- Attachment #1.2: Type: application/pgp-signature, Size: 229 bytes --]

[-- Attachment #2: Type: text/plain, Size: 156 bytes --]

_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev