Re: [PATCH] nouveau/vieux: only advertise supported texture formats

[Francisco Jerez <currojerez-sGOZH3hwPm2sTnJN9+BGXg@public.gmane.org>]

[-- Attachment #1.1.1: Type: text/plain, Size: 1423 bytes --]

Lucas Stach <dev-8ppwABl0HbeELgA04lAiVw@public.gmane.org> writes:

> Am Montag, den 30.04.2012, 20:08 +0200 schrieb Francisco Jerez:
>> Lucas Stach <dev-8ppwABl0HbeELgA04lAiVw@public.gmane.org> writes:
>>[...]
>> > +	/* only advertise supported texture formats */
>> > +	memset(&ctx->TextureFormatSupported, 0,
>> > +	       sizeof(ctx->TextureFormatSupported));
>> > +	ctx->TextureFormatSupported[MESA_FORMAT_XRGB8888] = true;
>> > +	ctx->TextureFormatSupported[MESA_FORMAT_ARGB8888] = true;
>> > +	ctx->TextureFormatSupported[MESA_FORMAT_RGB565] = true;
>> > +	ctx->TextureFormatSupported[MESA_FORMAT_Z16] = true;
>> > +	ctx->TextureFormatSupported[MESA_FORMAT_Z24_S8] = true;
>> > +
>> Hi Lucas,
>> 
>> It's not obvious to me how this works.  AFAIK nouveau doesn't make use
>> of this array.  And even if it did, the texture formats you're listing
>> aren't the supported ones.
>
> Hello Francisco,
>
> The core mesa code decides what texture formats to advertise based on
> this array.

Are you sure?  TextureFormatSupported doesn't seem to have any effect
except in drivers that use mesa's default for the ChooseTextureFormat
hook.

> And obviously someone thought it would be a good idea to
> init this array to "everything supported" if the driver doesn't
> overrides this.
>
> I opted to only advertise renderable texture formats, for reasons
> explained in my mail a minute ago.

[-- Attachment #1.2: Type: application/pgp-signature, Size: 229 bytes --]

[-- Attachment #2: Type: text/plain, Size: 181 bytes --]

_______________________________________________
Nouveau mailing list
Nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
http://lists.freedesktop.org/mailman/listinfo/nouveau