All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kevin Hilman <khilman@ti.com>
To: Vishwanath BS <vishwanath.bs@ti.com>
Cc: linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCHV2 REPOST 6/7] ARM: OMAP3 PM: Remove IO Daisychain control from cpuidle
Date: Tue, 10 Jan 2012 09:56:21 -0800	[thread overview]
Message-ID: <87lipfqw56.fsf@ti.com> (raw)
In-Reply-To: <1323878477-21122-7-git-send-email-vishwanath.bs@ti.com> (Vishwanath BS's message of "Wed, 14 Dec 2011 21:31:16 +0530")

Vishwanath BS <vishwanath.bs@ti.com> writes:

> As IO Daisy chain sequence is triggered via hwmod mux, there is no need to
> control it from cpuidle path for OMAP3.
>
> Also as omap3_disable_io_chain is no longer being used, just remove the function.
>
> Signed-off-by: Vishwanath BS <vishwanath.bs@ti.com>
> Tested-by: Govindraj.R <govindraj.raja@ti.com>

In the TRM (4460 public TRM vM) it says:

  "The software must enable the I/O wakeup prior entering a low-power
   mode and disable it following a wake-up event."

but after this series, once it's enabled, it is never disabled.   What
am I missing?

Kevin

WARNING: multiple messages have this Message-ID (diff)
From: khilman@ti.com (Kevin Hilman)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCHV2 REPOST 6/7] ARM: OMAP3 PM: Remove IO Daisychain control from cpuidle
Date: Tue, 10 Jan 2012 09:56:21 -0800	[thread overview]
Message-ID: <87lipfqw56.fsf@ti.com> (raw)
In-Reply-To: <1323878477-21122-7-git-send-email-vishwanath.bs@ti.com> (Vishwanath BS's message of "Wed, 14 Dec 2011 21:31:16 +0530")

Vishwanath BS <vishwanath.bs@ti.com> writes:

> As IO Daisy chain sequence is triggered via hwmod mux, there is no need to
> control it from cpuidle path for OMAP3.
>
> Also as omap3_disable_io_chain is no longer being used, just remove the function.
>
> Signed-off-by: Vishwanath BS <vishwanath.bs@ti.com>
> Tested-by: Govindraj.R <govindraj.raja@ti.com>

In the TRM (4460 public TRM vM) it says:

  "The software must enable the I/O wakeup prior entering a low-power
   mode and disable it following a wake-up event."

but after this series, once it's enabled, it is never disabled.   What
am I missing?

Kevin

  reply	other threads:[~2012-01-10 17:56 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-14 16:01 [PATCHV2 REPOST 0/7] ARM: OMAP3PLUS PM: Add IO DaisyChain support via hwmod mux Vishwanath BS
2011-12-14 16:01 ` Vishwanath BS
2011-12-14 16:01 ` [PATCHV2 REPOST 1/7] ARM: OMAP3 PM: correct enable/disable of daisy io chain Vishwanath BS
2011-12-14 16:01   ` Vishwanath BS
2011-12-14 16:01 ` [PATCHV2 REPOST 2/7] ARM: OMAP3 PM: Move IO Daisychain function to omap3 prm file Vishwanath BS
2011-12-14 16:01   ` Vishwanath BS
2012-01-10 17:33   ` Kevin Hilman
2012-01-10 17:33     ` Kevin Hilman
2011-12-14 16:01 ` [PATCHV2 REPOST 3/7] ARM: OMAP4 PM: Add IO Daisychain support Vishwanath BS
2011-12-14 16:01   ` Vishwanath BS
2012-01-10 17:35   ` Kevin Hilman
2012-01-10 17:35     ` Kevin Hilman
2011-12-14 16:01 ` [PATCHV2 REPOST 4/7] ARM: OMAP3 PM: Enable IO Wake up Vishwanath BS
2011-12-14 16:01   ` Vishwanath BS
2012-01-10 17:36   ` Kevin Hilman
2012-01-10 17:36     ` Kevin Hilman
2011-12-14 16:01 ` [PATCHV2 REPOST 5/7] ARM: OMAP3PLUS PM: Add IO Daisychain support via hwmod mux Vishwanath BS
2011-12-14 16:01   ` Vishwanath BS
2012-01-10 17:46   ` Kevin Hilman
2012-01-10 17:46     ` Kevin Hilman
2012-01-10 17:47     ` Kevin Hilman
2012-01-10 17:47       ` Kevin Hilman
2012-01-10 17:56   ` Kevin Hilman
2012-01-10 17:56     ` Kevin Hilman
2011-12-14 16:01 ` [PATCHV2 REPOST 6/7] ARM: OMAP3 PM: Remove IO Daisychain control from cpuidle Vishwanath BS
2011-12-14 16:01   ` Vishwanath BS
2012-01-10 17:56   ` Kevin Hilman [this message]
2012-01-10 17:56     ` Kevin Hilman
2011-12-14 16:01 ` [PATCHV2 REPOST 7/7] ARM: OMAP3 PM: Enable IO Daisychain for supported chips Vishwanath BS
2011-12-14 16:01   ` Vishwanath BS
2012-01-10 17:26 ` [PATCHV2 REPOST 0/7] ARM: OMAP3PLUS PM: Add IO DaisyChain support via hwmod mux Kevin Hilman
2012-01-10 17:26   ` Kevin Hilman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87lipfqw56.fsf@ti.com \
    --to=khilman@ti.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=vishwanath.bs@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.