All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rusty Russell <rusty@rustcorp.com.au>
To: Amit Shah <amit.shah@redhat.com>
Cc: linux-kernel@vger.kernel.org,
	"Michael S. Tsirkin" <mst@redhat.com>,
	levinsasha928@gmail.com,
	Virtualization List <virtualization@lists.linux-foundation.org>
Subject: Re: [PATCH v4 00/12] virtio: s4 support
Date: Wed, 07 Dec 2011 21:22:41 +1030	[thread overview]
Message-ID: <87liqoirgm.fsf@rustcorp.com.au> (raw)
In-Reply-To: <20111207074456.GD4651@amit-x200.redhat.com>

On Wed, 7 Dec 2011 13:14:56 +0530, Amit Shah <amit.shah@redhat.com> wrote:
> On (Wed) 07 Dec 2011 [17:54:29], Rusty Russell wrote:
> > I figure there's a reason, but it seems a bit weird :)
> 
> Well, there is one reason right now: migrating storage along with
> VMs.  The guest needs to sync all data to the disk before the target
> host accesses the image file.

I don't see why.  Sure, if qemu (or whatever) is doing buffering, it
needs to flush that.  It doesn't, last I looked, it just maps to
read/write.

What am I missing?

Thanks,
Rusty.

WARNING: multiple messages have this Message-ID (diff)
From: Rusty Russell <rusty@rustcorp.com.au>
To: Amit Shah <amit.shah@redhat.com>
Cc: Virtualization List <virtualization@lists.linux-foundation.org>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	levinsasha928@gmail.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 00/12] virtio: s4 support
Date: Wed, 07 Dec 2011 21:22:41 +1030	[thread overview]
Message-ID: <87liqoirgm.fsf@rustcorp.com.au> (raw)
In-Reply-To: <20111207074456.GD4651@amit-x200.redhat.com>

On Wed, 7 Dec 2011 13:14:56 +0530, Amit Shah <amit.shah@redhat.com> wrote:
> On (Wed) 07 Dec 2011 [17:54:29], Rusty Russell wrote:
> > I figure there's a reason, but it seems a bit weird :)
> 
> Well, there is one reason right now: migrating storage along with
> VMs.  The guest needs to sync all data to the disk before the target
> host accesses the image file.

I don't see why.  Sure, if qemu (or whatever) is doing buffering, it
needs to flush that.  It doesn't, last I looked, it just maps to
read/write.

What am I missing?

Thanks,
Rusty.

  reply	other threads:[~2011-12-07 10:52 UTC|newest]

Thread overview: 72+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-06 19:48 [PATCH v4 00/12] virtio: s4 support Amit Shah
2011-12-06 19:48 ` Amit Shah
2011-12-06 19:48 ` [PATCH v4 01/12] virtio: pci: switch to new PM API Amit Shah
2011-12-06 19:48   ` Amit Shah
2011-12-06 22:12   ` Rafael J. Wysocki
2011-12-06 22:12     ` Rafael J. Wysocki
2011-12-07  3:57     ` Amit Shah
2011-12-07  3:57       ` Amit Shah
2011-12-07  9:48       ` Rafael J. Wysocki
2011-12-07  9:48         ` Rafael J. Wysocki
2011-12-07  9:52         ` Amit Shah
2011-12-07  9:52           ` Amit Shah
2011-12-07 10:16           ` Rafael J. Wysocki
2011-12-07 10:16             ` Rafael J. Wysocki
2011-12-06 19:48 ` [PATCH v4 02/12] virtio: pci: add PM notification handlers for restore, freeze, thaw, poweroff Amit Shah
2011-12-06 19:48   ` Amit Shah
2011-12-06 19:48 ` [PATCH v4 03/12] virtio: console: Move out vq and vq buf removal into separate functions Amit Shah
2011-12-06 19:48   ` Amit Shah
2011-12-06 19:48 ` [PATCH v4 04/12] virtio: console: Add freeze and restore handlers to support S4 Amit Shah
2011-12-06 19:48   ` Amit Shah
2011-12-07 10:43   ` Michael S. Tsirkin
2011-12-07 10:43     ` Michael S. Tsirkin
2011-12-07 10:59     ` Amit Shah
2011-12-07 10:59       ` Amit Shah
2011-12-07 15:54       ` Michael S. Tsirkin
2011-12-07 15:54         ` Michael S. Tsirkin
2011-12-06 19:48 ` [PATCH v4 05/12] virtio: blk: Move out vq initialization to separate function Amit Shah
2011-12-06 19:48   ` Amit Shah
2011-12-06 19:48 ` [PATCH v4 06/12] virtio: blk: Add freeze, restore handlers to support S4 Amit Shah
2011-12-06 19:48   ` Amit Shah
2011-12-07 10:37   ` Michael S. Tsirkin
2011-12-07 10:37     ` Michael S. Tsirkin
2011-12-07 10:56     ` Amit Shah
2011-12-07 10:56       ` Amit Shah
2011-12-07 15:58       ` Michael S. Tsirkin
2011-12-07 15:58         ` Michael S. Tsirkin
2011-12-06 19:48 ` [PATCH v4 07/12] virtio: net: Move out vq initialization into separate function Amit Shah
2011-12-06 19:48   ` Amit Shah
2011-12-06 19:48 ` [PATCH v4 08/12] virtio: net: Move out vq and vq buf removal " Amit Shah
2011-12-06 19:48   ` Amit Shah
2011-12-06 19:48 ` [PATCH v4 09/12] virtio: net: Add freeze, restore handlers to support S4 Amit Shah
2011-12-06 19:48   ` Amit Shah
2011-12-07 10:28   ` Michael S. Tsirkin
2011-12-07 10:28     ` Michael S. Tsirkin
2011-12-07 10:35     ` Amit Shah
2011-12-07 10:35       ` Amit Shah
2011-12-07 11:46       ` Michael S. Tsirkin
2011-12-07 11:46         ` Michael S. Tsirkin
2011-12-06 19:48 ` [PATCH v4 10/12] virtio: balloon: ensure thread exists before stopping it Amit Shah
2011-12-06 19:48   ` Amit Shah
2011-12-06 19:48 ` [PATCH v4 11/12] virtio: balloon: Move out vq initialization into separate function Amit Shah
2011-12-06 19:48   ` Amit Shah
2011-12-06 19:48 ` [PATCH v4 12/12] virtio: balloon: Add freeze, restore handlers to support S4 Amit Shah
2011-12-06 19:48   ` Amit Shah
2011-12-07  4:50   ` Amit Shah
2011-12-07  4:50     ` Amit Shah
2011-12-07 10:34   ` (resend) " Michael S. Tsirkin
2011-12-07 10:34     ` Michael S. Tsirkin
2011-12-07 10:39     ` Amit Shah
2011-12-07 10:39       ` Amit Shah
2011-12-07  7:24 ` [PATCH v4 00/12] virtio: s4 support Rusty Russell
2011-12-07  7:44   ` Amit Shah
2011-12-07  7:44     ` Amit Shah
2011-12-07 10:52     ` Rusty Russell [this message]
2011-12-07 10:52       ` Rusty Russell
2011-12-08 11:56       ` Amit Shah
2011-12-08 11:56         ` Amit Shah
2011-12-07 10:44   ` Gleb Natapov
2011-12-07 10:44     ` Gleb Natapov
2011-12-07 13:43     ` Dor Laor
2011-12-07 13:43       ` Dor Laor
2011-12-07  7:24 ` Rusty Russell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87liqoirgm.fsf@rustcorp.com.au \
    --to=rusty@rustcorp.com.au \
    --cc=amit.shah@redhat.com \
    --cc=levinsasha928@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mst@redhat.com \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.