From: Kevin Hilman <khilman@ti.com>
To: "Cousson, Benoit" <b-cousson@ti.com>
Cc: Grant Likely <grant.likely@secretlab.ca>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v2 2/2] OMAP: omap_device: Add a method to build an omap_device from a DT node
Date: Wed, 21 Sep 2011 14:17:37 -0700 [thread overview]
Message-ID: <87lith389a.fsf@ti.com> (raw)
In-Reply-To: <4E77421C.3000202@ti.com> (Benoit Cousson's message of "Mon, 19 Sep 2011 15:22:36 +0200")
"Cousson, Benoit" <b-cousson@ti.com> writes:
> On 9/17/2011 6:13 PM, Grant Likely wrote:
>> On Fri, Sep 16, 2011 at 04:43:19PM +0200, Benoit Cousson wrote:
[...]
>>> +}
>>> +
>>> +static int _omap_device_notifier_call(struct notifier_block *nb,
>>> + unsigned long event, void *dev)
>>
>> Nit: Why the preceding underscore? Generally that is only done for
>> 'special' variants of public functions. ie. for a variant that
>> expects a lock to already be held.
>
> Yeah, the convention in this file is not that strict, and it is used
> for internal static helper function as well.
> I'll let Kevin arbitrate that point :-)
The convention in this file is the leading '_' is used for internal
helper functions.
I'd prefer to keep it that way, and if we decide to change the coding
convention to match a coding convention elsewhere, we should do it all
at the same time.
Kevin
WARNING: multiple messages have this Message-ID (diff)
From: khilman@ti.com (Kevin Hilman)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 2/2] OMAP: omap_device: Add a method to build an omap_device from a DT node
Date: Wed, 21 Sep 2011 14:17:37 -0700 [thread overview]
Message-ID: <87lith389a.fsf@ti.com> (raw)
In-Reply-To: <4E77421C.3000202@ti.com> (Benoit Cousson's message of "Mon, 19 Sep 2011 15:22:36 +0200")
"Cousson, Benoit" <b-cousson@ti.com> writes:
> On 9/17/2011 6:13 PM, Grant Likely wrote:
>> On Fri, Sep 16, 2011 at 04:43:19PM +0200, Benoit Cousson wrote:
[...]
>>> +}
>>> +
>>> +static int _omap_device_notifier_call(struct notifier_block *nb,
>>> + unsigned long event, void *dev)
>>
>> Nit: Why the preceding underscore? Generally that is only done for
>> 'special' variants of public functions. ie. for a variant that
>> expects a lock to already be held.
>
> Yeah, the convention in this file is not that strict, and it is used
> for internal static helper function as well.
> I'll let Kevin arbitrate that point :-)
The convention in this file is the leading '_' is used for internal
helper functions.
I'd prefer to keep it that way, and if we decide to change the coding
convention to match a coding convention elsewhere, we should do it all
at the same time.
Kevin
next prev parent reply other threads:[~2011-09-21 21:17 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-16 14:43 [PATCH v2 0/2] OMAP: omap_device: Add a method to build an omap_device from a DT node Benoit Cousson
2011-09-16 14:43 ` Benoit Cousson
2011-09-16 14:43 ` [PATCH v2 1/2] OMAP: omap_device: Add omap_device_[alloc|delete] for DT integration Benoit Cousson
2011-09-16 14:43 ` Benoit Cousson
2011-09-17 16:05 ` Grant Likely
2011-09-17 16:05 ` Grant Likely
2011-09-17 16:27 ` Russell King - ARM Linux
2011-09-17 16:27 ` Russell King - ARM Linux
2011-09-17 16:46 ` Grant Likely
2011-09-17 16:46 ` Grant Likely
2011-09-19 13:11 ` Cousson, Benoit
2011-09-19 13:11 ` Cousson, Benoit
2011-09-19 15:07 ` Cousson, Benoit
2011-09-19 15:07 ` Cousson, Benoit
2011-09-16 14:43 ` [PATCH v2 2/2] OMAP: omap_device: Add a method to build an omap_device from a DT node Benoit Cousson
2011-09-16 14:43 ` Benoit Cousson
2011-09-17 16:13 ` Grant Likely
2011-09-17 16:13 ` Grant Likely
2011-09-19 13:22 ` Cousson, Benoit
2011-09-19 13:22 ` Cousson, Benoit
2011-09-21 21:17 ` Kevin Hilman [this message]
2011-09-21 21:17 ` Kevin Hilman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lith389a.fsf@ti.com \
--to=khilman@ti.com \
--cc=b-cousson@ti.com \
--cc=grant.likely@secretlab.ca \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.