From: Kevin Hilman <khilman@deeprootsystems.com>
To: "Nori, Sekhar" <nsekhar@ti.com>
Cc: Nicolas Kaiser <nikai@nikai.net>,
"davinci-linux-open-source@linux.davincidsp.com"
<davinci-linux-open-source@linux.davincidsp.com>,
"kernel-janitors@vger.kernel.org"
<kernel-janitors@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mach-davinci: signedness bug
Date: Fri, 19 Nov 2010 00:28:08 +0000 [thread overview]
Message-ID: <87lj4qduna.fsf@deeprootsystems.com> (raw)
In-Reply-To: <B85A65D85D7EB246BE421B3FB0FBB5930234A2AF08@dbde02.ent.ti.com> (Sekhar Nori's message of "Tue, 16 Nov 2010 10:19:49 +0530")
"Nori, Sekhar" <nsekhar@ti.com> writes:
> Hi Nicolas,
>
> On Tue, Nov 16, 2010 at 00:10:28, Nicolas Kaiser wrote:
>> aemif_calc_rate() can return a negative error value, so all the
>> variables that get tested for this value need to be signed.
>>
>> The maximum bit width of WSETUP(WSETUP_MAX) appears to be 30 bits
>> (0xf << 26). Using a signed instead of an unsigned integer
>> shouldn't make a difference here.
>>
>> Signed-off-by: Nicolas Kaiser <nikai@nikai.net>
>
> Thanks for the fix. You could use the subject:
>
> "davinci: signedness bug in davinci_aemif_setup_timing()"
>
> Other than that:
>
> Acked-by: Sekhar Nori <nsekhar@ti.com>
Thanks, I fixed up the subject as Sekhar suggested.
Applied, queuing for 2.6.38.
Kevin
WARNING: multiple messages have this Message-ID (diff)
From: Kevin Hilman <khilman@deeprootsystems.com>
To: "Nori\, Sekhar" <nsekhar@ti.com>
Cc: Nicolas Kaiser <nikai@nikai.net>,
"davinci-linux-open-source\@linux.davincidsp.com"
<davinci-linux-open-source@linux.davincidsp.com>,
"kernel-janitors\@vger.kernel.org"
<kernel-janitors@vger.kernel.org>,
"linux-kernel\@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mach-davinci: signedness bug
Date: Thu, 18 Nov 2010 16:28:08 -0800 [thread overview]
Message-ID: <87lj4qduna.fsf@deeprootsystems.com> (raw)
In-Reply-To: <B85A65D85D7EB246BE421B3FB0FBB5930234A2AF08@dbde02.ent.ti.com> (Sekhar Nori's message of "Tue, 16 Nov 2010 10:19:49 +0530")
"Nori, Sekhar" <nsekhar@ti.com> writes:
> Hi Nicolas,
>
> On Tue, Nov 16, 2010 at 00:10:28, Nicolas Kaiser wrote:
>> aemif_calc_rate() can return a negative error value, so all the
>> variables that get tested for this value need to be signed.
>>
>> The maximum bit width of WSETUP(WSETUP_MAX) appears to be 30 bits
>> (0xf << 26). Using a signed instead of an unsigned integer
>> shouldn't make a difference here.
>>
>> Signed-off-by: Nicolas Kaiser <nikai@nikai.net>
>
> Thanks for the fix. You could use the subject:
>
> "davinci: signedness bug in davinci_aemif_setup_timing()"
>
> Other than that:
>
> Acked-by: Sekhar Nori <nsekhar@ti.com>
Thanks, I fixed up the subject as Sekhar suggested.
Applied, queuing for 2.6.38.
Kevin
next prev parent reply other threads:[~2010-11-19 0:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-15 18:40 [PATCH] mach-davinci: signedness bug Nicolas Kaiser
2010-11-15 18:40 ` Nicolas Kaiser
2010-11-16 4:49 ` Nori, Sekhar
2010-11-16 4:50 ` Nori, Sekhar
2010-11-19 0:28 ` Kevin Hilman [this message]
2010-11-19 0:28 ` Kevin Hilman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lj4qduna.fsf@deeprootsystems.com \
--to=khilman@deeprootsystems.com \
--cc=davinci-linux-open-source@linux.davincidsp.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nikai@nikai.net \
--cc=nsekhar@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.