[PATCH 2.6.27-rc3 21/28] mdb: disable console warnings if the debugger is present.

[PATCH 2.6.27-rc3 21/28] mdb: disable console warnings if the debugger is present.

[jmerkey]

disable the console warning checks if the debugger is active
because the debugger is dependent in the console output
functions in order to provide console display.   


Signed-off-by: Jeffrey Vernon Merkey (jmerkey@wolfmountaingroup.com)

--- a/include/linux/console.h	2008-08-15 21:26:27.000000000 -0600
+++ b/include/linux/console.h	2008-08-15 15:41:57.000000000 -0600
@@ -141,11 +141,16 @@
 void vcs_remove_sysfs(struct tty_struct *tty);
 
 /* Some debug stub to catch some of the obvious races in the VT code */
+
+#if defined(CONFIG_MDB) || defined(CONFIG_MDB_MODULE)
+#define WARN_CONSOLE_UNLOCKED()
+#else
 #if 1
 #define WARN_CONSOLE_UNLOCKED()	WARN_ON(!is_console_locked() && !oops_in_progress)
 #else
 #define WARN_CONSOLE_UNLOCKED()
 #endif
+#endif /* CONFIG_MDB */
 
 /* VESA Blanking Levels */
 #define VESA_NO_BLANKING        0

Re: [PATCH 2.6.27-rc3 21/28] mdb: disable console warnings if the debugger is present.

[Andi Kleen]

jmerkey@wolfmountaingroup.com writes:
>  
>  /* Some debug stub to catch some of the obvious races in the VT code */
> +
> +#if defined(CONFIG_MDB) || defined(CONFIG_MDB_MODULE)
> +#define WARN_CONSOLE_UNLOCKED()
> +#else
>  #if 1
>  #define WARN_CONSOLE_UNLOCKED()	WARN_ON(!is_console_locked() && !oops_in_progress)
>  #else
>  #define WARN_CONSOLE_UNLOCKED()
>  #endif
> +#endif /* CONFIG_MDB */

The obvious alternative would be to just set oops_in_progress
while the debugger runs.

-Andi

Re: [PATCH 2.6.27-rc3 21/28] mdb: disable console warnings if the debugger is present.

[jmerkey]

> jmerkey@wolfmountaingroup.com writes:
>>
>>  /* Some debug stub to catch some of the obvious races in the VT code */
>> +
>> +#if defined(CONFIG_MDB) || defined(CONFIG_MDB_MODULE)
>> +#define WARN_CONSOLE_UNLOCKED()
>> +#else
>>  #if 1
>>  #define WARN_CONSOLE_UNLOCKED()	WARN_ON(!is_console_locked() &&
>> !oops_in_progress)
>>  #else
>>  #define WARN_CONSOLE_UNLOCKED()
>>  #endif
>> +#endif /* CONFIG_MDB */
>
> The obvious alternative would be to just set oops_in_progress
> while the debugger runs.
>
> -Andi
>

Also added to the list.  that would remove the need for this patch, which
would also benefit kdb since it also has a similar patch in this file too.

I will roll these fixes into the rc4 patch.

Jeff