All of lore.kernel.org
 help / color / mirror / Atom feed
From: Johannes Weiner <hannes@saeurebad.de>
To: Andi Kleen <andi@firstfloor.org>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	Ingo Molnar <mingo@elte.hu>, Yinghai Lu <yhlu.kernel@gmail.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [PATCH 0/3] bootmem2 III
Date: Sun, 11 May 2008 21:18:09 +0200	[thread overview]
Message-ID: <87lk2gtzta.fsf@saeurebad.de> (raw)
In-Reply-To: <20080509184044.GA19109@one.firstfloor.org> (Andi Kleen's message of "Fri, 9 May 2008 20:40:44 +0200")

Hi Andi,

Andi Kleen <andi@firstfloor.org> writes:

> On Fri, May 09, 2008 at 05:17:13PM +0200, Johannes Weiner wrote:
>> here is bootmem2, a memory block-oriented boot time allocator.
>> 
>> Recent NUMA topologies broke the current bootmem's assumption that
>> memory nodes provide non-overlapping and contiguous ranges of pages.
>
> I'm still not sure that's a really good rationale for bootmem2.
> e.g. the non continuous nodes are really special cases and there tends
> to be enough memory at the beginning which is enough for boot time
> use, so for those systems it would be quite reasonably to only 
> put the continuous starts of the nodes into bootmem.

Hm, that would put the logic into arch-code.  I have no strong opinion
about it.

> That said the bootmem code has gotten a little crufty and a clean
> rewrite might be a good idea.

I agree completely.

	Hannes

WARNING: multiple messages have this Message-ID (diff)
From: Johannes Weiner <hannes@saeurebad.de>
To: Andi Kleen <andi@firstfloor.org>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	Ingo Molnar <mingo@elte.hu>, Yinghai Lu <yhlu.kernel@gmail.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [PATCH 0/3] bootmem2 III
Date: Sun, 11 May 2008 21:18:09 +0200	[thread overview]
Message-ID: <87lk2gtzta.fsf@saeurebad.de> (raw)
In-Reply-To: <20080509184044.GA19109@one.firstfloor.org> (Andi Kleen's message of "Fri, 9 May 2008 20:40:44 +0200")

Hi Andi,

Andi Kleen <andi@firstfloor.org> writes:

> On Fri, May 09, 2008 at 05:17:13PM +0200, Johannes Weiner wrote:
>> here is bootmem2, a memory block-oriented boot time allocator.
>> 
>> Recent NUMA topologies broke the current bootmem's assumption that
>> memory nodes provide non-overlapping and contiguous ranges of pages.
>
> I'm still not sure that's a really good rationale for bootmem2.
> e.g. the non continuous nodes are really special cases and there tends
> to be enough memory at the beginning which is enough for boot time
> use, so for those systems it would be quite reasonably to only 
> put the continuous starts of the nodes into bootmem.

Hm, that would put the logic into arch-code.  I have no strong opinion
about it.

> That said the bootmem code has gotten a little crufty and a clean
> rewrite might be a good idea.

I agree completely.

	Hannes

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2008-05-11 19:18 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-09 15:17 [PATCH 0/3] bootmem2 III Johannes Weiner
2008-05-09 15:17 ` Johannes Weiner
2008-05-09 15:17 ` [PATCH 1/3] mm: Make NR_NODE_MEMBLKS global Johannes Weiner
2008-05-09 15:17   ` Johannes Weiner
2008-05-09 15:17 ` [PATCH 2/3] mm: bootmem2 Johannes Weiner
2008-05-09 15:17   ` Johannes Weiner
2008-05-09 15:17 ` [PATCH 3/3] x86: Migrate X86_32 to bootmem2 Johannes Weiner
2008-05-09 15:17   ` Johannes Weiner
2008-05-09 18:40 ` [PATCH 0/3] bootmem2 III Andi Kleen
2008-05-09 18:40   ` Andi Kleen
2008-05-11 19:18   ` Johannes Weiner [this message]
2008-05-11 19:18     ` Johannes Weiner
2008-05-11 20:18     ` Andi Kleen
2008-05-11 20:18       ` Andi Kleen
2008-05-13 12:40       ` Johannes Weiner
2008-05-13 12:40         ` Johannes Weiner
2008-05-13 12:59         ` Andi Kleen
2008-05-13 12:59           ` Andi Kleen
2008-05-14 19:12           ` Johannes Weiner
2008-05-14 19:12             ` Johannes Weiner
2008-05-15 19:12         ` Andy Whitcroft
2008-05-15 19:12           ` Andy Whitcroft
2008-05-16 20:42           ` Johannes Weiner
2008-05-16 20:42             ` Johannes Weiner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87lk2gtzta.fsf@saeurebad.de \
    --to=hannes@saeurebad.de \
    --cc=akpm@linux-foundation.org \
    --cc=andi@firstfloor.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mingo@elte.hu \
    --cc=torvalds@linux-foundation.org \
    --cc=yhlu.kernel@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.