From: Philippe Gerum <rpm@xenomai.org>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: Xenomai <xenomai@lists.linux.dev>
Subject: Re: [dovetail][PATCH] clocksource/exynos_mct: irq_pipeline: set clockevent IRQs
Date: Wed, 18 Nov 2026 10:08:26 +0100 [thread overview]
Message-ID: <87mrr6ecc5.fsf@xenomai.org> (raw)
In-Reply-To: <5a8651c3-9f93-4ae2-b1b4-0fcbdc5a1501@siemens.com> (Jan Kiszka's message of "Tue, 17 Nov 2026 06:06:46 +0100")
Jan Kiszka <jan.kiszka@siemens.com> writes:
> From: Jan Kiszka <jan.kiszka@siemens.com>
>
> The MCT driver only fills clock_event_device::irq for the local timers
> in SPI mode. In PPI mode (samsung,exynos4412-mct), the per-CPU tick
> devices were left with IRQ 0, so the proxy tick device never switched
> the local timer interrupt to out-of-band mode, and the in-band tick ran
> on registers which were never saved, making every tick look like a
> user mode tick on ARM. The global comparator device had the same
> omission.
>
> Assisted-by: opencode:Opus-5.5
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> ---
> drivers/clocksource/exynos_mct.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/clocksource/exynos_mct.c b/drivers/clocksource/exynos_mct.c
> index 23d39bf9bdaf9..a548ac338f3bc 100644
> --- a/drivers/clocksource/exynos_mct.c
> +++ b/drivers/clocksource/exynos_mct.c
> @@ -350,6 +350,7 @@ static irqreturn_t exynos4_mct_comp_isr(int irq, void *dev_id)
> static int exynos4_clockevent_init(void)
> {
> mct_comp_device.cpumask = cpumask_of(0);
> + mct_comp_device.irq = mct_irqs[MCT_G0_IRQ];
> clockevents_config_and_register(&mct_comp_device, clk_rate,
> 0xf, 0xffffffff);
> if (request_irq(mct_irqs[MCT_G0_IRQ], exynos4_mct_comp_isr,
> @@ -487,6 +488,7 @@ static int exynos4_mct_starting_cpu(unsigned int cpu)
> irq_force_affinity(evt->irq, cpumask_of(cpu));
> enable_irq(evt->irq);
> } else {
> + evt->irq = mct_irqs[MCT_L0_IRQ];
> enable_percpu_irq(mct_irqs[MCT_L0_IRQ], 0);
> }
> clockevents_config_and_register(evt, clk_rate / (TICK_BASE_CNT + 1),
Merged, thanks.
--
Philippe.
prev parent reply other threads:[~2026-11-18 9:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-17 5:06 [dovetail][PATCH] clocksource/exynos_mct: irq_pipeline: set clockevent IRQs Jan Kiszka
2026-11-18 9:08 ` Philippe Gerum [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mrr6ecc5.fsf@xenomai.org \
--to=rpm@xenomai.org \
--cc=jan.kiszka@siemens.com \
--cc=xenomai@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.