From: Gregory CLEMENT <gregory.clement@bootlin.com>
To: Rosen Penev <rosenp@gmail.com>, devicetree@vger.kernel.org
Cc: Andrew Lunn <andrew@lunn.ch>,
Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Dennis Gilmore <dennis@ausil.us>,
"moderated list:ARM/Marvell Kirkwood and Armada 370, 375,
38x,..." <linux-arm-kernel@lists.infradead.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ARM: dts: armada-388-helios4: fix vmmc property name
Date: Fri, 28 Aug 2026 15:30:19 +0200 [thread overview]
Message-ID: <87mru6pe38.fsf@BLaptop.bootlin.com> (raw)
In-Reply-To: <20260824000521.80492-1-rosenp@gmail.com>
Rosen Penev <rosenp@gmail.com> writes:
> The sdhci@d8000 node references the 3.3V regulator through a bare
> "vmmc" property, which is not part of the mmc controller DT
> binding. The binding requires supply properties in the form
> "vmmc-supply", so the current entry is ignored by the driver.
>
> Rename the property to "vmmc-supply" so the fixed regulator is
> correctly wired up as the card power supply.
>
> Fixes: ced8025b569e ("ARM: dts: armada388-helios4")
> Assisted-by: opencode:big-pickle
> Signed-off-by: Rosen Penev <rosenp@gmail.com>
Applied on mvebu/dt
Thanks,
Gregory
> ---
> arch/arm/boot/dts/marvell/armada-388-helios4.dts | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/marvell/armada-388-helios4.dts b/arch/arm/boot/dts/marvell/armada-388-helios4.dts
> index 0b23d4da8276..092290da1f4a 100644
> --- a/arch/arm/boot/dts/marvell/armada-388-helios4.dts
> +++ b/arch/arm/boot/dts/marvell/armada-388-helios4.dts
> @@ -304,7 +304,7 @@ mmc@d8000 {
> &helios_sdhci_cd_pins>;
> pinctrl-names = "default";
> status = "okay";
> - vmmc = <®_3p3v>;
> + vmmc-supply = <®_3p3v>;
> wp-inverted;
> };
>
> --
> 2.55.0
>
--
Grégory CLEMENT, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
prev parent reply other threads:[~2026-08-28 13:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-24 0:05 [PATCH] ARM: dts: armada-388-helios4: fix vmmc property name Rosen Penev
2026-08-28 13:30 ` Gregory CLEMENT [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mru6pe38.fsf@BLaptop.bootlin.com \
--to=gregory.clement@bootlin.com \
--cc=andrew@lunn.ch \
--cc=conor+dt@kernel.org \
--cc=dennis@ausil.us \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=rosenp@gmail.com \
--cc=sebastian.hesselbarth@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.