* [PATCH] ARM: dts: armada-388-helios4: fix vmmc property name
@ 2026-08-24 0:05 Rosen Penev
2026-08-28 13:30 ` Gregory CLEMENT
0 siblings, 1 reply; 2+ messages in thread
From: Rosen Penev @ 2026-08-24 0:05 UTC (permalink / raw)
To: devicetree
Cc: Andrew Lunn, Gregory Clement, Sebastian Hesselbarth, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Dennis Gilmore,
moderated list:ARM/Marvell Kirkwood and Armada 370, 375, 38x,...,
open list
The sdhci@d8000 node references the 3.3V regulator through a bare
"vmmc" property, which is not part of the mmc controller DT
binding. The binding requires supply properties in the form
"vmmc-supply", so the current entry is ignored by the driver.
Rename the property to "vmmc-supply" so the fixed regulator is
correctly wired up as the card power supply.
Fixes: ced8025b569e ("ARM: dts: armada388-helios4")
Assisted-by: opencode:big-pickle
Signed-off-by: Rosen Penev <rosenp@gmail.com>
---
arch/arm/boot/dts/marvell/armada-388-helios4.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/marvell/armada-388-helios4.dts b/arch/arm/boot/dts/marvell/armada-388-helios4.dts
index 0b23d4da8276..092290da1f4a 100644
--- a/arch/arm/boot/dts/marvell/armada-388-helios4.dts
+++ b/arch/arm/boot/dts/marvell/armada-388-helios4.dts
@@ -304,7 +304,7 @@ mmc@d8000 {
&helios_sdhci_cd_pins>;
pinctrl-names = "default";
status = "okay";
- vmmc = <®_3p3v>;
+ vmmc-supply = <®_3p3v>;
wp-inverted;
};
--
2.55.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ARM: dts: armada-388-helios4: fix vmmc property name
2026-08-24 0:05 [PATCH] ARM: dts: armada-388-helios4: fix vmmc property name Rosen Penev
@ 2026-08-28 13:30 ` Gregory CLEMENT
0 siblings, 0 replies; 2+ messages in thread
From: Gregory CLEMENT @ 2026-08-28 13:30 UTC (permalink / raw)
To: Rosen Penev, devicetree
Cc: Andrew Lunn, Sebastian Hesselbarth, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Dennis Gilmore,
moderated list:ARM/Marvell Kirkwood and Armada 370, 375, 38x,...,
open list
Rosen Penev <rosenp@gmail.com> writes:
> The sdhci@d8000 node references the 3.3V regulator through a bare
> "vmmc" property, which is not part of the mmc controller DT
> binding. The binding requires supply properties in the form
> "vmmc-supply", so the current entry is ignored by the driver.
>
> Rename the property to "vmmc-supply" so the fixed regulator is
> correctly wired up as the card power supply.
>
> Fixes: ced8025b569e ("ARM: dts: armada388-helios4")
> Assisted-by: opencode:big-pickle
> Signed-off-by: Rosen Penev <rosenp@gmail.com>
Applied on mvebu/dt
Thanks,
Gregory
> ---
> arch/arm/boot/dts/marvell/armada-388-helios4.dts | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/marvell/armada-388-helios4.dts b/arch/arm/boot/dts/marvell/armada-388-helios4.dts
> index 0b23d4da8276..092290da1f4a 100644
> --- a/arch/arm/boot/dts/marvell/armada-388-helios4.dts
> +++ b/arch/arm/boot/dts/marvell/armada-388-helios4.dts
> @@ -304,7 +304,7 @@ mmc@d8000 {
> &helios_sdhci_cd_pins>;
> pinctrl-names = "default";
> status = "okay";
> - vmmc = <®_3p3v>;
> + vmmc-supply = <®_3p3v>;
> wp-inverted;
> };
>
> --
> 2.55.0
>
--
Grégory CLEMENT, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-08-28 13:30 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-08-24 0:05 [PATCH] ARM: dts: armada-388-helios4: fix vmmc property name Rosen Penev
2026-08-28 13:30 ` Gregory CLEMENT
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.