* [PATCH] tests/functional/qemu_test/testcase: Fix mismatched quotations
@ 2026-01-06 22:03 Yodel Eldar
2026-01-07 5:17 ` Thomas Huth
2026-01-07 9:25 ` Alex Bennée
0 siblings, 2 replies; 3+ messages in thread
From: Yodel Eldar @ 2026-01-06 22:03 UTC (permalink / raw)
To: qemu-devel
Cc: qemu-trivial, Thomas Huth, Philippe Mathieu-Daudé,
Daniel P. Berrangé, Yodel Eldar
A debug string incorrectly mixes single-quotes with double-quotes,
causing the variable within to be treated as a literal. Fix it.
Signed-off-by: Yodel Eldar <yodel.eldar@yodel.dev>
---
tests/functional/qemu_test/testcase.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/functional/qemu_test/testcase.py b/tests/functional/qemu_test/testcase.py
index 58f2740100..ff86c9d187 100644
--- a/tests/functional/qemu_test/testcase.py
+++ b/tests/functional/qemu_test/testcase.py
@@ -349,7 +349,7 @@ def require_netdev(self, netdevname):
helptxt = run([self.qemu_bin, '-M', 'none', '-netdev', 'help'],
capture_output=True, check=True, encoding='utf8').stdout
if helptxt.find('\n' + netdevname + '\n') < 0:
- self.skipTest('no support for " + netdevname + " networking')
+ self.skipTest('no support for ' + netdevname + ' networking')
def require_device(self, devicename):
helptxt = run([self.qemu_bin, '-M', 'none', '-device', 'help'],
--
2.52.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] tests/functional/qemu_test/testcase: Fix mismatched quotations
2026-01-06 22:03 [PATCH] tests/functional/qemu_test/testcase: Fix mismatched quotations Yodel Eldar
@ 2026-01-07 5:17 ` Thomas Huth
2026-01-07 9:25 ` Alex Bennée
1 sibling, 0 replies; 3+ messages in thread
From: Thomas Huth @ 2026-01-07 5:17 UTC (permalink / raw)
To: Yodel Eldar, qemu-devel
Cc: qemu-trivial, Philippe Mathieu-Daudé,
Daniel P. Berrangé
On 06/01/2026 23.03, Yodel Eldar wrote:
> A debug string incorrectly mixes single-quotes with double-quotes,
> causing the variable within to be treated as a literal. Fix it.
>
> Signed-off-by: Yodel Eldar <yodel.eldar@yodel.dev>
> ---
> tests/functional/qemu_test/testcase.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/functional/qemu_test/testcase.py b/tests/functional/qemu_test/testcase.py
> index 58f2740100..ff86c9d187 100644
> --- a/tests/functional/qemu_test/testcase.py
> +++ b/tests/functional/qemu_test/testcase.py
> @@ -349,7 +349,7 @@ def require_netdev(self, netdevname):
> helptxt = run([self.qemu_bin, '-M', 'none', '-netdev', 'help'],
> capture_output=True, check=True, encoding='utf8').stdout
> if helptxt.find('\n' + netdevname + '\n') < 0:
> - self.skipTest('no support for " + netdevname + " networking')
> + self.skipTest('no support for ' + netdevname + ' networking')
Ooops, good catch!
Reviewed-by: Thomas Huth <thuth@redhat.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] tests/functional/qemu_test/testcase: Fix mismatched quotations
2026-01-06 22:03 [PATCH] tests/functional/qemu_test/testcase: Fix mismatched quotations Yodel Eldar
2026-01-07 5:17 ` Thomas Huth
@ 2026-01-07 9:25 ` Alex Bennée
1 sibling, 0 replies; 3+ messages in thread
From: Alex Bennée @ 2026-01-07 9:25 UTC (permalink / raw)
To: Yodel Eldar
Cc: qemu-devel, qemu-trivial, Thomas Huth,
Philippe Mathieu-Daudé, Daniel P. Berrangé
Yodel Eldar <yodel.eldar@yodel.dev> writes:
> A debug string incorrectly mixes single-quotes with double-quotes,
> causing the variable within to be treated as a literal. Fix it.
>
> Signed-off-by: Yodel Eldar <yodel.eldar@yodel.dev>
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
> ---
> tests/functional/qemu_test/testcase.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/functional/qemu_test/testcase.py b/tests/functional/qemu_test/testcase.py
> index 58f2740100..ff86c9d187 100644
> --- a/tests/functional/qemu_test/testcase.py
> +++ b/tests/functional/qemu_test/testcase.py
> @@ -349,7 +349,7 @@ def require_netdev(self, netdevname):
> helptxt = run([self.qemu_bin, '-M', 'none', '-netdev', 'help'],
> capture_output=True, check=True, encoding='utf8').stdout
> if helptxt.find('\n' + netdevname + '\n') < 0:
> - self.skipTest('no support for " + netdevname + " networking')
> + self.skipTest('no support for ' + netdevname + ' networking')
>
> def require_device(self, devicename):
> helptxt = run([self.qemu_bin, '-M', 'none', '-device', 'help'],
--
Alex Bennée
Virtualisation Tech Lead @ Linaro
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-01-07 9:26 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-01-06 22:03 [PATCH] tests/functional/qemu_test/testcase: Fix mismatched quotations Yodel Eldar
2026-01-07 5:17 ` Thomas Huth
2026-01-07 9:25 ` Alex Bennée
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.