Re: qos-test is annoyingly noisy

[Markus Armbruster <armbru@redhat.com>]

Paolo Bonzini <pbonzini@redhat.com> writes:

> On 7/23/25 16:28, Markus Armbruster wrote:
>> Noise starting with "stdout: " has been polluting output of "make check"
>> for a while.  I traced it to qos-test.  Output of "make
>> check-qtest-aarch64" appended as an example.
>> Blessed silence if I revert commit 30ea13e9d97d (tests/qtest: use
>> qos_printf instead of g_test_message).
>> Alex, what shall we do here?
>
> What is printing "stdout:", is it glib?  I think glib should be using g_test_message() to do those "stdout:" prints.

I doubt it's glib.  When I run the test directly, like

    $ QTEST_QEMU_BINARY=./qemu-system-aarch64 QTEST_QEMU_IMG=./qemu-img time /work/armbru/qemu/bld/tests/qtest/qos-test

I see the offending lines without "stdout:"

    # Start of vhost-user tests
    qemu-system-aarch64: Failed to set msg fds.
    qemu-system-aarch64: vhost VQ 0 ring restore failed: -22: Invalid argument (22)
    qemu-system-aarch64: Failed to set msg fds.
    qemu-system-aarch64: vhost VQ 1 ring restore failed: -22: Invalid argument (22)
        # # qos_test running single test in subprocess
        # # set_protocol_features: 0x42
        # # set_owner: start of session
        # # vhost-user: un-handled message: 14
        # # vhost-user: un-handled message: 14
        # # set_vring(0)=enabled
        # # set_vring(1)=enabled
        # # set_vring(0)=enabled
        # # set_vring(1)=enabled
        # # set_vring(0)=enabled
        # # set_vring(1)=enabled
        # # set_vring(0)=enabled
        # # set_vring(1)=enabled
        # # set_vring(0)=enabled
        # # set_vring(1)=enabled
        # # set_vring_num: 0/256
        # # set_vring_addr: 0x7f7fcc000000/0x7f7fcbfff000/0x7f7fcc001000
        # # set_vring_num: 1/256
    ok 28 /aarch64/virt/generic-pcihost/pci-bus-generic/pci-bus/virtio-net-pci/virtio-net/virtio-net-tests/vhost-user/migrate

I believe the prefix "stdout: <number>: UNKNOWN: " comes from the test
harness.

> But I agree a more practical alternative is a revert.

I'll post one.