Re: qos-test is annoyingly noisy

["Daniel P. Berrangé" <berrange@redhat.com>]

On Wed, Jul 23, 2025 at 06:38:45PM +0200, Paolo Bonzini wrote:
> On 7/23/25 16:28, Markus Armbruster wrote:
> > Noise starting with "stdout: " has been polluting output of "make check"
> > for a while.  I traced it to qos-test.  Output of "make
> > check-qtest-aarch64" appended as an example.
> > 
> > Blessed silence if I revert commit 30ea13e9d97d (tests/qtest: use
> > qos_printf instead of g_test_message).
> > 
> > Alex, what shall we do here?
> 
> What is printing "stdout:", is it glib?  I think glib should be using
> g_test_message() to do those "stdout:" prints. But I agree a more practical
> alternative is a revert.

AFAICT, this is a bug in meson.

The test in question is running in a subprocess, and glib uses
nested TAP plans for the subprocess. These messages are all
TAP diagnositic lines from the nested plan, and meson is
incorrectly complaining about them.

> > 
> > stdout: 138: UNKNOWN:     # # qos_test running single test in subprocess

IIUC, the original text from glib nested plan was

  "     # # qos_test running single test in subprocess"

and meson adds the 'stdout: 128: UNKNOWN: ' prefix


> > Unknown TAP output lines have been ignored. Please open a feature request to
> > implement them, or prefix them with a # if they are not TAP syntax.

...they were already prefixed with '#', they just had some
whitespace before the '#' due to the nested plans.


With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|