[PATCH] kernel/entry: Fix misleading comment in irqentry_enter()

[PATCH] kernel/entry: Fix misleading comment in irqentry_enter()

[Khalid Ali]

Change irqentry_enter_from_user_mode() to enter_from_user_mode(),
because enter_from_user_mode() function is the one doing the action 
comment indicates.

Signed-off-by: Khalid Ali <khaliidcaliy@gmail.com>
---
 kernel/entry/common.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/entry/common.c b/kernel/entry/common.c
index a8dd1f27417c..f49e3440204d 100644
--- a/kernel/entry/common.c
+++ b/kernel/entry/common.c
@@ -224,7 +224,7 @@ noinstr irqentry_state_t irqentry_enter(struct pt_regs *regs)
 		/*
 		 * If RCU is not watching then the same careful
 		 * sequence vs. lockdep and tracing is required
-		 * as in irqentry_enter_from_user_mode().
+		 * as in enter_from_user_mode().
 		 */
 		lockdep_hardirqs_off(CALLER_ADDR0);
 		ct_irq_enter();
-- 
2.49.0

Re: [PATCH] kernel/entry: Fix misleading comment in irqentry_enter()

[Thomas Gleixner]

On Sat, Jun 14 2025 at 19:26, Khalid Ali wrote:
> Change irqentry_enter_from_user_mode() to enter_from_user_mode(),
> because enter_from_user_mode() function is the one doing the action 
> comment indicates.

irqentry_enter_from_user_mode() is what is called in the user entry
branch, so the comment is not misleading at all. If someone can't follow
that function and figure out that it calls enter_from_user_mode() so be
it.

Thanks,

        tglx