All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mattijs Korpershoek <mkorpershoek@kernel.org>
To: Simon Glass <sjg@chromium.org>,
	U-Boot Mailing List <u-boot@lists.denx.de>
Cc: Simon Glass <sjg@chromium.org>,
	Heinrich Schuchardt <xypron.glpk@gmx.de>,
	Jerome Forissier <jerome.forissier@linaro.org>,
	Mattijs Korpershoek <mkorpershoek@kernel.org>,
	Stephen Warren <swarren@nvidia.com>,
	Stephen Warren <swarren@wwwdotorg.org>,
	Tom Rini <trini@konsulko.com>
Subject: Re: [PATCH 2/2] test/py: Correct handling of exceptions
Date: Fri, 30 May 2025 09:10:23 +0200	[thread overview]
Message-ID: <87msaupo9s.fsf@kernel.org> (raw)
In-Reply-To: <20250529141500.2123363-2-sjg@chromium.org>

Hi Simon,

Thank you for the patch.

On jeu., mai 29, 2025 at 08:14, Simon Glass <sjg@chromium.org> wrote:

> If an Unexpected exception is thrown in a test, an undefined variable
> error is reported. Fix this.
>
> Signed-off-by: Simon Glass <sjg@chromium.org>
> Fixes: 85d7dae377a ("test: Detect dead connections")

Reviewed-by: Mattijs Korpershoek <mkorpershoek@kernel.org>

> ---
>
>  test/py/conftest.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/test/py/conftest.py b/test/py/conftest.py
> index eec0b5488e4..8ce680a92a0 100644
> --- a/test/py/conftest.py
> +++ b/test/py/conftest.py
> @@ -515,7 +515,7 @@ def ubman(request):
>      except BootFail as err:
>          handle_exception(ubconfig, ubman_fix, log, err, 'Boot fail', True,
>                           ubman_fix.get_spawn_output())
> -    except Unexpected:
> +    except Unexpected as err:
>          handle_exception(ubconfig, ubman_fix, log, err, 'Unexpected test output',
>                           False)
>      return ubman_fix
> -- 
> 2.43.0
>
> base-commit: 2f3766949bbea7aa5a472157561d387fd94205d2
> branch: py-fix

  reply	other threads:[~2025-05-30  7:10 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-29 14:14 [PATCH 1/2] test/py: Use the correct fixture name in exception handler Simon Glass
2025-05-29 14:14 ` [PATCH 2/2] test/py: Correct handling of exceptions Simon Glass
2025-05-30  7:10   ` Mattijs Korpershoek [this message]
2025-05-30  7:09 ` [PATCH 1/2] test/py: Use the correct fixture name in exception handler Mattijs Korpershoek
2025-06-12 19:17 ` Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87msaupo9s.fsf@kernel.org \
    --to=mkorpershoek@kernel.org \
    --cc=jerome.forissier@linaro.org \
    --cc=sjg@chromium.org \
    --cc=swarren@nvidia.com \
    --cc=swarren@wwwdotorg.org \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    --cc=xypron.glpk@gmx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.