Re: [PATCH 1/2] test/py: Use the correct fixture name in exception handler

[Mattijs Korpershoek <mkorpershoek@kernel.org>]

Hi Simon,

Thank you for the patch.

On jeu., mai 29, 2025 at 08:14, Simon Glass <sjg@chromium.org> wrote:

> If a BootFail exception is thrown in a test, it is not handled
> correctly. Use the correct fixture variable 'ubman_fix' to resolve this.
>
> Signed-off-by: Simon Glass <sjg@chromium.org>
> Fixes: d9ed4b75add ("test/py: Drop u_boot_ prefix on test files")

Reviewed-by: Mattijs Korpershoek <mkorpershoek@kernel.org>

> ---
>
>  test/py/conftest.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/test/py/conftest.py b/test/py/conftest.py
> index 6c3ac67979a..eec0b5488e4 100644
> --- a/test/py/conftest.py
> +++ b/test/py/conftest.py
> @@ -514,7 +514,7 @@ def ubman(request):
>          handle_exception(ubconfig, ubman_fix, log, err, 'Lab timeout', True)
>      except BootFail as err:
>          handle_exception(ubconfig, ubman_fix, log, err, 'Boot fail', True,
> -                         ubman.get_spawn_output())
> +                         ubman_fix.get_spawn_output())
>      except Unexpected:
>          handle_exception(ubconfig, ubman_fix, log, err, 'Unexpected test output',
>                           False)
> -- 
> 2.43.0
>
> base-commit: 2f3766949bbea7aa5a472157561d387fd94205d2
> branch: py-fix