All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Toke Høiland-Jørgensen" <toke@redhat.com>
To: Tony Nguyen <anthony.l.nguyen@intel.com>,
	Jacob Keller <jacob.e.keller@intel.com>,
	Maciej Fijalkowski <maciej.fijalkowski@intel.com>,
	Chandan Kumar Rout <chandanx.rout@intel.com>
Cc: Yue Haibing <yuehaibing@huawei.com>,
	Simon Horman <horms@kernel.org>,
	Samuel Dobron <sdobron@redhat.com>,
	netdev@vger.kernel.org, intel-wired-lan@lists.osuosl.org
Subject: [Intel-wired-lan] [ixgbe] Crash when running an XDP program
Date: Wed, 12 Feb 2025 13:33:09 +0100	[thread overview]
Message-ID: <87mserpcl6.fsf@toke.dk> (raw)

Hi folks,

Our LNST testing team uncovered a crash in ixgbe when running an XDP
program, see this report:
https://bugzilla.redhat.com/show_bug.cgi?id=2343204

From looking at the code, it seems to me that the culprit is this commit:

c824125cbb18 ("ixgbe: Fix passing 0 to ERR_PTR in ixgbe_run_xdp()")

after that commit, the IS_ERR(skb) check in ixgbe_put_rx_buffer() no
longer triggers, and that function tries to dereference a NULL skb
pointer after an XDP program dropped the frame.

Could you please fix this?

And, erm, given the number of reviewed-by and tested-by tags in the
commit above, I'm guessing you don't have any XDP tests in your testing
regimen? Any chance you could add that? :)

Thanks!

-Toke


WARNING: multiple messages have this Message-ID (diff)
From: "Toke Høiland-Jørgensen" <toke@redhat.com>
To: Tony Nguyen <anthony.l.nguyen@intel.com>,
	Jacob Keller <jacob.e.keller@intel.com>,
	Maciej Fijalkowski <maciej.fijalkowski@intel.com>,
	Chandan Kumar Rout <chandanx.rout@intel.com>
Cc: Yue Haibing <yuehaibing@huawei.com>,
	Simon Horman <horms@kernel.org>,
	Samuel Dobron <sdobron@redhat.com>,
	netdev@vger.kernel.org, intel-wired-lan@lists.osuosl.org
Subject: [ixgbe] Crash when running an XDP program
Date: Wed, 12 Feb 2025 13:33:09 +0100	[thread overview]
Message-ID: <87mserpcl6.fsf@toke.dk> (raw)

Hi folks,

Our LNST testing team uncovered a crash in ixgbe when running an XDP
program, see this report:
https://bugzilla.redhat.com/show_bug.cgi?id=2343204

From looking at the code, it seems to me that the culprit is this commit:

c824125cbb18 ("ixgbe: Fix passing 0 to ERR_PTR in ixgbe_run_xdp()")

after that commit, the IS_ERR(skb) check in ixgbe_put_rx_buffer() no
longer triggers, and that function tries to dereference a NULL skb
pointer after an XDP program dropped the frame.

Could you please fix this?

And, erm, given the number of reviewed-by and tested-by tags in the
commit above, I'm guessing you don't have any XDP tests in your testing
regimen? Any chance you could add that? :)

Thanks!

-Toke


             reply	other threads:[~2025-02-12 12:33 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-12 12:33 Toke Høiland-Jørgensen [this message]
2025-02-12 12:33 ` [ixgbe] Crash when running an XDP program Toke Høiland-Jørgensen
2025-02-12 12:39 ` [Intel-wired-lan] " Maciej Fijalkowski
2025-02-12 12:39   ` Maciej Fijalkowski
2025-02-12 13:03   ` [Intel-wired-lan] " Toke Høiland-Jørgensen
2025-02-12 13:03     ` Toke Høiland-Jørgensen
2025-02-20  8:14     ` [Intel-wired-lan] " Samuel Dobron
2025-02-20  8:14       ` Samuel Dobron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87mserpcl6.fsf@toke.dk \
    --to=toke@redhat.com \
    --cc=anthony.l.nguyen@intel.com \
    --cc=chandanx.rout@intel.com \
    --cc=horms@kernel.org \
    --cc=intel-wired-lan@lists.osuosl.org \
    --cc=jacob.e.keller@intel.com \
    --cc=maciej.fijalkowski@intel.com \
    --cc=netdev@vger.kernel.org \
    --cc=sdobron@redhat.com \
    --cc=yuehaibing@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.