All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: Vincent Chen <vincent.chen@sifive.com>, anup@brainfault.org
Cc: paul.walmsley@sifive.com, palmer@dabbelt.com,
	aou@eecs.berkeley.edu, linux-kernel@vger.kernel.org,
	linux-riscv@lists.infradead.org, vincent.chen@sifive.com
Subject: Re: [PATCH] irqchip: let the probe of APLIC be earlier than IMSIC
Date: Fri, 02 Aug 2024 12:55:00 +0200	[thread overview]
Message-ID: <87mslv19ff.ffs@tglx> (raw)
In-Reply-To: <20240802075741.316968-1-vincent.chen@sifive.com>

On Fri, Aug 02 2024 at 15:57, Vincent Chen wrote:
> When the debug message of driver/base/dd.c is enabled, the following
> error messages are present in the boot log:
>
> [    0.207941] platform d000000.aplic: error -EPROBE_DEFER: supplier
> 28000000.imsics not ready
> [    0.208115] platform d000000.aplic: Added to deferred list

Deferred probing is not an error.

> The reason for this error message is that the probe of APLIC is executed
> earlier than IMSIC. This error also causes all the platform devices
> connected to the APLIC to be added to the deferred list. Because both
> APLIC and IMSIC are registered by device_initcall, this patch adjusts the
> compile order of APLIC and IMSIC to ensure that the probe of IMSIC is
> executed earlier than the probe of APLIC.

And no we are not playing silly ordering games just to suppress a debug
output.

Thanks,

        tglx

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

WARNING: multiple messages have this Message-ID (diff)
From: Thomas Gleixner <tglx@linutronix.de>
To: Vincent Chen <vincent.chen@sifive.com>, anup@brainfault.org
Cc: paul.walmsley@sifive.com, palmer@dabbelt.com,
	aou@eecs.berkeley.edu, linux-kernel@vger.kernel.org,
	linux-riscv@lists.infradead.org, vincent.chen@sifive.com
Subject: Re: [PATCH] irqchip: let the probe of APLIC be earlier than IMSIC
Date: Fri, 02 Aug 2024 12:55:00 +0200	[thread overview]
Message-ID: <87mslv19ff.ffs@tglx> (raw)
In-Reply-To: <20240802075741.316968-1-vincent.chen@sifive.com>

On Fri, Aug 02 2024 at 15:57, Vincent Chen wrote:
> When the debug message of driver/base/dd.c is enabled, the following
> error messages are present in the boot log:
>
> [    0.207941] platform d000000.aplic: error -EPROBE_DEFER: supplier
> 28000000.imsics not ready
> [    0.208115] platform d000000.aplic: Added to deferred list

Deferred probing is not an error.

> The reason for this error message is that the probe of APLIC is executed
> earlier than IMSIC. This error also causes all the platform devices
> connected to the APLIC to be added to the deferred list. Because both
> APLIC and IMSIC are registered by device_initcall, this patch adjusts the
> compile order of APLIC and IMSIC to ensure that the probe of IMSIC is
> executed earlier than the probe of APLIC.

And no we are not playing silly ordering games just to suppress a debug
output.

Thanks,

        tglx

  reply	other threads:[~2024-08-02 10:55 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-02  7:57 [PATCH] irqchip: let the probe of APLIC be earlier than IMSIC Vincent Chen
2024-08-02  7:57 ` Vincent Chen
2024-08-02 10:55 ` Thomas Gleixner [this message]
2024-08-02 10:55   ` Thomas Gleixner
2024-08-02 11:02 ` Anup Patel
2024-08-02 11:02   ` Anup Patel
2024-08-05  2:43   ` Vincent Chen
2024-08-05  2:43     ` Vincent Chen
2024-08-05  8:08     ` Thomas Gleixner
2024-08-05  8:08       ` Thomas Gleixner
2024-08-06  1:56       ` Vincent Chen
2024-08-06  1:56         ` Vincent Chen
2024-08-06  3:14         ` Jessica Clarke
2024-08-06  3:14           ` Jessica Clarke

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87mslv19ff.ffs@tglx \
    --to=tglx@linutronix.de \
    --cc=anup@brainfault.org \
    --cc=aou@eecs.berkeley.edu \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=palmer@dabbelt.com \
    --cc=paul.walmsley@sifive.com \
    --cc=vincent.chen@sifive.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.