* [PATCH] wifi: ath12k: call ath12k_mac_fils_discovery() without condition
@ 2023-10-11 7:29 ` Ma Ke
0 siblings, 0 replies; 7+ messages in thread
From: Ma Ke @ 2023-10-11 7:29 UTC (permalink / raw)
To: kvalo, quic_jjohnson; +Cc: ath12k, linux-wireless, linux-kernel, Ma Ke
Mac80211 does not set flags BSS_CHANGED_FILS_DISCOVERY and
BSS_CHANGED_UNSOL_BCAST_PROBE_RESP if there are no updates to
FILS discovery and unsolicited broadcast probe response transmission
configurations respectively. This results in the transmissions getting
stopped during BSS change operations which do not include these
attributes. Remove the checks for the flags and always send the existing
configuration to firmware.
Signed-off-by: Ma Ke <make_ruc2021@163.com>
---
drivers/net/wireless/ath/ath12k/mac.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/net/wireless/ath/ath12k/mac.c b/drivers/net/wireless/ath/ath12k/mac.c
index 88346e66bb75..94967f810093 100644
--- a/drivers/net/wireless/ath/ath12k/mac.c
+++ b/drivers/net/wireless/ath/ath12k/mac.c
@@ -2761,9 +2761,7 @@ static void ath12k_mac_op_bss_info_changed(struct ieee80211_hw *hw,
}
}
- if (changed & BSS_CHANGED_FILS_DISCOVERY ||
- changed & BSS_CHANGED_UNSOL_BCAST_PROBE_RESP)
- ath12k_mac_fils_discovery(arvif, info);
+ ath12k_mac_fils_discovery(arvif, info);
if (changed & BSS_CHANGED_EHT_PUNCTURING)
arvif->punct_bitmap = info->eht_puncturing;
--
2.37.2
--
ath12k mailing list
ath12k@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/ath12k
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH] wifi: ath12k: call ath12k_mac_fils_discovery() without condition
@ 2023-10-11 7:29 ` Ma Ke
0 siblings, 0 replies; 7+ messages in thread
From: Ma Ke @ 2023-10-11 7:29 UTC (permalink / raw)
To: kvalo, quic_jjohnson; +Cc: ath12k, linux-wireless, linux-kernel, Ma Ke
Mac80211 does not set flags BSS_CHANGED_FILS_DISCOVERY and
BSS_CHANGED_UNSOL_BCAST_PROBE_RESP if there are no updates to
FILS discovery and unsolicited broadcast probe response transmission
configurations respectively. This results in the transmissions getting
stopped during BSS change operations which do not include these
attributes. Remove the checks for the flags and always send the existing
configuration to firmware.
Signed-off-by: Ma Ke <make_ruc2021@163.com>
---
drivers/net/wireless/ath/ath12k/mac.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/net/wireless/ath/ath12k/mac.c b/drivers/net/wireless/ath/ath12k/mac.c
index 88346e66bb75..94967f810093 100644
--- a/drivers/net/wireless/ath/ath12k/mac.c
+++ b/drivers/net/wireless/ath/ath12k/mac.c
@@ -2761,9 +2761,7 @@ static void ath12k_mac_op_bss_info_changed(struct ieee80211_hw *hw,
}
}
- if (changed & BSS_CHANGED_FILS_DISCOVERY ||
- changed & BSS_CHANGED_UNSOL_BCAST_PROBE_RESP)
- ath12k_mac_fils_discovery(arvif, info);
+ ath12k_mac_fils_discovery(arvif, info);
if (changed & BSS_CHANGED_EHT_PUNCTURING)
arvif->punct_bitmap = info->eht_puncturing;
--
2.37.2
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH] wifi: ath12k: call ath12k_mac_fils_discovery() without condition
2023-10-11 7:29 ` Ma Ke
@ 2023-10-11 8:55 ` Kalle Valo
-1 siblings, 0 replies; 7+ messages in thread
From: Kalle Valo @ 2023-10-11 8:55 UTC (permalink / raw)
To: Ma Ke; +Cc: quic_jjohnson, ath12k, linux-wireless, linux-kernel
Ma Ke <make_ruc2021@163.com> writes:
> Mac80211 does not set flags BSS_CHANGED_FILS_DISCOVERY and
> BSS_CHANGED_UNSOL_BCAST_PROBE_RESP if there are no updates to
> FILS discovery and unsolicited broadcast probe response transmission
> configurations respectively. This results in the transmissions getting
> stopped during BSS change operations which do not include these
> attributes. Remove the checks for the flags and always send the existing
> configuration to firmware.
>
> Signed-off-by: Ma Ke <make_ruc2021@163.com>
This looks almost identical to Aloka's patch:
wifi: ath12k: call ath12k_mac_fils_discovery() without condition
https://git.kernel.org/netdev/net-next/c/43a10990404f
What's happening here?
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
--
ath12k mailing list
ath12k@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/ath12k
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH] wifi: ath12k: call ath12k_mac_fils_discovery() without condition
@ 2023-09-05 17:43 Aloka Dixit
2023-09-05 20:11 ` Jeff Johnson
2023-09-28 15:10 ` Kalle Valo
0 siblings, 2 replies; 7+ messages in thread
From: Aloka Dixit @ 2023-09-05 17:43 UTC (permalink / raw)
To: ath12k; +Cc: linux-wireless, Aloka Dixit
Mac80211 does not set flags BSS_CHANGED_FILS_DISCOVERY and
BSS_CHANGED_UNSOL_BCAST_PROBE_RESP if there are no updates to
FILS discovery and unsolicited broadcast probe response transmission
configurations respectively. For BSS change operations such as channel
switch, this results in the transmissions getting stopped because the
driver does not send WMI command to firmware if the flags are not set.
Remove the checks for the flags to always send the existing
configuration to firmware.
Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.0.1-00029-QCAHKSWPL_SILICONZ-1
Signed-off-by: Aloka Dixit <quic_alokad@quicinc.com>
---
drivers/net/wireless/ath/ath12k/mac.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/net/wireless/ath/ath12k/mac.c b/drivers/net/wireless/ath/ath12k/mac.c
index 88346e66bb75..94967f810093 100644
--- a/drivers/net/wireless/ath/ath12k/mac.c
+++ b/drivers/net/wireless/ath/ath12k/mac.c
@@ -2761,9 +2761,7 @@ static void ath12k_mac_op_bss_info_changed(struct ieee80211_hw *hw,
}
}
- if (changed & BSS_CHANGED_FILS_DISCOVERY ||
- changed & BSS_CHANGED_UNSOL_BCAST_PROBE_RESP)
- ath12k_mac_fils_discovery(arvif, info);
+ ath12k_mac_fils_discovery(arvif, info);
if (changed & BSS_CHANGED_EHT_PUNCTURING)
arvif->punct_bitmap = info->eht_puncturing;
base-commit: 0263687f4441d5a5eab8074d56b4693c8f0acf85
--
2.39.0
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH] wifi: ath12k: call ath12k_mac_fils_discovery() without condition
2023-09-05 17:43 Aloka Dixit
@ 2023-09-05 20:11 ` Jeff Johnson
2023-09-28 15:10 ` Kalle Valo
1 sibling, 0 replies; 7+ messages in thread
From: Jeff Johnson @ 2023-09-05 20:11 UTC (permalink / raw)
To: Aloka Dixit, ath12k; +Cc: linux-wireless
On 9/5/2023 10:43 AM, Aloka Dixit wrote:
> Mac80211 does not set flags BSS_CHANGED_FILS_DISCOVERY and
> BSS_CHANGED_UNSOL_BCAST_PROBE_RESP if there are no updates to
> FILS discovery and unsolicited broadcast probe response transmission
> configurations respectively. For BSS change operations such as channel
> switch, this results in the transmissions getting stopped because the
> driver does not send WMI command to firmware if the flags are not set.
> Remove the checks for the flags to always send the existing
> configuration to firmware.
>
> Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.0.1-00029-QCAHKSWPL_SILICONZ-1
>
> Signed-off-by: Aloka Dixit <quic_alokad@quicinc.com>
Acked-by: Jeff Johnson <quic_jjohnson@quicinc.com>
> ---
> drivers/net/wireless/ath/ath12k/mac.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/net/wireless/ath/ath12k/mac.c b/drivers/net/wireless/ath/ath12k/mac.c
> index 88346e66bb75..94967f810093 100644
> --- a/drivers/net/wireless/ath/ath12k/mac.c
> +++ b/drivers/net/wireless/ath/ath12k/mac.c
> @@ -2761,9 +2761,7 @@ static void ath12k_mac_op_bss_info_changed(struct ieee80211_hw *hw,
> }
> }
>
> - if (changed & BSS_CHANGED_FILS_DISCOVERY ||
> - changed & BSS_CHANGED_UNSOL_BCAST_PROBE_RESP)
> - ath12k_mac_fils_discovery(arvif, info);
> + ath12k_mac_fils_discovery(arvif, info);
>
> if (changed & BSS_CHANGED_EHT_PUNCTURING)
> arvif->punct_bitmap = info->eht_puncturing;
>
> base-commit: 0263687f4441d5a5eab8074d56b4693c8f0acf85
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] wifi: ath12k: call ath12k_mac_fils_discovery() without condition
2023-09-05 17:43 Aloka Dixit
2023-09-05 20:11 ` Jeff Johnson
@ 2023-09-28 15:10 ` Kalle Valo
1 sibling, 0 replies; 7+ messages in thread
From: Kalle Valo @ 2023-09-28 15:10 UTC (permalink / raw)
To: Aloka Dixit; +Cc: ath12k, linux-wireless, Aloka Dixit
Aloka Dixit <quic_alokad@quicinc.com> wrote:
> Mac80211 does not set flags BSS_CHANGED_FILS_DISCOVERY and
> BSS_CHANGED_UNSOL_BCAST_PROBE_RESP if there are no updates to
> FILS discovery and unsolicited broadcast probe response transmission
> configurations respectively. For BSS change operations such as channel
> switch, this results in the transmissions getting stopped because the
> driver does not send WMI command to firmware if the flags are not set.
> Remove the checks for the flags to always send the existing
> configuration to firmware.
>
> Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.0.1-00029-QCAHKSWPL_SILICONZ-1
>
> Signed-off-by: Aloka Dixit <quic_alokad@quicinc.com>
> Acked-by: Jeff Johnson <quic_jjohnson@quicinc.com>
> Signed-off-by: Kalle Valo <quic_kvalo@quicinc.com>
Patch applied to ath-next branch of ath.git, thanks.
43a10990404f wifi: ath12k: call ath12k_mac_fils_discovery() without condition
--
https://patchwork.kernel.org/project/linux-wireless/patch/20230905174324.25296-1-quic_alokad@quicinc.com/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2023-10-11 8:55 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-10-11 7:29 [PATCH] wifi: ath12k: call ath12k_mac_fils_discovery() without condition Ma Ke
2023-10-11 7:29 ` Ma Ke
2023-10-11 8:55 ` Kalle Valo
2023-10-11 8:55 ` Kalle Valo
-- strict thread matches above, loose matches on Subject: below --
2023-09-05 17:43 Aloka Dixit
2023-09-05 20:11 ` Jeff Johnson
2023-09-28 15:10 ` Kalle Valo
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.