All of lore.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Ruan Jinjie <ruanjinjie@huawei.com>
Cc: <perex@perex.cz>, <tiwai@suse.com>, <claudiu.beznea@tuxon.dev>,
	<lgirdwood@gmail.com>, <broonie@kernel.org>,
	<nicolas.ferre@microchip.com>, <alexandre.belloni@bootlin.com>,
	<peda@axentia.se>, <lars@metafoo.de>, <nuno.sa@analog.com>,
	<povik+lin@cutebit.org>, <wens@csie.org>,
	<jernej.skrabec@gmail.com>, <samuel@sholland.org>,
	<robh@kernel.org>, <u.kleine-koenig@pengutronix.de>,
	<alsa-devel@alsa-project.org>,
	<linux-arm-kernel@lists.infradead.org>, <asahi@lists.linux.dev>,
	<linux-sunxi@lists.linux.dev>
Subject: Re: [PATCH -next 5/5] ALSA: Remove redundant of_match_ptr()
Date: Fri, 11 Aug 2023 09:49:58 +0200	[thread overview]
Message-ID: <87msyyrpax.wl-tiwai@suse.de> (raw)
In-Reply-To: <20230811071426.2343133-6-ruanjinjie@huawei.com>

On Fri, 11 Aug 2023 09:14:26 +0200,
Ruan Jinjie wrote:
> 
> The driver depends on CONFIG_OF, it is not necessary to use
> of_match_ptr() here.
> 
> Signed-off-by: Ruan Jinjie <ruanjinjie@huawei.com>

Reviewed-by: Takashi Iwai <tiwai@suse.de>


thanks,

Takashi

> ---
>  sound/drivers/serial-generic.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/sound/drivers/serial-generic.c b/sound/drivers/serial-generic.c
> index b0262541802a..c8db6c75d133 100644
> --- a/sound/drivers/serial-generic.c
> +++ b/sound/drivers/serial-generic.c
> @@ -366,7 +366,7 @@ MODULE_DEVICE_TABLE(of, snd_serial_generic_dt_ids);
>  static struct serdev_device_driver snd_serial_generic_driver = {
>  	.driver	= {
>  		.name		= "snd-serial-generic",
> -		.of_match_table	= of_match_ptr(snd_serial_generic_dt_ids),
> +		.of_match_table	= snd_serial_generic_dt_ids,
>  	},
>  	.probe	= snd_serial_generic_probe,
>  };
> -- 
> 2.34.1
> 

WARNING: multiple messages have this Message-ID (diff)
From: Takashi Iwai <tiwai@suse.de>
To: Ruan Jinjie <ruanjinjie@huawei.com>
Cc: robh@kernel.org, alexandre.belloni@bootlin.com, lars@metafoo.de,
	alsa-devel@alsa-project.org, samuel@sholland.org,
	lgirdwood@gmail.com, jernej.skrabec@gmail.com,
	claudiu.beznea@tuxon.dev, nuno.sa@analog.com, wens@csie.org,
	broonie@kernel.org, asahi@lists.linux.dev,
	u.kleine-koenig@pengutronix.de, povik+lin@cutebit.org,
	tiwai@suse.com, perex@perex.cz, linux-sunxi@lists.linux.dev,
	peda@axentia.se, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH -next 5/5] ALSA: Remove redundant of_match_ptr()
Date: Fri, 11 Aug 2023 09:49:58 +0200	[thread overview]
Message-ID: <87msyyrpax.wl-tiwai@suse.de> (raw)
In-Reply-To: <20230811071426.2343133-6-ruanjinjie@huawei.com>

On Fri, 11 Aug 2023 09:14:26 +0200,
Ruan Jinjie wrote:
> 
> The driver depends on CONFIG_OF, it is not necessary to use
> of_match_ptr() here.
> 
> Signed-off-by: Ruan Jinjie <ruanjinjie@huawei.com>

Reviewed-by: Takashi Iwai <tiwai@suse.de>


thanks,

Takashi

> ---
>  sound/drivers/serial-generic.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/sound/drivers/serial-generic.c b/sound/drivers/serial-generic.c
> index b0262541802a..c8db6c75d133 100644
> --- a/sound/drivers/serial-generic.c
> +++ b/sound/drivers/serial-generic.c
> @@ -366,7 +366,7 @@ MODULE_DEVICE_TABLE(of, snd_serial_generic_dt_ids);
>  static struct serdev_device_driver snd_serial_generic_driver = {
>  	.driver	= {
>  		.name		= "snd-serial-generic",
> -		.of_match_table	= of_match_ptr(snd_serial_generic_dt_ids),
> +		.of_match_table	= snd_serial_generic_dt_ids,
>  	},
>  	.probe	= snd_serial_generic_probe,
>  };
> -- 
> 2.34.1
> 

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2023-08-11  7:51 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-11  7:14 [PATCH -next 0/5] sound: Remove redundant of_match_ptr() macro Ruan Jinjie
2023-08-11  7:14 ` Ruan Jinjie
2023-08-11  7:14 ` [PATCH -next 1/5] ASoC: atmel: Remove redundant of_match_ptr() Ruan Jinjie
2023-08-11  7:14   ` Ruan Jinjie
2023-08-11  7:14 ` [PATCH -next 2/5] ASoC: atmel: tse850-pcm5142: " Ruan Jinjie
2023-08-11  7:14   ` Ruan Jinjie
2023-08-11  7:14 ` [PATCH -next 3/5] ASoC: sunxi: sun4i-spdif: " Ruan Jinjie
2023-08-11  7:14   ` Ruan Jinjie
2023-08-13 15:22   ` Jernej Škrabec
2023-08-13 15:22     ` Jernej Škrabec
2023-08-11  7:14 ` [PATCH -next 4/5] ASoC: ssm3515: " Ruan Jinjie
2023-08-11  7:14   ` Ruan Jinjie
2023-08-11  7:14 ` [PATCH -next 5/5] ALSA: " Ruan Jinjie
2023-08-11  7:14   ` Ruan Jinjie
2023-08-11  7:49   ` Takashi Iwai [this message]
2023-08-11  7:49     ` Takashi Iwai
2023-08-11  7:51 ` [PATCH -next 0/5] sound: Remove redundant of_match_ptr() macro Takashi Iwai
2023-08-11  7:51   ` Takashi Iwai
2023-08-11  7:59   ` Ruan Jinjie
2023-08-11  7:59     ` Ruan Jinjie
2023-08-14  0:33 ` Mark Brown
2023-08-14  0:33   ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87msyyrpax.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alexandre.belloni@bootlin.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=asahi@lists.linux.dev \
    --cc=broonie@kernel.org \
    --cc=claudiu.beznea@tuxon.dev \
    --cc=jernej.skrabec@gmail.com \
    --cc=lars@metafoo.de \
    --cc=lgirdwood@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-sunxi@lists.linux.dev \
    --cc=nicolas.ferre@microchip.com \
    --cc=nuno.sa@analog.com \
    --cc=peda@axentia.se \
    --cc=perex@perex.cz \
    --cc=povik+lin@cutebit.org \
    --cc=robh@kernel.org \
    --cc=ruanjinjie@huawei.com \
    --cc=samuel@sholland.org \
    --cc=tiwai@suse.com \
    --cc=u.kleine-koenig@pengutronix.de \
    --cc=wens@csie.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.