Re: [PATCH 0/5] Cleanup [h_enter|spapr_exit]_nested routines

[Fabiano Rosas <farosas@suse.de>]

Harsh Prateek Bora <harshpb@linux.ibm.com> writes:

> This patchset introduces helper routines to enable (and does) cleaning
> up of h_enter_nested() and spapr_exit_nested() routines in existing api
> for nested virtualization on Power/SPAPR for better code readability / 
> maintenance. No functional changes intended with this patchset.

Do we have tests for this nested virtual hypervisor code? It would be
good to have at least a smoke test. I remember someone started adding
support to qemu-ppc-boot, probably Murilo. I suggest you take a look
around and maybe see what it takes to add it.

Just a L0 TCG with a small-ish qemu inside of it and a script to start
an L2.

>
> Harsh Prateek Bora (5):
>   ppc: spapr: cleanup cr get/store with helper routines.
>   ppc: spapr: cleanup h_enter_nested() with helper routines.
>   ppc: spapr: assert early rather late in h_enter_nested()
>   ppc: spapr: cleanup spapr_exit_nested() with helper routines.
>   MAINTAINERS: Adding myself in the list for ppc/spapr
>
>  MAINTAINERS          |   1 +
>  hw/ppc/spapr_hcall.c | 251 ++++++++++++++++++++++++-------------------
>  target/ppc/cpu.c     |  17 +++
>  target/ppc/cpu.h     |   2 +
>  4 files changed, 161 insertions(+), 110 deletions(-)