All of lore.kernel.org
 help / color / mirror / Atom feed
* [Intel-xe] [PATCH] drm/xe: Fix Alderlake-P and DG2 display info
@ 2023-03-16 11:07 Maarten Lankhorst
  2023-03-16 11:10 ` [Intel-xe] ✓ CI.Patch_applied: success for " Patchwork
                   ` (6 more replies)
  0 siblings, 7 replies; 10+ messages in thread
From: Maarten Lankhorst @ 2023-03-16 11:07 UTC (permalink / raw)
  To: intel-xe

DG2 has cdclk squash, without which we calculate the CDCLK wrongly.
Alderlake-P is LPD, not gen 12 display.

With those fixed, display should work on both and all problems that were
uncovered by testing done from rebasing are fixed.

Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
---
 drivers/gpu/drm/xe/xe_display.c | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/xe/xe_display.c b/drivers/gpu/drm/xe/xe_display.c
index f28553be858d..54ec8ba5d3f3 100644
--- a/drivers/gpu/drm/xe/xe_display.c
+++ b/drivers/gpu/drm/xe/xe_display.c
@@ -482,19 +482,27 @@ void xe_display_info_init(struct xe_device *xe)
 		xe->info.display = (struct xe_device_display_info) { GEN12_DISPLAY };
 		break;
 	case XE_ALDERLAKE_S:
-	case XE_ALDERLAKE_P:
 		xe->info.display = (struct xe_device_display_info) {
 			GEN12_DISPLAY,
 			.has_hti = 1,
 			.has_psr_hw_tracking = 0,
 		};
 		break;
+	case XE_ALDERLAKE_P:
+		xe->info.display = (struct xe_device_display_info) {
+			XE_LPD,
+			.has_cdclk_crawl = 1,
+			.has_modular_fia = 1,
+			.has_psr_hw_tracking = 0,
+		};
+		break;
 	case XE_DG2:
 		xe->info.display = (struct xe_device_display_info) {
 			XE_LPD,
 			.cpu_transcoder_mask =
 				BIT(TRANSCODER_A) | BIT(TRANSCODER_B) |
 				BIT(TRANSCODER_C) | BIT(TRANSCODER_D),
+			.has_cdclk_squash = 1,
 		};
 		break;
 	case XE_METEORLAKE:
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 10+ messages in thread
end of thread, other threads:[~2023-03-16 14:07 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-03-16 11:07 [Intel-xe] [PATCH] drm/xe: Fix Alderlake-P and DG2 display info Maarten Lankhorst
2023-03-16 11:10 ` [Intel-xe] ✓ CI.Patch_applied: success for " Patchwork
2023-03-16 11:11 ` [Intel-xe] ✓ CI.KUnit: " Patchwork
2023-03-16 11:15 ` [Intel-xe] ✓ CI.Build: " Patchwork
2023-03-16 11:26 ` [Intel-xe] ○ CI.BAT: info " Patchwork
2023-03-16 14:06   ` Lucas De Marchi
2023-03-16 12:17 ` [Intel-xe] [PATCH] " Thomas Hellström
2023-03-16 12:21 ` Matthew Auld
2023-03-16 12:46   ` Maarten Lankhorst
2023-03-16 13:05 ` Jani Nikula

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.